Add error logging for silenced Elasticsearch exceptions#1298
Open
NAME-ASHWANIYADAV wants to merge 1 commit into
Open
Add error logging for silenced Elasticsearch exceptions#1298NAME-ASHWANIYADAV wants to merge 1 commit into
NAME-ASHWANIYADAV wants to merge 1 commit into
Conversation
Author
|
@joaquinvanschoren @janvanrijn PTAL!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves several maintainer TODOs by adding proper error logging to empty
catchblocks that previously swallowed ElasticSearch exceptions silently.Changes made:
catchblocks in API models (Api_data,Api_flow,Api_run,Api_study) withlog_message('error', ...)calls.ElasticSearch.phpto log exceptions alongside the existingechostatements.[Api_data]), the entity type/ID, and the exception message.Why this is needed:
When ElasticSearch indexing fails during entity uploads, the errors were previously ignored, making production debugging difficult. Logging these via CodeIgniter's built-in
log_messageensures failures are captured in the configured log path (e.g.,/var/www/openml/logs/).Related Issues:
Fixes #1297