Skip to content

SRVKP-12177: fix to reset Pagination for ConsoleDataView when Filtering by name#1090

Open
arvindk-softwaredev wants to merge 1 commit into
openshift-pipelines:masterfrom
arvindk-softwaredev:fix/SRVKP-12177
Open

SRVKP-12177: fix to reset Pagination for ConsoleDataView when Filtering by name#1090
arvindk-softwaredev wants to merge 1 commit into
openshift-pipelines:masterfrom
arvindk-softwaredev:fix/SRVKP-12177

Conversation

@arvindk-softwaredev
Copy link
Copy Markdown
Contributor

Summary

  • Fixes pagination not resetting to page 1 when filtering PipelineRuns by name in the Overview list pages
  • When a user types in the name filter, the page search param is now explicitly set to 1, ensuring ConsoleDataView shows results from the first page instead of potentially showing an empty page

Changes

The fix uses useSearchParams from react-router to reset page to 1 inside the name-filter handler in both components.

  1. PipelineRunsListPage.tsx
  2. PipelineRunsListPageK8s.tsx

Test Plan

  • Navigate to the Pipelines Overview page
  • Go to the PipelineRuns list tab
  • Page forward (e.g. go to page 2 or 3)
  • Type a filter string in the name search box
  • Verify the list resets to page 1 and shows matching results
  • Verify clearing the filter still works correctly and pagination is functional

Screen Recordings

Before

SRVKP-12177_Before.mov

After Fix - Tekton Results

SRVKP-12177_AfterFix-TektonResults-1080p.mov

After Fix - Prometheus

SRVKP-12177_AfterFix-Prometheus-1080p.mov

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

openshift-ci-robot commented May 29, 2026

@arvindk-softwaredev: This pull request references SRVKP-12177 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Fixes pagination not resetting to page 1 when filtering PipelineRuns by name in the Overview list pages
  • When a user types in the name filter, the page search param is now explicitly set to 1, ensuring ConsoleDataView shows results from the first page instead of potentially showing an empty page

Changes

The fix uses useSearchParams from react-router to reset page to 1 inside the name-filter handler in both components.

  1. PipelineRunsListPage.tsx
  2. PipelineRunsListPageK8s.tsx

Test Plan

  • Navigate to the Pipelines Overview page
  • Go to the PipelineRuns list tab
  • Page forward (e.g. go to page 2 or 3)
  • Type a filter string in the name search box
  • Verify the list resets to page 1 and shows matching results
  • Verify clearing the filter still works correctly and pagination is functional

Screen Recordings

Before

SRVKP-12177_Before.mov

After Fix - Tekton Results

SRVKP-12177_AfterFix-TektonResults-1080p.mov

After Fix - Prometheus

SRVKP-12177_AfterFix-Prometheus-1080p.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arvindk-softwaredev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [arvindk-softwaredev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label May 29, 2026
@anwesha-palit-redhat
Copy link
Copy Markdown
Contributor

Verified

Verified.and.working.as.expected.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs jira/valid-reference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants