Skip to content

CORS-4417: Add UniverseDomain field to GCPPlatformStatus #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barbacbd wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −0
Open

CORS-4417: Add UniverseDomain field to GCPPlatformStatus #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,21 @@ type GCPPlatformStatus struct {
// +optional
// +openshift:enable:FeatureGate=GCPCustomAPIEndpointsInstall
// ServiceEndpoints []GCPServiceEndpoint `json:"serviceEndpoints,omitempty"`

// universeDomain is the GCP universe domain for the cluster, detected from
// the installer credentials. Components with their own GCP credentials should
// read the universe domain from those credentials, as they are the authoritative
// source. This field is provided for components that do not have GCP credentials
// and for general observability.
//
// When omitted, standard public GCP (googleapis.com) is assumed.
//
// universeDomain must be between 1 and 253 characters in length.
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
// +optional
UniverseDomain string `json:"universeDomain,omitempty"`
}

// GCPResourceLabel is a label to apply to GCP resources created for the cluster.
Expand Down
1 change: 1 addition & 0 deletions config/v1/zz_generated.swagger_doc_generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions openapi/generated_openapi/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions openapi/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7208,6 +7208,10 @@
"key"
],
"x-kubernetes-list-type": "map"
},
"universeDomain": {
"description": "universeDomain is the GCP universe domain for the cluster, detected from the installer credentials. Components with their own GCP credentials should read the universe domain from those credentials, as they are the authoritative source. This field is provided for components that do not have GCP credentials and for general observability.\n\nWhen omitted, standard public GCP (googleapis.com) is assumed.\n\nuniverseDomain must be between 1 and 253 characters in length.",
"type": "string"
}
}
},
Expand Down