[DRAFT] OCPCRT-490 - Improve launch notification sequence for custom builds

[thiagoalessio]

/hold

Summary by CodeRabbit

• New Features

  • Added clearer progress messaging for jobs that use custom PR builds, including an additional 20–40 minute estimate and a total estimate of up to approximately 90 minutes.
  • Increased setup time allowances for jobs requiring source-reference preparation.

• Bug Fixes

  • Improved job startup handling to avoid reporting premature failures when the underlying job is still running.
  • Ongoing jobs can now continue through regular status synchronization.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thiagoalessio
Once this PR has been reviewed and has the lgtm label, please assign hoxhaeris for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Job startup flow

Layer / File(s)	Summary
Ref-aware launch timing and messaging pkg/manager/prow.go, pkg/manager/manager.go	jobHasRefs centralizes ref detection for job setup and launch configuration, adds 30 minutes to ref-based setup time, and appends the corresponding estimate to user-facing launch messages.
Active ProwJob startup recovery pkg/manager/manager.go	Startup handling checks whether a ProwJob remains active after a cluster-availability error and defers completion handling to the sync loop when appropriate.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: alexnpavel

Sequence Diagram(s)

sequenceDiagram
  participant handleJobStartup
  participant waitForJob
  participant prowJobIsStillRunning
  participant SyncLoop
  handleJobStartup->>waitForJob: wait for cluster availability
  waitForJob-->>handleJobStartup: cluster never became available
  handleJobStartup->>prowJobIsStillRunning: query ProwJob status
  prowJobIsStillRunning-->>handleJobStartup: ProwJob still running
  handleJobStartup->>SyncLoop: defer completion handling

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: launch messaging for custom builds, though it omits the startup error-handling adjustment.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thiagoalessio]

oh, all the checks are aborted when PR is marked as "draft" :(

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/manager/manager.go`:
- Around line 2476-2477: Update the cluster-availability branch in the job
monitoring flow to return immediately after logging that a still-running ProwJob
is being deferred to the sync loop. Ensure execution does not continue to
m.finishedJob(job) for this case, while preserving the existing behavior for
other branches.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 69310bf2-aaf3-456a-8b2b-ad09b3e6c2cb

📥 Commits

Reviewing files that changed from the base of the PR and between 6752288 and 74d2531.

📒 Files selected for processing (2)

• pkg/manager/manager.go
• pkg/manager/prow.go

[openshift-ci]

@thiagoalessio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/govulncheck	002770f	link	false	/test govulncheck

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.