Skip to content

OCPBUGS-96784: bump golang.org/x/crypto to v0.52.0 for CVE-2026-39829#16734

Open
Cragsmann wants to merge 2 commits into
openshift:mainfrom
Cragsmann:OCPBUGS-96784-cve-2026-39829
Open

OCPBUGS-96784: bump golang.org/x/crypto to v0.52.0 for CVE-2026-39829#16734
Cragsmann wants to merge 2 commits into
openshift:mainfrom
Cragsmann:OCPBUGS-96784-cve-2026-39829

Conversation

@Cragsmann

@Cragsmann Cragsmann commented Jul 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Bumps golang.org/x/crypto from v0.51.0 to v0.52.0
  • Fixes CVE-2026-39829: Denial of Service via crafted public key with excessive RSA/DSA parameters in golang.org/x/crypto/ssh
  • CVSS 7.5 (High)

Details

Prior to v0.52.0, the SSH public key parsers in golang.org/x/crypto/ssh did not enforce size limits on incoming RSA/DSA key parameters. An unauthenticated attacker could submit a crafted public key with pathologically large parameters, causing intensive CPU computation during signature verification and leading to denial of service.

Test plan

  • go mod verify passes
  • CI build succeeds
  • No behavioral changes expected (indirect dependency bump)

Fixes: https://issues.redhat.com/browse/OCPBUGS-96784

Summary by CodeRabbit

  • Chores
    • Updated an indirect Go dependency, golang.org/x/crypto, to a newer version.

@Cragsmann
OCPBUGS-96784: bump golang.org/x/crypto to v0.52.0 for CVE-2026-39829
4fbff1f 
Fixes denial of service via crafted public key with excessive
RSA/DSA parameters in golang.org/x/crypto/ssh.

Upgrades golang.org/x/crypto from v0.51.0 to v0.52.0.
@openshift-merge-bot

openshift-merge-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 8, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@Cragsmann: This pull request references Jira Issue OCPBUGS-96784, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Bumps golang.org/x/crypto from v0.51.0 to v0.52.0
  • Fixes CVE-2026-39829: Denial of Service via crafted public key with excessive RSA/DSA parameters in golang.org/x/crypto/ssh
  • CVSS 7.5 (High)

Details

Prior to v0.52.0, the SSH public key parsers in golang.org/x/crypto/ssh did not enforce size limits on incoming RSA/DSA key parameters. An unauthenticated attacker could submit a crafted public key with pathologically large parameters, causing intensive CPU computation during signature verification and leading to denial of service.

Test plan

  • go mod verify passes
  • CI build succeeds
  • No behavioral changes expected (indirect dependency bump)

Fixes: https://issues.redhat.com/browse/OCPBUGS-96784

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (12)
  • vendor/golang.org/x/crypto/blake2b/go125.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/agent/client.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/agent/keyring.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/agent/server.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/certs.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/channel.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/cipher.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/keys.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/knownhosts/knownhosts.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/mux.go is excluded by !**/vendor/**, !vendor/**
  • vendor/golang.org/x/crypto/ssh/server.go is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5538b5f6-5bc3-4b4a-997b-3f9a14dcb8ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This change updates the indirect Go module dependency golang.org/x/crypto in go.mod from version v0.51.0 to v0.52.0. No other files or code are modified.

Changes

Dependency Update

Layer / File(s) Summary
golang.org/x/crypto version bump
go.mod		 Updated the indirect golang.org/x/crypto dependency from v0.51.0 to v0.52.0 in the require list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers summary, details, and test plan, but it omits required template sections like analysis, solution description, and reviewers. Add the missing template sections, especially Analysis/Root cause, Solution description, Test setup, Test cases, Browser conformance, and Reviewers/assignees.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the PR's dependency bump and CVE fix, and it includes the required Jira prefix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only bumps go.mod/go.sum; no test files or Ginkgo titles were changed, so the check is not applicable.
Test Structure And Quality ✅ Passed PR only bumps golang.org/x/crypto in go.mod/go.sum; no Ginkgo test code or test patterns were changed.
Microshift Test Compatibility ✅ Passed Only go.mod and go.sum changed; no Ginkgo/e2e tests were added or modified, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only bumps golang.org/x/crypto in go.mod/go.sum; no new Ginkgo e2e tests or SNO-sensitive logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod/go.sum changed for an indirect crypto bump; no manifests, controllers, or scheduling code were modified.
Ote Binary Stdout Contract ✅ Passed Only go.mod/go.sum changed; no process-level code or stdout/logging setup was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only go.mod/go.sum changed for a dependency bump; no new or modified Ginkgo e2e tests to audit for IPv4 or external connectivity assumptions.
No-Weak-Crypto ✅ Passed PR only bumps golang.org/x/crypto in go.mod and updates go.sum; no code adds weak ciphers, custom crypto, or insecure comparisons.
Container-Privileges ✅ Passed Only go.mod and go.sum changed; no container/K8s manifests or privilege settings were added.
No-Sensitive-Data-In-Logs ✅ Passed PR only updates go.mod/go.sum for golang.org/x/crypto; no source changes or logging paths exposing sensitive data were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from rhamilto and spadgett July 8, 2026 10:27
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cragsmann
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@Cragsmann: This pull request references Jira Issue OCPBUGS-96784, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Summary

  • Bumps golang.org/x/crypto from v0.51.0 to v0.52.0
  • Fixes CVE-2026-39829: Denial of Service via crafted public key with excessive RSA/DSA parameters in golang.org/x/crypto/ssh
  • CVSS 7.5 (High)

Details

Prior to v0.52.0, the SSH public key parsers in golang.org/x/crypto/ssh did not enforce size limits on incoming RSA/DSA key parameters. An unauthenticated attacker could submit a crafted public key with pathologically large parameters, causing intensive CPU computation during signature verification and leading to denial of service.

Test plan

  • go mod verify passes
  • CI build succeeds
  • No behavioral changes expected (indirect dependency bump)

Fixes: https://issues.redhat.com/browse/OCPBUGS-96784

Summary by CodeRabbit

  • Chores
  • Updated an indirect Go dependency, golang.org/x/crypto, to a newer version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Cragsmann @claude
fix: sync vendor directory after x/crypto bump
3e75222 
Run `go mod tidy && go mod vendor` to fix vendor inconsistency
detected by CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Cragsmann

Cragsmann commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@Cragsmann

Cragsmann commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@Cragsmann

Cragsmann commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto
@spadgett spadgett Awaiting requested review from spadgett

Assignees

No one assigned

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cragsmann @openshift-ci-robot