Skip to content

OCPBUGS-96717: pin basic-ftp to ^5.3.1 for CVE-2026-44240#16737

Open
Cragsmann wants to merge 1 commit into
openshift:mainfrom
Cragsmann:OCPBUGS-96717-cve-2026-44240
Open

OCPBUGS-96717: pin basic-ftp to ^5.3.1 for CVE-2026-44240#16737
Cragsmann wants to merge 1 commit into
openshift:mainfrom
Cragsmann:OCPBUGS-96717-cve-2026-44240

Conversation

@Cragsmann

Copy link
Copy Markdown
Contributor

Summary

  • Adds yarn resolution to force basic-ftp >= 5.3.1 (transitive dependency via get-uri)
  • Fixes CVE-2026-44240: Client-side Denial of Service via unterminated multiline FTP responses
  • CVSS 7.5 (High)

Details

basic-ftp prior to 5.3.1 is vulnerable to uncontrolled resource consumption (CWE-400) when parsing FTP control-channel multiline responses. A malicious FTP server can send an unterminated multiline response, causing the client to accumulate unbounded data in memory, leading to process-level denial of service.

Patched in basic-ftp 5.3.1.

Test plan

  • yarn install succeeds
  • CI build succeeds
  • No behavioral changes expected (transitive dependency resolution)

Fixes: https://issues.redhat.com/browse/OCPBUGS-96717

Fixes client-side denial of service via unterminated multiline
FTP responses (CVSS 7.5).

Adds yarn resolution to force basic-ftp >=5.3.1 (transitive
dependency via get-uri).
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Cragsmann: This pull request references Jira Issue OCPBUGS-96717, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • Adds yarn resolution to force basic-ftp >= 5.3.1 (transitive dependency via get-uri)
  • Fixes CVE-2026-44240: Client-side Denial of Service via unterminated multiline FTP responses
  • CVSS 7.5 (High)

Details

basic-ftp prior to 5.3.1 is vulnerable to uncontrolled resource consumption (CWE-400) when parsing FTP control-channel multiline responses. A malicious FTP server can send an unterminated multiline response, causing the client to accumulate unbounded data in memory, leading to process-level denial of service.

Patched in basic-ftp 5.3.1.

Test plan

  • yarn install succeeds
  • CI build succeeds
  • No behavioral changes expected (transitive dependency resolution)

Fixes: https://issues.redhat.com/browse/OCPBUGS-96717

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Cragsmann, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1d9e8792-0aba-41b1-b72e-3a221cefa06c

📥 Commits

Reviewing files that changed from the base of the PR and between fd6a21a and 52df120.

⛔ Files ignored due to path filters (1)
  • frontend/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • frontend/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett July 8, 2026 10:49
@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cragsmann
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants