Skip to content

[release-4.17] OCPBUGS-84283: Bump follow-redirects to 1.16.0 to fix CVE-2026-40895#16738

Open
amitesh1201 wants to merge 1 commit into
openshift:release-4.17from
amitesh1201:CVE-2026-40895-follow-redirects-4.17
Open

[release-4.17] OCPBUGS-84283: Bump follow-redirects to 1.16.0 to fix CVE-2026-40895#16738
amitesh1201 wants to merge 1 commit into
openshift:release-4.17from
amitesh1201:CVE-2026-40895-follow-redirects-4.17

Conversation

@amitesh1201

@amitesh1201 amitesh1201 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • CVE: CVE-2026-40895 — Information disclosure via custom authentication headers in cross-domain redirects
  • Package: follow-redirects → 1.16.0 (transitive dependency)

Changes

  • Added yarn resolution for follow-redirects@^1.16.0 in frontend/package.json
  • Updated frontend/yarn.lock

Test Plan

  • yarn build succeeds

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@amitesh1201: This pull request references Jira Issue OCPBUGS-84283, which is invalid:

  • expected dependent Jira Issue OCPBUGS-84284 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • CVE: CVE-2026-40895 — Information disclosure via custom authentication headers in cross-domain redirects
  • Package: follow-redirects → 1.16.0 (transitive dependency)
  • Risk Level: LOW (development-only dependency, not in production)

Impact

  • Production: NOT AFFECTED (webpack-dev-server and http-server are devDependencies, not deployed)
  • Development: Potentially affected (local dev server only)

Changes

  • Added yarn resolution for follow-redirects@^1.16.0 in frontend/package.json
  • Added yarn resolution for follow-redirects@^1.16.0 in dynamic-demo-plugin/package.json
  • Updated frontend/yarn.lock
  • Updated dynamic-demo-plugin/yarn.lock

Test Plan

  • yarn build succeeds (production build)
  • dynamic-demo-plugin/ installs without errors

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 80700f12-5ca7-4321-8af4-37da957c6b49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from christianvogt and rhamilto July 8, 2026 12:49
@amitesh1201

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

1 similar comment
@amitesh1201

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@germanparente

Copy link
Copy Markdown
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 10, 2026
@amitesh1201

Copy link
Copy Markdown
Contributor Author

/retest-required

2 similar comments
@amitesh1201

Copy link
Copy Markdown
Contributor Author

/retest-required

@ocp-sustaining-admins

Copy link
Copy Markdown

/retest-required

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This yarn.lock looks like it contains a bunch of unrelated changes, please double check this diff

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, PRs has been revised to update only required changes. Dynamic-demo-plugin related changes dropped.

@logonoff

Copy link
Copy Markdown
Member

/label backport-risk-assessed

@amitesh1201

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2026
Add follow-redirects resolution to pin >=1.16.0 in frontend/ workspace.

Signed-off-by: Amit Yadav <ayadav@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@amitesh1201 amitesh1201 force-pushed the CVE-2026-40895-follow-redirects-4.17 branch from bb9dab5 to f8dbab1 Compare July 14, 2026 09:29
@amitesh1201

Copy link
Copy Markdown
Contributor Author

/test backend

@amitesh1201

Copy link
Copy Markdown
Contributor Author

/hold cancel
/jira refresh

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@amitesh1201: This pull request references Jira Issue OCPBUGS-84283, which is invalid:

  • expected dependent Jira Issue OCPBUGS-84284 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/hold cancel
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitesh1201, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2026
@openshift-ci

openshift-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@amitesh1201: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console f8dbab1 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants