Skip to content

CONSOLE-5394: Update Quick create tooltip to clarify cluster context#16744

Draft
itsptk wants to merge 2 commits into
openshift:mainfrom
itsptk:CONSOLE-5394
Draft

CONSOLE-5394: Update Quick create tooltip to clarify cluster context#16744
itsptk wants to merge 2 commits into
openshift:mainfrom
itsptk:CONSOLE-5394

Conversation

@itsptk

@itsptk itsptk commented Jul 9, 2026

Copy link
Copy Markdown

Analysis / Root cause:
Users cannot tell which cluster context the masthead Quick create (+) action applies to. UX research recommendation: UXDR-4295. Jira: CONSOLE-5394. Design story: HPUX-1884.

Solution description:
Update the Quick create masthead tooltip and aria-label from "Quick create" to "Quick create in cluster".

Exploration (reverted): An earlier commit on this branch used Infrastructure/clusterstatus.infrastructureName to show a dynamic cluster name. Console team / helpdesk review concluded this field is an internal infrastructure ID (install name truncated to 21 chars + random 5-char suffix), not a user-facing display name. Examples: babbar-9d6hs, ci-op-30rwpbly-96d3d-7hnn8. The console already fetches Infrastructure/cluster on cluster Overview but shows API URL, Cluster ID (UUID), and platform — not infrastructureName.

Historical context: There is no canonical on-cluster cluster display name in core OCP CRDs today. Related prior work:

Static copy is the safer path until a proper display name API exists. A proper cluster display name in the masthead/tab title would be a separate effort.

Screenshots / screen recording:
Old tooltip:
image

New tooltip:
image

Test setup:

  • cd frontend && yarn run dev
  • source ./contrib/oc-environment.sh && ./bin/bridge
  • Open http://localhost:9000 and hover the masthead + button

Test cases:

  • Tooltip shows "Quick create in cluster"
  • aria-label matches tooltip text
  • Quick create dropdown options unchanged

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Draft — open for UX review. No API fetch required; minimal change aligned with Jira acceptance criteria.

Reviewers and assignees:
@openshift/team-ux-review

Update the Quick create (+) tooltip and aria-label to use the cluster
infrastructureName from the Infrastructure resource, with a fallback
while loading.

https: //redhat.atlassian.net/browse/CONSOLE-5394
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@itsptk: This pull request references CONSOLE-5394 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Analysis / Root cause:
Users cannot tell which cluster context the masthead Quick create (+) action applies to. UX research recommendation: UXDR-4295. Jira: CONSOLE-5394.

Solution description:

  • Fetch Infrastructure/cluster and read status.infrastructureName
  • Update Quick create tooltip and aria-label to Quick create in {{clusterName}}
  • Fallback to Quick create in cluster while loading or if name unavailable
  • Add getInfrastructureName selector and unit tests

Screenshots / screen recording:

Test setup:

  • OpenShift cluster with infrastructureName set
  • cd frontend && yarn run dev
  • source ./contrib/oc-environment.sh && ./bin/bridge
  • Open http://localhost:9000 and hover the masthead + button

Test cases:

  • Tooltip shows cluster name after Infrastructure loads
  • aria-label matches tooltip text
  • Quick create dropdown options unchanged
  • Fallback text shown while Infrastructure is loading

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:
Draft — do not merge. Pending PM/product alignment on final copy (dynamic infrastructureName vs static "in cluster" as written in CONSOLE-5394 acceptance criteria).

Reviewers and assignees:
@openshift/team-ux-review

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsptk
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The Quick create dropdown tooltip and accessibility label now use “Quick create in cluster,” with the matching English localization key replacing the generic label.

Changes

Quick create cluster label

Layer / File(s) Summary
Update cluster-specific toggle label
frontend/public/components/QuickCreate.tsx, frontend/public/locales/en/public.json
The dropdown tooltip, accessibility label, and English translation key now use Quick create in cluster.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No test titles were added or modified; the only spec file change deletes static titles, and the remaining diff has no test definitions.
Test Structure And Quality ✅ Passed No Ginkgo tests were added or modified; only a deleted Jest spec and UI copy changes, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the only test change is removal of a Jest unit test, so MicroShift compatibility checks are not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the PR only changes QuickCreate UI text and selector/localization code.
Topology-Aware Scheduling Compatibility ✅ Passed PR only changes QuickCreate copy and an infrastructure selector; no deployment manifests, controllers, replicas, affinity, or node selectors were added.
Ote Binary Stdout Contract ✅ Passed PR only adjusts frontend copy/selector code; no main/init/TestMain/BeforeSuite stdout writes were added or touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo/e2e tests were added; the diff only changes QuickCreate copy/selector code and deletes a unit test, with no IPv4 or external-network code.
No-Weak-Crypto ✅ Passed Touched code only updates cluster-name tooltip copy and removes an infrastructureName selector; no weak crypto or secret comparison patterns found.
Container-Privileges ✅ Passed PR touches only frontend tooltip/locales and a selector; no K8s/container manifests or privilege settings were added.
No-Sensitive-Data-In-Logs ✅ Passed The patch only changes Quick Create copy and removes the infrastructure-name selector/tests; no new console/logger calls or sensitive-data logging are introduced.
Title check ✅ Passed The title is specific, Jira-prefixed, and matches the main change to the Quick create tooltip copy.
Description check ✅ Passed All required template sections are present and filled with relevant details, including screenshots, tests, and reviewers.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Revert the infrastructureName-based tooltip. Console team review
confirmed status.infrastructureName is an internal infra slug (install
name plus random suffix), not a user-facing display name. The console
already fetches Infrastructure/cluster on Overview but deliberately
shows API URL, Cluster ID, and platform instead.

There is no canonical on-cluster cluster display name today; see
CONSOLE-2217 and the cluster naming doc. ACM and OCM use separate
identifiers. Static copy matches the Jira acceptance criteria and
avoids showing opaque values like babbar-9d6hs in the masthead.

https: //redhat.atlassian.net/browse/CONSOLE-5394
Co-authored-by: Cursor <cursoragent@cursor.com>
@itsptk itsptk changed the title CONSOLE-5394: Update Quick create tooltip to show cluster name CONSOLE-5394: Update Quick create tooltip to clarify cluster context Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality component/shared Related to console-shared do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants