OCPBUGS-98489: CVE-2026-59869 bump js-yaml#16760
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@vikram-raj: This pull request references Jira Issue OCPBUGS-98489, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe frontend updates its ChangesFrontend YAML dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vikram-raj: This pull request references Jira Issue OCPBUGS-98489, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/package.json`:
- Line 193: Update the js-yaml dependency in package.json from the caret range
to the exact patched version 3.15.0, then regenerate and commit the
corresponding lockfile entry with its verified integrity hash.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 23f31359-6653-4653-ad2a-f2cba0a7e62e
⛔ Files ignored due to path filters (1)
frontend/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
frontend/package.json
| "istextorbinary": "^9.5.0", | ||
| "js-base64": "^3.7.7", | ||
| "js-yaml": "^3.13.1", | ||
| "js-yaml": "^3.15.0", |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Pin the patched release exactly.
^3.15.0 permits future 3.x resolutions, which conflicts with the required exact-version policy. Use "3.15.0" and commit the regenerated lockfile with its integrity hash. OSV and the upstream changelog identify 3.15.0 as the patched v3 release. (osv.dev)
Proposed fix
- "js-yaml": "^3.15.0",
+ "js-yaml": "3.15.0",As per path instructions: pin exact versions and verify hashes where supported.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "js-yaml": "^3.15.0", | |
| "js-yaml": "3.15.0", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/package.json` at line 193, Update the js-yaml dependency in
package.json from the caret range to the exact patched version 3.15.0, then
regenerate and commit the corresponding lockfile entry with its verified
integrity hash.
Source: Path instructions
|
@vikram-raj: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Analysis / Root cause:
CVE-2026-59869: js-yaml versions 3.0.0 to before 3.15.0 and 4.0.0 to before 4.3.0 can spend
quadratic CPU time parsing YAML documents with chained merge keys, enabling Denial of Service
via crafted payloads of only tens of kilobytes.
Jira: https://redhat.atlassian.net/browse/OCPBUGS-98489
Solution description:
Bump the direct
js-yamldependency from^3.13.1to^3.15.0(patched). The yarn lockfilenaturally resolves v4 consumers to 4.3.0 (also patched), so both v3 and v4 dependents get the
fix with their expected API.
Screenshots / screen recording:
N/A — dependency-only change, no UI impact.
Test setup:
No special setup required.
Test cases:
yarn installcompletes successfullyyarn buildcompletes successfullyyarn.lockshows js-yaml 3.15.0 for v3 consumers and 4.3.0 for v4 consumersBrowser conformance:
N/A — no UI changes.
Additional info:
Summary by CodeRabbit