PF5: Tests: Fix goToPodDetails helper flakiness

[kyoto]

Manual backport of #2076

Summary by CodeRabbit

• Tests
  • Improved the pod navigation test helper by selecting the pod row link that matches the provided pod name, with an explicit wait for the link to become visible (up to 30s) before clicking—making the test more reliable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8b964ad1-15ae-4969-8f32-561630678120

📥 Commits

Reviewing files that changed from the base of the PR and between e0b4d82 and e73a95a.

📒 Files selected for processing (1)

• tests/tests/lightspeed.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/tests/lightspeed.spec.ts

---

📝 Walkthrough

Walkthrough

The goToPodDetails helper now filters pod rows by podName, waits up to 30 seconds for the matching link to become visible, and clicks it instead of using a generic first-link selection.

Changes

Pod navigation targeting

Layer / File(s)	Summary
Targeted pod link selection tests/tests/lightspeed.spec.ts	Filters resourceRows by pod name, waits for the matching link, and clicks it. Removes the previous row-count assertion and generic first-link click.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• openshift/lightspeed-console#2081: Updates the same helper with matching pod-row filtering and visibility-wait logic.

Suggested reviewers: joaofula, syedriko

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: fixing flakiness in the goToPodDetails test helper.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

🧹 Nitpick comments (1)

tests/tests/lightspeed.spec.ts (1)

37-39: ⚡ Quick win

Consider storing .first() result and improving variable naming.

The variable link is somewhat misleading as it contains a row locator rather than a link element. Additionally, calling .first() twice (lines 38 and 39) re-evaluates the locator each time. While Playwright's auto-waiting should handle this safely, storing the result would improve clarity and ensure the exact same element is validated and clicked.

♻️ Suggested refactor

- const link = page.locator(resourceRows).filter({ hasText: podName });
- await expect(link.first()).toBeVisible({ timeout: 30_000 });
- await link.first().click();
+ const matchingRows = page.locator(resourceRows).filter({ hasText: podName });
+ const firstRow = matchingRows.first();
+ await expect(firstRow).toBeVisible({ timeout: 30_000 });
+ await firstRow.click();

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/tests/lightspeed.spec.ts` around lines 37 - 39, The variable name
`link` is misleading because it holds a row locator, not a link element, and
calling `.first()` twice (in the expect statement and click statement)
re-evaluates the locator unnecessarily. Rename the `link` variable to something
more descriptive like `resourceRow` to better reflect that it contains a row
element, then store the result of `.first()` in a separate variable (e.g.,
`firstRow`) so that the exact same element is validated with expect and clicked
without re-evaluation.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/tests/lightspeed.spec.ts`:
- Around line 37-39: The variable name `link` is misleading because it holds a
row locator, not a link element, and calling `.first()` twice (in the expect
statement and click statement) re-evaluates the locator unnecessarily. Rename
the `link` variable to something more descriptive like `resourceRow` to better
reflect that it contains a row element, then store the result of `.first()` in a
separate variable (e.g., `firstRow`) so that the exact same element is validated
with expect and clicked without re-evaluation.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 482c5eb8-5956-4dd4-9818-9456b7b0348b

📥 Commits

Reviewing files that changed from the base of the PR and between 65d00db and e0b4d82.

📒 Files selected for processing (1)

• tests/tests/lightspeed.spec.ts

[openshift-ci]

New changes are detected. LGTM label has been removed.

[kyoto]

/retest