Update dependency typescript to v7#2260
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughUpdates the ChangesTypeScript dependency
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 50: Update the package.json TypeScript dependency from ^7.0.0 to a
version range below 6.1.0, preserving compatibility with the currently locked
`@typescript-eslint` parser and plugin.
- Line 50: Revert the TypeScript version in package.json from 7.x to a version
compatible with the existing `@typescript-eslint` packages and package-lock
resolution, or upgrade the entire lint toolchain together and regenerate the
lockfile; keep package.json and package-lock.json consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6047de98-de1c-4506-8af4-5a810eda4559
📒 Files selected for processing (1)
package.json
| "ts-loader": "^9.6.0", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^5.9.3", | ||
| "typescript": "^7.0.0", |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
jq -r '
.packages["node_modules/@typescript-eslint/parser"].peerDependencies.typescript,
.packages["node_modules/@typescript-eslint/eslint-plugin"].peerDependencies.typescript
' package-lock.jsonRepository: openshift/lightspeed-console
Length of output: 196
Keep TypeScript below 6.1.0 until @typescript-eslint is upgraded. The locked parser and plugin only allow >=4.8.4 <6.1.0, so typescript@^7.0.0 is outside their supported range and can break lint/type-check.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 50, Update the package.json TypeScript dependency from
^7.0.0 to a version range below 6.1.0, preserving compatibility with the
currently locked `@typescript-eslint` parser and plugin.
Source: MCP tools
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
jq -r '
{
manifest: (.devDependencies.typescript // .dependencies.typescript),
lock_root: .packages[""].devDependencies.typescript,
resolved: .packages["node_modules/typescript"].version
}
' package.json package-lock.jsonRepository: openshift/lightspeed-console
Length of output: 301
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\npackage.json (typescript-related lines)\n'
grep -n '"typescript"' -n package.json || true
printf '\npackage-lock.json root and typescript entries\n'
python3 - <<'PY'
import json
from pathlib import Path
for path in ["package.json", "package-lock.json"]:
data = json.loads(Path(path).read_text())
print(f"\n== {path} ==")
if path == "package.json":
for k in ("dependencies", "devDependencies", "optionalDependencies", "peerDependencies"):
if k in data and "typescript" in data[k]:
print(k, data[k]["typescript"])
else:
pkgs = data.get("packages", {})
root = pkgs.get("", {})
print("root devDependencies.typescript =", root.get("devDependencies", {}).get("typescript"))
ts = pkgs.get("node_modules/typescript", {})
print("node_modules/typescript.version =", ts.get("version"))
print("node_modules/typescript.resolved =", ts.get("resolved"))
print("node_modules/typescript.integrity =", ts.get("integrity"))
for name in ["node_modules/@typescript-eslint/parser", "node_modules/@typescript-eslint/eslint-plugin", "node_modules/@typescript-eslint/type-utils"]:
pkg = pkgs.get(name)
if pkg:
print(name, "peerDependencies.typescript =", pkg.get("peerDependencies", {}).get("typescript"))
PY
printf '\nLockfile text around TypeScript package entry\n'
python3 - <<'PY'
from pathlib import Path
text = Path("package-lock.json").read_text()
needle = '"node_modules/typescript"'
idx = text.find(needle)
print(text[idx:idx+1200] if idx!=-1 else "not found")
PYRepository: openshift/lightspeed-console
Length of output: 2168
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the package.json TypeScript declaration and nearby lockfile state.
python3 - <<'PY'
import json
from pathlib import Path
pkg = json.loads(Path("package.json").read_text())
lock = json.loads(Path("package-lock.json").read_text())
for section in ("dependencies", "devDependencies", "optionalDependencies", "peerDependencies"):
if section in pkg and "typescript" in pkg[section]:
print("package.json", section, pkg[section]["typescript"])
root = lock.get("packages", {}).get("", {})
print("package-lock.json root devDependencies.typescript =", root.get("devDependencies", {}).get("typescript"))
ts = lock.get("packages", {}).get("node_modules/typescript", {})
print("package-lock.json node_modules/typescript.version =", ts.get("version"))
print("package-lock.json node_modules/typescript.resolved =", ts.get("resolved"))
for name in [
"node_modules/@typescript-eslint/parser",
"node_modules/@typescript-eslint/eslint-plugin",
"node_modules/@typescript-eslint/type-utils",
]:
pkg = lock.get("packages", {}).get(name)
if pkg:
print(name, "peerDependencies.typescript =", pkg.get("peerDependencies", {}).get("typescript"))
PYRepository: openshift/lightspeed-console
Length of output: 691
Don’t bump TypeScript to 7 yet
@typescript-eslint/* in the lockfile only supports typescript <6.1.0, and package-lock.json still resolves typescript to 5.9.3. Keep this on a compatible version, or upgrade the lint toolchain and regenerate the lockfile together.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@package.json` at line 50, Revert the TypeScript version in package.json from
7.x to a version compatible with the existing `@typescript-eslint` packages and
package-lock resolution, or upgrade the entire lint toolchain together and
regenerate the lockfile; keep package.json and package-lock.json consistent.
|
Don't want to upgrade to TypeScript 7 yet |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
1 participant
This PR contains the following updates:
^5.9.3→^7.0.0Release Notes
microsoft/TypeScript (typescript)
v7.0.2Compare Source
v6.0.3: TypeScript 6.0.3Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
v6.0.2: TypeScript 6.0Compare Source
For release notes, check out the release announcement blog post.
Downloads are available on:
Configuration
📅 Schedule: (in timezone UTC)
* * * * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.