OTA-1870: enable built-in MCP sidecar for cluster-updates tests#3004
OTA-1870: enable built-in MCP sidecar for cluster-updates tests#3004fao89 wants to merge 1 commit into
Conversation
Use operator introspection instead of explicit mcpServers config so the operator deploys the built-in MCP sidecar. Add RBAC for the sidecar to access cluster resources, and strip the RAG reference_content that the CI image lacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
openshift-ci-robot
added
the
jira/valid-reference
|
@fao89: This pull request references OTA-1870 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughCluster-updates test configuration now enables introspection, removes MCP and reference-content settings, and applies the RBAC required by the evaluation suite. ChangesCluster-updates test flow
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/e2e/utils/ols_installer.py (1)
144-146: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove the new rationale out of inline comments.
The behavior is correct, but these added comments conflict with the guidance to avoid comments in code. Move the rationale into the existing Google-style docstring or use a descriptively named helper so the code remains self-documenting.
As per coding guidelines: avoid comments in code unless explicitly requested; prefer self-documenting Python.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/e2e/utils/ols_installer.py` around lines 144 - 146, Remove the new inline rationale comments near the cluster_updates setup and move that explanation into the existing Google-style docstring, or encode it through a descriptively named helper. Preserve the behavior that strips the auto-generated reference_content for cluster_updates tests.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/e2e/utils/ols_installer.py`:
- Around line 144-146: Remove the new inline rationale comments near the
cluster_updates setup and move that explanation into the existing Google-style
docstring, or encode it through a descriptively named helper. Preserve the
behavior that strips the auto-generated reference_content for cluster_updates
tests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3b968e3e-9a69-48ac-ba8a-68fca53a048f
📒 Files selected for processing (3)
tests/config/operator_install/olsconfig.crd.openai_cluster_updates.yamltests/e2e/utils/ols_installer.pytests/scripts/test-cluster-updates.sh
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @JoaoFula |
|
@fao89: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/override "Red Hat Konflux / lightspeed-service-on-pull-request" |
|
@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / lightspeed-service-on-pull-request, Red Hat Konflux / ols-enterprise-contract / lightspeed-service DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
Use operator introspection instead of explicit mcpServers config so the operator deploys the built-in MCP sidecar. Add RBAC for the sidecar to access cluster resources, and strip the RAG reference_content that the CI image lacks.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Signed-off-by: Fabricio Aguiar fabricio.aguiar@gmail.com
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Ref: openshift/release#81342 (comment)
Summary by CodeRabbit
New Features
Bug Fixes