MGMT-24835: configuring the auto mode for assisted-installer-agent#82085
Draft
andrej1991 wants to merge 1 commit into
Draft
MGMT-24835: configuring the auto mode for assisted-installer-agent#82085andrej1991 wants to merge 1 commit into
andrej1991 wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@andrej1991: This pull request references MGMT-24835 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
WalkthroughAssisted Installer CI configurations now use ChangesAssisted Installer CI gating
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrej1991 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
andrej1991
force-pushed
the
auto-mode-assisted-installer-agent
branch
from
July 17, 2026 14:47
de1ec13 to
4990e57
Compare
This was referenced Jul 17, 2026
First only the cheap jobs like lint, unit-test will run. If they succeed and the reviewer gives lgtm then all the required jobs will be started.
andrej1991
force-pushed
the
auto-mode-assisted-installer-agent
branch
from
July 20, 2026 12:47
4990e57 to
1a90792
Compare
Contributor
|
[REHEARSALNOTIFIER]
A total of 42 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml`:
- Line 96: Escape the dot in the .tekton path within every affected
pipeline_skip_if_only_changed filter: update both entries in
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml
(lines 96-96 and 104-104), both entries in v2.47.yaml (lines 96-96 and 104-104),
and both entries in v2.52.yaml (lines 96-96 and 104-104) from .tekton/.* to
\.tekton/.*.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0ed5e7f6-cf36-48d0-bcc8-eed13e783bf0
📒 Files selected for processing (22)
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-assisted-version-placeholder.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-master.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-master__edge.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.11.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.12.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.13.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.14.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.15.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.16.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.17.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.42.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.43.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.46.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.47.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.48.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.49.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.50.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.51.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.52.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.53.yamlci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.54.yaml
🚧 Files skipped from review as they are similar to previous changes (16)
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-master__edge.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.12.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.48.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.42.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.11.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.46.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.49.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.51.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.54.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.53.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.17.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-master.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.15.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.50.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-release-ocm-2.14.yaml
- ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.43.yaml
| capabilities: | ||
| - intranet | ||
| skip_if_only_changed: ^\.github/|\.md$|^(?:.*/)?(?:\.gitignore|.tekton/.*|OWNERS|OWNERS_ALIASES|LICENSE)$ | ||
| pipeline_skip_if_only_changed: ^\.github/|\.md$|^(?:.*/)?(?:\.gitignore|.tekton/.*|OWNERS|OWNERS_ALIASES|LICENSE)$ |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Escape .tekton in all affected skip filters.
The unescaped dot is a wildcard and can skip jobs for unrelated paths such as xtekton/.... Replace .tekton/.* with \.tekton/.* at every listed site.
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml#L96-L96: escape.tekton.ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml#L104-L104: escape.tekton.ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.47.yaml#L96-L96: escape.tekton.ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.47.yaml#L104-L104: escape.tekton.ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.52.yaml#L96-L96: escape.tekton.ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.52.yaml#L104-L104: escape.tekton.
📍 Affects 3 files
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml#L96-L96(this comment)ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml#L104-L104ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.47.yaml#L96-L96ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.47.yaml#L104-L104ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.52.yaml#L96-L96ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.52.yaml#L104-L104
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml`
at line 96, Escape the dot in the .tekton path within every affected
pipeline_skip_if_only_changed filter: update both entries in
ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.45.yaml
(lines 96-96 and 104-104), both entries in v2.47.yaml (lines 96-96 and 104-104),
and both entries in v2.52.yaml (lines 96-96 and 104-104) from .tekton/.* to
\.tekton/.*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First only the cheap jobs like lint, unit-test will run. If they succeed all the required jobs will be started.
Summary by CodeRabbit
assisted-installer-agentCI by marking selected jobs as non-always-running and migrating change-based skip rules topipeline_skip_if_only_changed.5.0.0.