don't try to remove a Matrix's only row (or only column)#1436
Open
Alex-Jordan wants to merge 1 commit into
Open
don't try to remove a Matrix's only row (or only column)#1436Alex-Jordan wants to merge 1 commit into
Alex-Jordan wants to merge 1 commit into
Conversation
Alex-Jordan
force-pushed
the
dont-remove-only-row
branch
from
9a07382 to
e975885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR, you can try to remove the only row of
[[1,2,3]], or the only column of[[1],[2],[3]]. It won't work, but the error message will be a bit cryptic, coming from thesubMatrixmethod. It will say "Cannot use empty array reference for indices to keep".This commit changes it so that
removeRowandremoveColumncatch that kind of thing earlier and give a direct message about it.