Make sure foil randomization cannot be correct.#1438
Open
somiaj wants to merge 2 commits into
Open
Conversation
It is possible that one of the foils produces the correct answer. This will randomize values in a loop until the foil is guaranteed to not give the correct answer.
The same statement was included twice in a draggable proof problem, this was because the extra statements should have used the statement from the incorrect randomization not the correct randomization.
Contributor
Author
|
@oscarlevin I think these are your problems, so hoping you can double check I fixed them properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible that one of the foils produces the correct answer. This will randomize values in a loop until the foil is guaranteed to not give the correct answer.
A second issue was brought to my attention. One of the draggable proof problems had the same statement listed twice. This was because the wrong variable was being used for the extra statement. I believe the problem should have used the incorrect statement for the extra incorrect statements.