fix: add service annotations support to metaflow-ui services#98
Open
bafulton wants to merge 1 commit into
Open
fix: add service annotations support to metaflow-ui services#98bafulton wants to merge 1 commit into
metaflow-ui services#98bafulton wants to merge 1 commit into
Conversation
The `metaflow-service` subchart already supports `service.annotations`,
but the `metaflow-ui` subchart does not. This makes it impossible to set
per-service annotations like ALB healthcheck paths when deploying with
the AWS Load Balancer Controller.
Add `{{- with .Values.uiBackend.service.annotations }}` and
`{{- with .Values.uiStatic.service.annotations }}` blocks to the
backend and static service templates, matching the existing pattern
in `metaflow-service/templates/service.yaml`.
Author
|
@josephsirak or @nschmeller, any chance you could take a look? Sorry, I'm not sure who to ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
metaflow-servicesubchart already supportsservice.annotations(service.yaml:7-10), but themetaflow-uisubchart does not. This makes it impossible to set per-service annotations on the UI backend and static frontend services.This is needed for deployments using the AWS Load Balancer Controller, where per-service
alb.ingress.kubernetes.io/healthcheck-pathannotations are required to configure different healthcheck paths per target group (the backend responds on/api/ping, the static frontend on/). Without service-level annotation support, the only workaround is vendoring the chart or creating duplicate Service resources.This PR adds
{{- with .Values.uiBackend.service.annotations }}and{{- with .Values.uiStatic.service.annotations }}blocks tobackend_service.yamlandstatic_service.yaml, following the exact pattern already used inmetaflow-service.Example usage:
Backward compatible — no annotations are rendered when none are configured.