Add operator APIs for assigning IP Pools to Oxide#10557
Open
bnaecker wants to merge 1 commit into
Open
Conversation
bnaecker
force-pushed
the
ben/add-operator-ip-pool-apis
branch
2 times, most recently
from
64ad540 to
a1a9a18
Compare
- Update the `IpPool` type with an "assignment" field, which represents the resources the pool is assigned to service, either "silos" or "system services" today. - Deprecated the `ip-pools-service` endpoints, and add filtering to the existing `/v1/system/ip-pools` endpoints. Operators can now control all the IP Pools, even those reserved for Oxide's services, through these. - Remove checks for IP pools being "internal", since they're all the operator's pools. - Update the methods and types for returning the service pools, of which there is now a dynamic number > 1. - Fix all the integration tests for new endpoint structure - Closes #8947 - Closes #9147
bnaecker
force-pushed
the
ben/add-operator-ip-pool-apis
branch
from
a1a9a18 to
5f373f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IpPooltype with an "assignment" field, which represents the resources the pool is assigned to service, either "silos" or "system services" today.ip-pools-serviceendpoints, and add filtering to the existing/v1/system/ip-poolsendpoints. Operators can now control all the IP Pools, even those reserved for Oxide's services, through these.