fix create-app script#135
Merged
Merged
Conversation
Update the test-create-app script to include error handling and output checks. Rename .github/script/test-create-app.sh to scripts/test-create-app.sh Add test step for create-app in CI workflow Fix script to use local ember-tui path Update test script for create-app workflow Update GITHUB_RAW_BASE URL to main branch Add content-tag to development dependencies installation Update dependency installation command in create-app.js Fix create-app test: download babel.config.mjs and add missing dependencies - Download babel.config.mjs from ember-tui-demo to fix babel configuration - Add @babel/plugin-proposal-decorators to dependencies list - Add ember-native-devtools to dependencies list - Update test script to use node instead of npx and improve process handling Fix test-create-app.sh script - Changed test approach from running the app to verifying structure - The app hangs when started (no TTY in CI), so we verify: - App structure is created correctly - Template contains expected content - Build completes successfully - Added missing basic-test.gts file for future test downloads Delete ember-tui-demo/tests/basic-test.gts Update test file download to example-test.gts Simplify app creation script by removing checks Removed structure verification tests for app creation. Increase sleep duration before killing APP_PID fix: mark node built-in modules as external in vite config This prevents Vite from trying to bundle node:fs and other node built-in modules, which was causing the 'Failed to load url node:fs' error in the create-app test. Update GITHUB_RAW_BASE URL for create-app.js Clean up and install dependencies in test script Remove unnecessary files and install dependencies for the app. Fix script to create app and install dependencies Add Babel syntax plugin for TypeScript support pass from app fix lint fix fix run test run test Fix test-create-app script to use packed .tgz instead of linking - Build ember-tui before creating test app - Pack ember-tui as .tgz file - Install from packed .tgz instead of using pnpm install with directory - This approach works better in CI environments Revert glimmerRuntime parameter from setup function - Remove glimmerRuntime parameter from setup() function - Move SimpleDynamicAttribute patching back to module level in setup.ts - Remove glimmerRuntime import and parameter usage from app.ts and globalSetup.js - Restore original setup() function signature without parameters Add log file from test run Delete ember-tui-demo/log.txt Update test script to use loader.mjs like start script Remove NODE_OPTIONS from test script update
patricklx
force-pushed
the
create-test-for-create-app
branch
from
9c62e5e to
f2de279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the test-create-app script to include error handling and output checks.
fixes #134