fix: expand chat completion capability validation (#64 follow-up)#65
Open
Abhishek21g wants to merge 2 commits into
Open
fix: expand chat completion capability validation (#64 follow-up)#65Abhishek21g wants to merge 2 commits into
Abhishek21g wants to merge 2 commits into
Conversation
Add model capability matrix, raise clear error for sonar + return_images=True, and parse images on StreamChunk responses.
Validate reasoning_effort, search_context_size, and search_domain_filter limits per model before requests are sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the model capability matrix introduced in #64 to validate additional chat completion parameters before the HTTP request is sent:
reasoning_effort— allowed onsonar-deep-research,sonar-reasoning-prosearch_context_size— allowed onsonar-pro,sonar-reasoning-pro(including viaweb_search_options)search_domain_filter— max 3 domainsProblem
Integrators hit silent API failures or confusing responses when passing parameters unsupported by their selected model (public report: perplexity-py#61, community api-discussion threads on model-specific search params).
Fix
validate_chat_completion_params()centralizes preflight checkschat.completions.createcall it before_postVerification
Builds on #64 — can land independently or stack after merge.