fix(models): fall back to robot_descriptions' new naming, hide wrapped dependency on failure#529
Merged
Merged
Conversation
…apped dependency on failure
_load_urdf_from_RD() only tried "{name}_description", which robot_descriptions
has been migrating away from for some models (e.g. ur5_description ->
ur5_official_description) — surfaced as CI failures for panda, pr2, yumi,
ur10/ur3/ur5, and j2n6s200 once CI's fresh install picked up a version where
the old names no longer resolve, while a locally-cached older version still
worked (with only a deprecation warning).
Now tries the current name first, falls back to "{name}_official_description",
and suppresses the FutureWarning either way — it names "robot_descriptions"
directly, an implementation detail callers of roboticstoolbox never opted
into knowing about. The final error message on total failure is likewise
rephrased to not name the wrapped dependency.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
TEMPORARY, for CI validation only — revert before merging. See refactor/c-extensions@6dcfc624 for the same change and rationale. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2 tasks
This reverts commit a68f17e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_urdf_from_RD()inURDFRobot.pyonly triedrobot_descriptions.{name}_description. robot_descriptions has been migrating some models to new names (e.g.ur5_description->ur5_official_description); once CI installed a version where an old name no longer resolves, this surfaced asValueError: Robot model 'X' not found in robot_descriptionsfor panda, pr2, yumi, ur10/ur3/ur5, j2n6s200 — invisible locally where an older cached version still worked (with just aFutureWarning){name}_official_descriptionFutureWarning, which names "robot_descriptions" directly — an implementation detail users of roboticstoolbox never opted into seeingTest plan
pytest tests/test_models.py tests/test_BaseRobot.py tests/test_CustomXacro.py tests/test_Robot.py tests/test_IK.py -q— 162 passed, 1 skippedruff checkclean🤖 Generated with Claude Code