ci: validation hardening (test:all, svelte-check in CI, shared setup)#249
Merged
Conversation
- models/index.ts: import Theorem as a type (re-export doesn't bind locally) - deduction.ts: use a type guard so filter narrows (Theorem | null)[] -> Theorem[] - Related.svelte: extract matchesFilter helper so the full filterMode union type governs the switch (was narrowed to the 'known' literal) These were invisible because Vite's build does not type-check.
Single command for validating work: builds core + compile, runs lint:check, unit tests (core/compile/viewer), and svelte-check. Also ignore the peggy-generated Grammar.ts in Prettier (regenerated unformatted on build).
- Add a svelte-check (viewer validate) step to the unit-test workflow - Extract Node/pnpm/cache/install into .github/actions/setup, used by both the test and e2e workflows (resolves the 'share setup' TODO) - Standardize actions/cache to @v4 and unify the pnpm-store cache key
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
pi-base-topology | c63d7f8 | Commit Preview URL Branch Preview URL |
Jun 28 2026, 03:11 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tighten the validation feedback loop so type errors and CI drift get caught automatically. Notably,
svelte-checkwasn't run anywhere in CI, and Vite's build doesn't type-check — so 7 Svelte/TS type errors had accumulated undetected.What
pnpm test:all— one command to validate work: builds core + compile, runslint:check, unit tests (core/compile/viewer), andsvelte-check.svelte-checkerrors in the viewer.svelte-checkin CI (added to the unit-test workflow)..github/actions/setupcomposite action (Node + pnpm + store cache + install), used by bothtest.yamlande2e.yaml; resolves the long-standingTODO: share setupcomment.actions/cache@v3→@v4, unified pnpm-store cache key. Also ignore the peggy-generatedGrammar.tsin Prettier.Notes for reviewers
Related.svelte'sBoolean(...)wrappers are equivalent to the original truthy returns used by.filter.pnpm installslightly earlier relative to the Cypress cache restore; the explicitcypress installstep still runs after the cache is restored, so binary caching is unaffected.pnpm test:allandpnpm lint:checkare green. The CI/e2e workflow wiring is validated by inspection + Prettier.