Skip to content

fix(appstore): catalogue list uses DisplayName headline, not full Description (PILOT-405)#362

Open
matthew-pilot wants to merge 2 commits into
mainfrom
openclaw/pilot-405-20260708-164239
Open

fix(appstore): catalogue list uses DisplayName headline, not full Description (PILOT-405)#362
matthew-pilot wants to merge 2 commits into
mainfrom
openclaw/pilot-405-20260708-164239

Conversation

@matthew-pilot

Copy link
Copy Markdown
Collaborator

What

The pilotctl appstore catalogue list now prints the short headline (DisplayName) instead of the full Description for each app entry.

Why

The catalogue list is a quick-glance surface — the full Description is meant for pilotctl appstore view <id>. When a v2 catalogue entry has both display_name (short) and description (long prose), the list was incorrectly printing the long description, contradicting the intended UX.

Changes

  • Text-mode listing: use DisplayName when present, fall back to Description for v1 back-compat
  • --json output: unchanged (emits full catalogueEntry struct)
  • Added tests for DisplayName headline behaviour and v1 fallback

Verification

  • go build ./cmd/pilotctl/
  • go vet ./cmd/pilotctl/
  • go test -run 'TestCmdAppStoreCatalogue' ./cmd/pilotctl/ ✓ (all 6 tests pass)

2 files changed, 54 insertions(+), 1 deletion(-)

Closes PILOT-405

@matthew-pilot

Copy link
Copy Markdown
Collaborator Author

/openclaw merge

@matthew-pilot
matthew-pilot force-pushed the openclaw/pilot-405-20260708-164239 branch from 9a8181f to 554ddda Compare July 17, 2026 03:20
…cription (PILOT-405)

The catalogue list previously printed the full Description field for
every entry, which is designed to be multi-sentence prose (especially
in v2 catalogue entries where display_name is the short headline).
This contradicts the intended UX: list = quick glance, view = full
detail.

Change: the text-mode listing now prints DisplayName when present,
falling back to Description for v1 catalogue entries that lack the
newer field. The --json output is unchanged — it still emits the
entire catalogueEntry struct so downstream consumers are unaffected.

Added explicit tests for:
- DisplayName is used as headline when present (full Description NOT leaked)
- Fallback to Description when DisplayName is absent (v1 back-compat)

Closes PILOT-405
@matthew-pilot
matthew-pilot force-pushed the openclaw/pilot-405-20260708-164239 branch from 2f3a679 to 13ce42a Compare July 17, 2026 10:47
@matthew-pilot

Copy link
Copy Markdown
Collaborator Author

🛠️ Merge blocked by ruleset

All checks are green, the PR is approved, and I have /openclaw merge authorization. However, the "Protected branches" ruleset blocks non-admin bot merges (current_user_can_bypass: "never").

@TeoSlayer — this needs a manual merge or adding matthew-pilot to the ruleset bypass actors.

Merge state
  • ✅ Approved (TeoSlayer)
  • ✅ All checks green
  • ✅ Branch up to date with main
  • mergeStateStatus: BLOCKED — ruleset prevents bot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants