Skip to content

fix(js): prevent refreshContainer crash when fields dropdown values mix scalar and array inputs#1206

Open
Mary-Clb wants to merge 2 commits into
mainfrom
fix-fields-refreshContainer-crash
Open

fix(js): prevent refreshContainer crash when fields dropdown values mix scalar and array inputs#1206
Mary-Clb wants to merge 2 commits into
mainfrom
fix-fields-refreshContainer-crash

Conversation

@Mary-Clb
Copy link
Copy Markdown

@Mary-Clb Mary-Clb commented Jun 5, 2026

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !44474
  • This PR fixes a JavaScript crash in the Fields plugin when refreshContainer() serializes a form containing both a scalar field name and an array field name for the same base key. This was causing the dropdown to stay open even after selecting a new value.
Capture d’écran du 2026-06-04 16-08-32 Capture d’écran du 2026-06-05 09-10-27

@Mary-Clb Mary-Clb self-assigned this Jun 5, 2026
@Mary-Clb Mary-Clb added the bug label Jun 5, 2026
@Mary-Clb Mary-Clb requested review from Rom1-B and stonebuzz June 5, 2026 07:16
@stonebuzz
Copy link
Copy Markdown
Contributor

CAn you validate with customers ? and fix CS

@Rom1-B
Copy link
Copy Markdown
Contributor

Rom1-B commented Jun 5, 2026

Fix the CI in a separate PR (the uninstallation step is incomplete)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants