feat(parser): support phase 8 podcast follow#3
Open
nathangathright wants to merge 1 commit into
Open
Conversation
Add parsing for the pending/recommended Phase 8 <podcast:follow> tag at channel level. The tag points to a JSON document containing follow links for a podcast. Regression test feeds: phase-8 tests splice PRX/Dovetail's deployed example <podcast:follow url="https://f.prxu.org/72/subscribelinks.json"/> and Podnews's deployed example <podcast:follow url="https://podnews.net/podcast/i8xe9/follow.json"/> into the sample feed. Tests also cover missing, empty, whitespace-only, and duplicate tag cases. Spec context: Podcast Namespace discussion #671 lists NathanG's follow tag for Phase 8, and discussion #609 is labeled recommended/phase8. Verified with: npm test -- --runTestsByPath src/parser/phase/__test__/phase-8.test.ts --runInBand; npm run lint:typecheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
podcast:followtag.feed.podcastFollow.url.followonly when a validurlattribute is present.Verification
npm test -- src/parser/phase/__test__/phase-8.test.tshttps://podnews.net/rssparsedhttps://podnews.net/podcast/i8xe9/follow.jsonhttp://feeds.radiotopia.fm/radiotopia-showcaseparsedhttps://f.prxu.org/72/subscribelinks.json