Add polymath-ros linter which adds a check for executor threads#10
Merged
Conversation
added 7 commits
June 16, 2026 11:18
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
skyegalaxy
force-pushed
the
skyegalaxy/add-ros-linter
branch
from
a8ee69e to
9b34e81
Compare
emersonknapp
approved these changes
Jun 16, 2026
emersonknapp
left a comment
emersonknapp
left a comment
Member
There was a problem hiding this comment.
A little concerned about the ability of this check to generalize to different code formatting, but that doesn't have to block us from getting it in, since it's an opt-in check. We can iterate forward.
One comment on package structure that I'd prefer before merging
Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new check,
polymath-rosunder which opinionated ROS linting can be added. The first one in this category checks that all instances of Multi-Threaded (or Callback Group) executors specifythread_numin their constructor.The rules allow for passing 0 explicitly (which defaults to std::hardware_concurrency), because we want it to be an explicit choice on the part of the user instead of a consequence of default construction.