feat: add getEnclosing to @portabletext/editor/traversal#2709
Open
christianhg wants to merge 2 commits into
Open
feat: add getEnclosing to @portabletext/editor/traversal#2709christianhg wants to merge 2 commits into
getEnclosing to @portabletext/editor/traversal#2709christianhg wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 70745d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 767.0 KB | +179 B, +0.0% |
| Internal (gzip) | 147.2 KB | +37 B, +0.0% |
| Bundled (raw) | 1.37 MB | +163 B, +0.0% |
| Bundled (gzip) | 308.1 KB | +29 B, +0.0% |
| Import time | 96ms | -1ms, -0.9% |
@portabletext/editor/behaviors
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 2ms | -0ms, -1.1% |
@portabletext/editor/plugins
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 894 B | - |
| Bundled (raw) | 2.5 KB | - |
| Bundled (gzip) | 827 B | - |
| Import time | 7ms | -0ms, -0.3% |
@portabletext/editor/selectors
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 80.0 KB | +179 B, +0.2% |
| Internal (gzip) | 14.6 KB | +21 B, +0.1% |
| Bundled (raw) | 76.0 KB | +163 B, +0.2% |
| Bundled (gzip) | 13.6 KB | +13 B, +0.1% |
| Import time | 8ms | -0ms, -0.4% |
@portabletext/editor/traversal
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 20.1 KB | +209 B, +1.0% |
| Internal (gzip) | 4.0 KB | +19 B, +0.5% |
| Bundled (raw) | 20.5 KB | +177 B, +0.8% |
| Bundled (gzip) | 4.0 KB | +21 B, +0.5% |
| Import time | 6ms | -0ms, -0.6% |
@portabletext/editor/utils
| Metric | Value | vs main (e0e974e) |
|---|---|---|
| Internal (raw) | 30.0 KB | - |
| Internal (gzip) | 6.1 KB | - |
| Bundled (raw) | 27.9 KB | - |
| Bundled (gzip) | 5.7 KB | - |
| Import time | 6ms | -0ms, -1.0% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./traversal · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic
getEnclosing(snapshot, path, predicate)to the traversal API. Returns the node atpathif it matches the predicate, otherwise walks up ancestors until one matches.When
predicateis a type predicate, the returnednodenarrows accordingly.getEnclosingBlockis now a thin wrapper overgetEnclosing. All existinggetEnclosingBlockcallers and tests are unchanged.The generic version unblocks consumer behaviors that need "find the nearest X in scope" without writing a manual self-then-ancestor walk.