Remove Compiled* schema objects#73
Open
LucDeCaf wants to merge 4 commits into
Open
Conversation
LucDeCaf
commented
Jun 12, 2026
| InsertOnly = false, | ||
| ViewName = "test_assets_viewname", | ||
| TrackMetadata = true, | ||
| TrackMetadata = false, |
Contributor
Author
There was a problem hiding this comment.
Part of an existing bug in the test suite; since CompiledTable.Options was private it wasn't being checked properly for incorrect values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CompiledSchemaandCompiledTableclasses made the schema API unnecessarily complicated, made testing more difficult, and will make adding raw tables in the future more annoying. This PR removes the Compiled* classes in favour of working with the Table and Schema classes directly. Validation logic has been moved into the classes themselves and a JsonConverter has been created for both classes.AI Usage
Claude Code was used to generate the JsonConverter implementations for both classes. It was also used to generate a test for an existing issue with column name parsing which I spotted while reviewing its implementation.