fix(waitlist): reject invalid JSON requests#46
Open
SabFabDev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
400for malformed JSON instead of falling through to the generic500handlerThis is the bounded ThreatCrush bugfix delivered under the accepted uGig scope (application
4e650370-bc54-46e1-986b-25a0053fc310).Verification
pnpm --filter @profullstack/threatcrush-web exec vitest run src/app/api/waitlist/__tests__/route.test.ts— 1 file passed, 11 tests passedpnpm --filter @profullstack/threatcrush-web build— passed (compiled, TypeScript checked, 61 static pages generated)pnpm --filter @profullstack/threatcrush-web test— 33 files passed / 2 failed; 231 tests passed / 1 failed (plus one failed suite with 0 tests). The failures are unrelated existing usage/topup test issues: a stale expected error message and a hoisted mock initialization error.Scope
Minimal API error-handling change plus focused regression tests; no schema or UI changes.