Bump CEL-Spec from 0.15.0 to 0.25.2#939
Merged
Merged
Conversation
This change adds the necessary base work for the CEL-Spec bump. Follow-up PRs will make the code-base fully aligned with the new spec version. The previously used conformance-tests approach to use Google's "simple conformance test runner" no longer works, because that simple-runner has been removed. This change keeps the gRPC client/server architecture for conformance tests. A follow-up PR will remove the gRPC bridge entirely.
XN137
previously approved these changes
Jul 24, 2026
| arguments.skipCheck, | ||
| arguments.skipTests); | ||
| int result = runner.run(arguments.testFiles); | ||
| System.exit(result); |
Contributor
There was a problem hiding this comment.
if we exit here, does the finally run? do we care that things can shutdown orderly?
Member
Author
There was a problem hiding this comment.
Hah! Yea, I suspect nothing will be "properly" shutdown - but likely no issue, because the process is gone (nothing to shut down) and this will change anyway ;)
| private static Map<String, ExprValue> convertBindings( | ||
| Map<String, dev.cel.expr.ExprValue> bindings) { | ||
| try { | ||
| java.util.LinkedHashMap<String, ExprValue> converted = new java.util.LinkedHashMap<>(); |
XN137
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the necessary base work for the CEL-Spec bump.
Follow-up PRs will make the code-base fully aligned with the new spec version.
The previously used conformance-tests approach to use Google's "simple conformance test runner" no longer works, because that simple-runner has been removed. This change keeps the gRPC client/server architecture for conformance tests. A follow-up PR will remove the gRPC bridge entirely.