Add editorconfig CRLF default and renormalize workflow YAML#119
Merged
Conversation
Set end_of_line = crlf on the [*] block so every file type has a defined ending, matching the fleet template. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Five workflow YAML files were committed LF, violating the .editorconfig [*.{yml,yaml}] crlf rule (git .gitattributes * -text does not renormalize). Convert them to CRLF; EOL-only change, no content difference (verified with git diff --ignore-cr-at-eol).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns repository line-ending governance with the ProjectTemplate audit by setting a global CRLF default in .editorconfig and renormalizing selected GitHub Actions workflow YAML files to CRLF, matching the repo’s existing YAML rule.
Changes:
- Add
end_of_line = crlfto the.editorconfig[*]defaults block (while preserving existing LF overrides for*.shandDockerfilepatterns). - Renormalize 5 workflow
.ymlfiles to CRLF (EOL-only; no functional workflow logic changes).
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .editorconfig | Sets CRLF as the global default line ending (existing per-pattern overrides remain in effect). |
| .github/workflows/validate-task.yml | Renormalize workflow file line endings to CRLF. |
| .github/workflows/test-pull-request.yml | Renormalize workflow file line endings to CRLF. |
| .github/workflows/publish-release.yml | Renormalize workflow file line endings to CRLF. |
| .github/workflows/build-release-task.yml | Renormalize workflow file line endings to CRLF. |
| .github/workflows/build-docker-task.yml | Renormalize workflow file line endings to CRLF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two EOL fixes from the ProjectTemplate audit (
reports/esphome-nonroot/audit.md), via the convergence pattern (AUDIT.mdsection 10):end_of_line = crlfto the.editorconfig[*]block (global default)..editorconfig [*.{yml,yaml}] crlfrule (.gitattributes * -textdoes not renormalize). EOL-only change, no content difference (verified withgit diff --ignore-cr-at-eol).🤖 Generated with Claude Code