Conversation
Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com>
Co-authored-by: ptr727-codegen[bot] <275599072+ptr727-codegen[bot]@users.noreply.github.com>
* Add the global editorconfig CRLF default
Set end_of_line = crlf on the [*] block so every file type has a defined ending, matching the fleet template.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
* Renormalize workflow YAML to CRLF per .editorconfig
Five workflow YAML files were committed LF, violating the .editorconfig [*.{yml,yaml}] crlf rule (git .gitattributes * -text does not renormalize). Convert them to CRLF; EOL-only change, no content difference (verified with git diff --ignore-cr-at-eol).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
---------
Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Promotes develop to main by carrying forward the queued upstream device_builder pin updates and applying line-ending normalization consistent with the repository's .editorconfig/.gitattributes policy.
Changes:
- Bump
device_builderinupstream-version.jsonfrom1.0.27to1.0.29. - Set the default
.editorconfigend_of_linetocrlf, while retaining existinglfoverrides for*.shand Dockerfiles. - Normalize line endings in multiple workflow YAML files (no functional workflow logic changes observed).
Reviewed changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| upstream-version.json | Updates the pinned upstream device_builder version to 1.0.29. |
| .github/workflows/validate-task.yml | Line-ending normalization; workflow content remains the same. |
| .github/workflows/test-pull-request.yml | Line-ending normalization; workflow content remains the same. |
| .github/workflows/publish-release.yml | Line-ending normalization; workflow content remains the same. |
| .github/workflows/build-release-task.yml | Line-ending normalization; workflow content remains the same. |
| .github/workflows/build-docker-task.yml | Line-ending normalization; workflow content remains the same. |
| .editorconfig | Sets a CRLF default while preserving LF overrides for scripts and Dockerfiles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote develop to main: editorconfig EOL normalization plus the queued upstream device_builder version bumps (1.0.28, 1.0.29).