Remove data_version parameter from get_meteonorm_tmy#2781
Open
AdamRJensen wants to merge 3 commits into
Open
Conversation
Member
Author
|
The change is documented in the meteonorm changelog: https://docs.meteonorm.com/overview/changelog-api#2025-12-05 |
Member
|
We can deprecate this with a message "this parameter no longer has any effect (see XX meteonorm URL) and will be removed soon", right? Can we do that instead of jumping straight to removal? |
Member
Author
The issue is that the API requests are currently failing when the parameter is included. |
Member
|
Right. Can't we keep it as a parameter to the pvlib function (to avoid a breaking change), and just stop including it in the API request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The remote data tests are currently failing due to the
get_meteonorm_tmyfunction no longer supporting thedata_versionparameter.