Skip to content

Remove snakemake from comparison#994

Merged
jan-janssen merged 3 commits into
mainfrom
nosnake
May 29, 2026
Merged

Remove snakemake from comparison#994
jan-janssen merged 3 commits into
mainfrom
nosnake

Conversation

@jan-janssen
Copy link
Copy Markdown
Member

@jan-janssen jan-janssen commented May 29, 2026

Summary by CodeRabbit

  • Documentation
    • Updated comparison tables to better focus on key frameworks: executorlib, concurrent.futures, Dask, Parsl, and Ray
    • Clarified Parsl's support status for Drop-in Executor API to provide more accurate information
    • Streamlined documentation by removing Snakemake and simplifying the comparison structure for improved navigation

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@jan-janssen, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 5 minutes and 10 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0394de92-bd01-4e9c-bc3e-765c6067de37

📥 Commits

Reviewing files that changed from the base of the PR and between 30456db and b082981.

📒 Files selected for processing (2)
  • README.md
  • docs/comparison.md
📝 Walkthrough

Walkthrough

This PR removes Snakemake from executorlib's comparison documentation across README and docs/comparison.md. The Snakemake column is dropped from both comparison tables, and the dedicated Snakemake section is removed from the detailed documentation. Additionally, Parsl's "Drop-in Executor API" status is updated to ⚠️ in the detailed comparison.

Changes

Snakemake Removal from Documentation

Layer / File(s) Summary
Remove Snakemake from README
README.md
Snakemake column removed from the "Key Features" comparison table (lines 29–36) and the Snakemake link removed from the "Documentation → Comparison" section (lines 158–159).
Update comparison documentation and Parsl status
docs/comparison.md
Snakemake column removed from the "At a glance" table, Parsl's "Drop-in Executor API" status changed from ❌ to ⚠️ (lines 14–21), and the dedicated Snakemake section removed (lines 60–61).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Out with Snakemake, the comparison clears,
Now Parsl shows caution after all these years,
Tables update, links realign with grace,
Executorlib shines in its rightful place! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove snakemake from comparison' directly and clearly describes the main change: removing Snakemake from the comparison documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nosnake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.16%. Comparing base (36659dc) to head (b082981).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files          39       39           
  Lines        2090     2090           
=======================================
  Hits         1968     1968           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jan-janssen jan-janssen merged commit 6f2db93 into main May 29, 2026
36 checks passed
@jan-janssen jan-janssen deleted the nosnake branch May 29, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant