Skip to content

gh-150361: Add test for _FlowControlMixin pause_writing exception handling #150362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azibom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-150361: Add test for _FlowControlMixin pause_writing exception handling #150362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions Lib/test/test_asyncio/test_transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,29 @@ def get_write_buffer_size(self):
self.assertTrue(transport._protocol_paused)
self.assertEqual(transport.get_write_buffer_limits(), (128, 256))

def test_flowcontrol_mixin_pause_writing_exception(self):

class MyTransport(transports._FlowControlMixin,
transports.Transport):

def get_write_buffer_size(self):
return 2000

loop = mock.Mock()
transport = MyTransport(loop=loop)
protocol = mock.Mock()
protocol.pause_writing.side_effect = RuntimeError("boom")
transport._protocol = protocol
transport.set_write_buffer_limits(high=1000, low=100)
transport._maybe_pause_protocol()
protocol.pause_writing.assert_called_once()
loop.call_exception_handler.assert_called_once()
args = loop.call_exception_handler.call_args[0][0]

self.assertIn("protocol.pause_writing() failed", args["message"])
self.assertIsInstance(args["exception"], RuntimeError)
self.assertTrue(transport._protocol_paused)

def test_flowcontrol_mixin_compute_write_limits(self):

class MyTransport(transports._FlowControlMixin,
Expand Down
Loading