CI: declare workflow-level permissions: {}#1811
Merged
Merged
Conversation
Workflow runs checks only; no GitHub API writes. Post-CVE-2025-30066 hardening pattern. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
hugovk
reviewed
May 26, 2026
Comment on lines
+8
to
+9
| permissions: | ||
| contents: read |
Member
There was a problem hiding this comment.
Or even less:
Suggested change
| permissions: | |
| contents: read | |
| permissions: {} |
Comment on lines
+5
to
+6
| permissions: | ||
| contents: read |
Member
There was a problem hiding this comment.
Suggested change
| permissions: | |
| contents: read | |
| permissions: {} |
Per @hugovk on python#1811: drop `contents: read` to deny-all `permissions: {}`. Both workflows only run `actions/checkout` against a public repo (which falls back to unauthenticated clone with no token scope) plus python/uv/pre-commit setup, none of which call the GitHub API. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Contributor
Author
|
Done @hugovk - both files now use |
Documentation build overview
|
hugovk
changed the title
permissions: {}
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the default
GITHUB_TOKENtocontents: readat workflow level. No GitHub API writes from the workflow.Post-CVE-2025-30066 hardening pattern. YAML validated locally.