Skip to content

Remove unused minor_version_tuple() and ls_ssh() #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
May 26, 2026
Merged

Remove unused minor_version_tuple() and ls_ssh() #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f8804
Remove unused minor_version_tuple()
hugovk May 23, 2026
0b466e8
Remove unused ls_ssh()
hugovk May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,12 +208,6 @@ def minor_version(release: str) -> str:
return ".".join(m.groups()[:2])


def minor_version_tuple(release: str) -> tuple[int, int]:
m = tag_cre.match(release)
assert m is not None, f"Invalid release: {release}"
return int(m.groups()[0]), int(m.groups()[1])


def build_file_dict(
ftp_root: str,
release: str,
Expand Down
13 changes: 0 additions & 13 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,19 +116,6 @@ def test_minor_version(release: str, expected: str) -> None:
assert add_to_pydotorg.minor_version(release) == expected


@pytest.mark.parametrize(
["release", "expected"],
[
("3.9.0a0", (3, 9)),
("3.10.0b3", (3, 10)),
("3.11.0rc2", (3, 11)),
("3.12.15", (3, 12)),
],
)
def test_minor_version_tuple(release: str, expected: tuple[int, int]) -> None:
assert add_to_pydotorg.minor_version_tuple(release) == expected


@pytest.mark.parametrize(
["release", "expected"],
[
Expand Down
12 changes: 0 additions & 12 deletions windows-release/merge-and-upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,18 +113,6 @@ def download_ssh(source, dest):
_run(*_std_args(PSCP), f"{UPLOAD_USER}@{UPLOAD_HOST}:{source}", dest)


def ls_ssh(dest):
if not UPLOAD_HOST or LOCAL_INDEX:
print("Skipping ls of", dest, "because UPLOAD_HOST is missing")
return
try:
_run(*_std_args(PSCP), "-ls", f"{UPLOAD_USER}@{UPLOAD_HOST}:{dest}")
except RunError as ex:
if not ex.args[1].rstrip().endswith("No such file or directory"):
raise
print(dest, "was not found")


def url2path(url):
if not UPLOAD_URL_PREFIX:
raise ValueError("%UPLOAD_URL_PREFIX% was not set")
Expand Down
Loading