Prototype SciMLOperators-backed lazy operators#230
Conversation
797bcef to
c1f882a
Compare
|
Just a suggestion for benchmarking lazy tensor operators: Be sure to check sparse as well as dense tensor factors, a variety of site dimensions, and cases where the tensor operators act on non-edge sites (i.e. not 1 and n, for an n-site composite system). |
Thanks for the suggestion. I expanded the benchmark suite in 4196c61 to cover sparse and dense tensor factors, edge and non-edge tensor sites, and both spin-1/2 and spin-1 local site dimensions. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 90.76% 91.73% +0.96%
==========================================
Files 26 28 +2
Lines 3314 3459 +145
==========================================
+ Hits 3008 3173 +165
+ Misses 306 286 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The OpenCL job in Buildkite build 96 shows as passed with exit status 0, but the GitHub status for The aggregate Buildkite status is green, and the OpenCL log shows |
|
@amilsted Sorry to ping directly. The OpenCL GitHub status still appears stale, while Buildkite build 96 shows the OpenCL job passed with exit status 0. Would you be able to rerun or refresh the Buildkite status for this PR? |
b72b447 to
03f64df
Compare
03f64df to
6fb73a1
Compare
|
Small note on the force-pushes: I squashed the branch back to one focused commit, then force-pushed follow-ups to fix CI-only Buildkite downstream resolver issues exposed by the rerun. The current head is |
Summary
sciml_lazy_operatorandcache_sciml_lazy_operatorLazySum,LazyProduct, andLazyTensorwhile preservingbasis_landbasis_rmul!, scalar ops, arithmetic, mixed dense multiplication,dagger, andtransposeBenchmarks
Short local run on Julia 1.10.10 with SciMLOperators 1.22.0. Times are minimums from 8 samples with a 0.5s budget per benchmark, so they are directional PR data.
The cached SciML path is faster for tensor-heavy cases in this sample, especially
LazyTensorand the larger two-site tensor-product composition. Local sums and the mixed Hamiltonian are still slower or close to the current kernels, so the benchmark is evidence for where this path helps and where it does not.Tests
test_sciml_lazy_operators: 12 passedtest_aqua: 11 passed, 1 existing broken piracy checkgit diff --check: cleanRefs qojulia/QuantumOptics.jl#522
AI disclosure: I used GPT-5.5 Extra High/Codex interactively for implementation support. I reviewed the code, corrected issues found during local testing, and ran the checks above.