Skip to content

Test CI/CD checks#1479

Open
imrashai wants to merge 23 commits into
qualcomm-linux:tech/bsp/clkfrom
imrashai:test-ci-cd
Open

Test CI/CD checks#1479
imrashai wants to merge 23 commits into
qualcomm-linux:tech/bsp/clkfrom
imrashai:test-ci-cd

Conversation

@imrashai

@imrashai imrashai commented Jul 7, 2026

Copy link
Copy Markdown

This change is to test the CI/CD.

kona-jagadeesh and others added 22 commits July 2, 2026 17:02
Add device tree bindings for the camera clock controller on
Qualcomm Glymur SoC.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260402-glymur_camcc-v1-1-e8da05a21da7@oss.qualcomm.com
Add support for the camera clock controller for camera clients
to be able to request for camcc clocks on Glymur platform.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260402-glymur_camcc-v1-2-e8da05a21da7@oss.qualcomm.com
The GX GDSC is a special power domain that should only be disabled
by OS during GMU recovery. In all other scenarios, the GMU firmware
is responsible for handling its disable sequence, and OS must not
interfere.

During the resume_noirq() phase of system resume, the GenPD framework
enables all power domains and later disables them in the complete()
phase if there are no active votes from OS. This behavior can
incorrectly disable the GX GDSC while the GMU firmware is still using
it.

To prevent this, implement a custom disable callback for GX GDSC that
relies on GenPD’s synced_poweroff flag. The GMU driver sets this flag
only during recovery, allowing OS to explicitly disable GX GDSC in
hardware in that case. In all other situations, the disable callback
will avoid touching GX GDSC hardware.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260427-gfx-clk-fixes-v2-1-797e54b3d464@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
The GX GDSC represents a special GPU power domain that must not be
disabled during normal runtime PM flows. As per the GMU architecture,
GX GDSC should only be force-disabled during GMU/GPU recovery, where the
OS explicitly resets the GX power domain.

However, when managed by the generic GDSC runtime PM path, GX GDSC may be
disabled during GMU runtime suspend, resulting in warnings such as:

  gx_clkctl_gx_gdsc status stuck at 'on'

and failures in gdsc_toggle_logic() during rpm suspend.

Use the newly added custom disable callback for gx_gdsc to ensure the
GDSC is toggled only in recovery scenarios, while preventing unintended
disable attempts during normal GMU runtime PM operations.

Reported-by: Pengyu Luo <mitltlatltl@gmail.com>
Closes: https://lore.kernel.org/all/CAH2e8h4Vp9fJYAUUbOmoHSKB25wakPBvmpwa62BTRqgRQbMWuw@mail.gmail.com/
Reported-by: Alexander Koskovich <akoskovich@pm.me>
Closes: https://lore.kernel.org/all/gwVAH2mJerU4dBInw8pKmOs5aQK55Q7W6q_UQAlLFCsEgX6eyvSgXAWbNNMqAX4WmPlYCKUSMhfkr5Jry4Ps5EqnxYZqEEDd3Whwv7ZXGlc=@pm.me/
Fixes: 5af11ac ("clk: qcom: Add a driver for SM8750 GPU clocks")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260427-gfx-clk-fixes-v2-2-797e54b3d464@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…robe

When the clock controller is probed with 'use_rpm' enabled, the
runtime PM reference is currently released using pm_runtime_put(),
which may return before the runtime suspend has completed. When the
clock controller device is registered through this function, calling
pm_runtime_disable() immediately after pm_runtime_put() prevents
the runtime suspend from completing, leaving the clock controller
active and the HW rails in the ON state.

Use pm_runtime_put_sync() instead to ensure the runtime PM “putV
completes synchronously during probe. This does not have any functional
impact, but it guarantees that the device is fully runtime-suspended
before returning.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260427-gfx-clk-fixes-v2-3-797e54b3d464@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…h IFPC

The GX GDSC control is handled through a dedicated clock controller,
and the enable/disable sequencing depends on correct rail voting.
The driver votes for the GX/GMxC rails and CX GDSC before toggling
the GX GDSC. Currently, during GMU runtime PM resume, rails remain
enabled due to upstream votes propagated via RPM-enabled devlinks
and explicit pm_runtime votes on GX GDSC.

This is not an expected behaviour of IFPC(Inter Frame Power Collapse)
requirements of GPU as GMU firmware is expected to control these rails,
except during the GPU/GMU recovery via the OS and that is where the GX
GDSC should be voting for the rails (GX/GMxC and CX GDSC) before
toggling the GX GDSC.

Thus, disable runtime PM after successfully registering the clock
controller.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260427-gfx-clk-fixes-v2-4-797e54b3d464@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
The gcc_eva_ahb_clk and gcc_eva_xo_clk branch clocks should not be
registered as standalone GCC branch clocks. Drop these clocks from
the GCC clock list and instead add their CBCR registers to the GCC
critical clocks list to ensure they remain enabled during early boot.

Fixes: efe5043 ("clk: qcom: gcc: Add support for Global Clock Controller")
Link: https://lore.kernel.org/lkml/20260526-evacc_glymur-v1-1-b61c7755c403@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…r for Glymur SoC

Add the device tree bindings for the enhanced video analytics(EVA) clock
controller which is required on Qualcomm Glymur SoC. The controller
provides clocks, resets and power domains for the EVA subsystem.

Link: https://lore.kernel.org/lkml/20260526-evacc_glymur-v1-2-b61c7755c403@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Add the Enhanced Video Analytics (EVA) clock controller driver for
the Glymur SoC. The EVACC manages the PLL, RCGs, branch clocks, GDSCs
and resets for the EVA subsystem which handles vision processing
workloads.

Link: https://lore.kernel.org/lkml/20260526-evacc_glymur-v1-3-b61c7755c403@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…divider

Add device tree bindings for the Qualcomm Peripheral Web's PDM GP_MN
clock divider. The hardware generates a fractional output frequency
from a fixed input clock (typically TCXO4) using the relation
Fout = Fin * (M / N), with duty cycle controlled by a separate D
register. The clock output is routed over a gpio controlled pin.

Link: https://lore.kernel.org/r/20260602-pdm_clk_gp_mnd_v1-v1-1-1522662b6c53@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
The PDM (Pulse Density Modulation) hardware block on Qualcomm SoCs
contains a GP_MN clock divider that produces a fractional output
frequency from a fixed input clock (typically TCXO4):

  Fout = Fin * (M / N)

The hardware encodes the period in the NDIV register as the 1's
complement of (N - M), and controls the duty cycle via a separate
DUTY register that counts the number of low-phase native clock
cycles over the period N.

Add a standalone platform driver for this block that uses
rational_best_approximation() to find the closest M/N pair within
the 9-bit M and 13-bit N hardware limits, programs the MDIV, NDIV,
and DUTY registers via regmap, and implements the full clk_ops
surface including determine_rate, set_rate, recalc_rate,
get_duty_cycle, and set_duty_cycle. The PDM AHB bus clock is gated
around every register access.

Link: https://lore.kernel.org/r/20260602-pdm_clk_gp_mnd_v1-v1-2-1522662b6c53@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Qualcomm TSCSS is a time synchronization subsystem composed of two main
blocks: the Time Stamp Counter (TSC) and the Event Timestamp Unit (ETU).
The TSC block is a timestamp generator that maintains a running counter
used for system timekeeping. The ETU block captures timestamps for external
events using one of the available timestamp sources.

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Add support for the Qualcomm TSCSS hardware, that is a time synchronization
subsystem composed of two main blocks: the Time Stamp Counter (TSC) and the
Event Timestamp Unit (ETU).

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
…eroff flag is set

USB, PCIE GDSCs require the GDSC to left ON in USB host mode and PCIE
non-D3 cold usecases even during system suspend. To handle this use the
GenPD's synced_poweroff flag which can be set by USB/PCIE drivers if
they require the GDSC to be disabled before suspend. If the GDSC is
required to be left ON, the USB/PCIE drivers can avoid setting this
flag before suspend. Add support for custom gdsc disable callback that
disables GDSC based on GenPD's synced_poweroff flag.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <kriskura@qti.qualcomm.com>
…GDSC's

Use gdsc_synced_poweroff_disable callback for USB GDSC's on qcs615
platforms so these GDSC's get disabled only when consumer drivers
explicitly invoke dev_pm_genpd_synced_poweroff() API before suspend.

Signed-off-by: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>
Signed-off-by: Krishna Kurapati <kriskura@qti.qualcomm.com>
…mode bus suspend

On targets pre-sm8750, when DUT enters bus suspend in host mode, there is
a xHCI crash seen on resume. During bus susend use case if the device is
wakeup capable, the GDSC needs to be kept ON to retain memory and avoid
SMMU faults. Set synced_poweroff flag to false to ensure GDSC is turned
OFF during cable disconnect or non-bus suspend host mode scenario.

Signed-off-by: Krishna Kurapati <kriskura@qti.qualcomm.com>
…lcomm Eliza SoC

Eliza Video clock controller is on CX and MX rails similar to Milos.
Add compatible string for Eliza video clock controller to the existing
Milos videocc binding and add the dt-bindings header for Eliza.

The video clock controller exposes power domains, so '#power-domain-cells'
must be present in the device node. Add it to the required properties list
to enforce this in binding validation.

There is no ABI breakage and no impact to the existing devices, since the
nodes using this binding already specify the '#power-domain-cells' property
for videocc.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-1-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…roller

Add bindings documentation for the Eliza Graphics Clock Controller.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-2-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Eliza camera clock controller is on CX and MX rails similar to Milos.
Add compatible string for Eliza camera and camera BIST clock
controller to the existing Milos camcc binding and add the
dt-bindings header for Eliza.

The camera clock controller provides power domains, so 'power-domain-cells'
must be present in the device tree node. Add this to required properties
to enforce it in the binding schema.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-3-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…liza

Add support for the video clock controller for video clients to be able
to request for videocc clocks on Eliza platform.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-4-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
Add Graphics Clock Controller (GPUCC) support for Eliza platform.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-5-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
…or Eliza

Add support for the Camera Clock Controller (CAMCC) on the Eliza
platform.

The CAMCC block on Eliza includes both the primary camera clock
controller and the Camera BIST clock controller, which provides the
functional MCLK required for camera operations.

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260609-b4-eliza_mm_cc_v6-v6-6-17df09e5940c@oss.qualcomm.com
Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, Mike Tipton (mdtipton) and Taniya Das (taniyadas20) and removed request for a team July 7, 2026 08:34
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1479

PR: #1479
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28852861181

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict during automerge Multiple files (101 conflicts) No Pre-existing integration conflicts between topic branches

Verdict

This PR does not introduce any build errors. The build failure occurred during the automerge/integration phase where multiple topic branches are merged together. The PR file drivers/clk/qcom/common.c merged cleanly without conflicts. All 101 merge conflicts are in unrelated files and are pre-existing integration issues between other topic branches, not caused by this PR.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1479

PR: #1479
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28852861181

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict during automerge Multiple files (108 conflicts) No Pre-existing conflicts in integration branch

Verdict

No compilation errors occurred. The build failed during the automerge phase due to 108 merge conflicts across multiple files. The PR changes to drivers/clk/qcom/common.c were successfully auto-merged and are not responsible for the failure.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1479 — validate-patch

PR: #1479

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link
  4. PR present in qcom-next: Not checked — validation cannot proceed without lore link
Verdict: ❌ — click to expand

Patch Validation Report

PR: clk: qcom: common: Register reset controller only when resets are present (#1479)
Upstream: (none found)
Verdict: ❌ FAIL

Reason

No lore.kernel.org link was found in the PR description or commit message(s).
This skill only validates patches against a lore.kernel.org source.

Recommendation

Add a Link: https://lore.kernel.org/r/<message-id> line to the commit message and re-run validation, or use an appropriate prefix:

  • UPSTREAM: → link to the merged kernel.org commit (not applicable here)
  • FROMLIST: → link to the lore.kernel.org posting
  • BACKPORT: → link to the original lore.kernel.org or upstream commit
  • QCLINUX: → vendor-only change, no upstream link expected
  • PENDING: → work-in-progress, not yet posted upstream
  • WORKAROUND: → temporary fix, not suitable for upstream

Commits with QCLINUX:, PENDING:, or WORKAROUND: prefixes have no upstream lore link by design and cannot be validated with this skill.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link
  4. PR present in qcom-next: Not checked — validation cannot proceed without lore link

Additional Notes

The patch modifies drivers/clk/qcom/common.c to conditionally register the reset controller only when desc->num_resets is non-zero. This appears to be a reasonable fix for clock controllers that don't provide reset lines, but without a lore link or vendor prefix, it's unclear whether this is:

  • An upstream patch that should have a FROMLIST: or UPSTREAM: prefix with a lore link
  • A vendor-specific change that should have a QCLINUX: prefix
  • A work-in-progress that should have a PENDING: prefix

The commit author (imran.shaik@oss.qualcomm.com) and the nature of the change suggest this may be intended for upstream submission. If so, it should either:

  1. Be posted to the linux-clk mailing list first, then prefixed with FROMLIST: and include the lore link
  2. If already posted, add the appropriate prefix and lore link to the commit message

@qlijarvis

Copy link
Copy Markdown

PR #1479 — checker-log-analyzer

PR: #1479
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28852861459

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Cannot execute - CI failed before PR merge

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1479 - clk: qcom: common: Register reset controller only when resets are present
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28852861459

Checker Result Summary
checkpatch ⏭️ CI infrastructure failure - no checker execution
dt-binding-check ⏭️ CI infrastructure failure - no checker execution
dtb-check ⏭️ CI infrastructure failure - no checker execution
sparse-check ⏭️ CI infrastructure failure - no checker execution
check-uapi-headers ⏭️ CI infrastructure failure - no checker execution
check-patch-compliance ⏭️ CI infrastructure failure - no checker execution
tag-check N/A Cannot execute - CI failed before PR merge

❌ CI Infrastructure Failure

Root cause: The kernel-checkers CI workflow failed during the integration branch setup phase with fatal: refusing to merge unrelated histories when attempting to merge the topic branch topic/tech/bsp/clk into the baseline.

Failure details:

2026-07-07T08:51:32.2347744Z Create a new integration branch based on 19b282f417584cfe14ce6a262122c51553d026ec
2026-07-07T08:51:32.3957460Z Switched to a new branch 'integ'
2026-07-07T08:51:32.4024195Z Merging topic branches...
2026-07-07T08:51:32.4253625Z ------------------------------------------
2026-07-07T08:51:32.4254118Z  ** Merging topic branch: topic/tech/bsp/clk
2026-07-07T08:51:50.6178685Z fatal: refusing to merge unrelated histories
2026-07-07T08:51:50.7253717Z Merge failed, manual merge
[...]
2026-07-07T08:51:51.7172907Z Merging pr-1479 (no-commit)...
2026-07-07T08:52:11.2817360Z fatal: refusing to merge unrelated histories
2026-07-07T08:52:11.3910442Z Merge failed or conflicts detected. Aborting merge.
2026-07-07T08:52:11.3949897Z ##[error]Process completed with exit code 3.

All six checker jobs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) failed with identical errors during the merge setup phase, before any actual checker validation could run.

Analysis:

This is a CI configuration/infrastructure issue, not a defect in the PR code itself. The error occurs because:

  1. The CI workflow attempts to create an integration branch from baseline tag 19b282f417584cfe14ce6a262122c51553d026ec (appears to be a qcom-next baseline)
  2. It then tries to merge the topic branch tech/bsp/clk from qualcomm-linux/kernel-topics
  3. The topic branch has no common ancestor (unrelated git history) with the baseline tag
  4. Git refuses to merge unrelated histories without the --allow-unrelated-histories flag

Root cause classification:

This PR targets the tech/bsp/clk branch, which appears to be a standalone topic branch that was created independently (possibly rebased or recreated) and does not share git history with the qcom-next baseline that the CI is using for integration testing.

Fix options:

  1. For the PR author: No action needed on the patch itself. The code change is straightforward and appears correct (adds a conditional check before registering reset controller).

  2. For the CI/repo maintainers:

    • Option A: Update the CI workflow configuration to use --allow-unrelated-histories when merging topic branches that are known to have independent histories
    • Option B: Rebase the tech/bsp/clk branch onto the baseline to establish a common ancestor
    • Option C: Adjust the CI workflow to skip integration testing for topic branches and only validate the PR commits directly
    • Option D: Configure the workflow to use the topic branch tip as the baseline instead of qcom-next when the PR targets a topic branch

Reproduce locally:

# This will reproduce the CI failure:
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git fetch https://github.com/qualcomm-linux/kernel.git refs/tags/qcom-next
git checkout -b integ 19b282f417584cfe14ce6a262122c51553d026ec
git fetch https://github.com/qualcomm-linux/kernel-topics.git tech/bsp/clk:topic/tech/bsp/clk
git merge topic/tech/bsp/clk
# Will fail with: fatal: refusing to merge unrelated histories

# To allow the merge (workaround):
git merge --allow-unrelated-histories topic/tech/bsp/clk

📋 Patch Content Review (Manual)

Since the checkers could not run, here's a manual review of the PR patch:

Commit: 8ed634ebe80663d99248934f1275d23921ba780c
Subject: clk: qcom: common: Register reset controller only when resets are present

Code change: The patch adds a conditional check if (desc->num_resets) before registering the reset controller in qcom_cc_really_probe(). This prevents unnecessary reset controller registration when a clock controller descriptor has no reset lines.

Observations:

  • ✅ Code logic is sound and follows defensive programming practices
  • ✅ Indentation and formatting appear correct
  • ✅ Has Signed-off-by: trailer
  • ⚠️ Missing subject prefix - The commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:)
  • ⚠️ No Link: trailer - If this patch was posted upstream or is based on an upstream patch, it should include a Link: trailer pointing to the lore.kernel.org URL

Predicted checker results if CI had run:

  • checkpatch: Likely PASS (code formatting looks clean)
  • dt-binding-check: SKIP (no DT binding changes)
  • dtb-check: SKIP (no DTS changes)
  • sparse-check: SKIP (no changes to files that would trigger sparse)
  • check-uapi-headers: SKIP (no UAPI header changes)
  • check-patch-compliance: Likely FAIL - missing subject prefix and missing Link: trailer
  • tag-check: FAIL (if target branch is not qcom-next/qcom-next-staging) - subject must start with a valid prefix

Verdict

CI infrastructure issue blocks validation. The PR code itself appears correct, but compliance issues need addressing:

  1. Blocker: CI configuration must be fixed to allow checker execution
  2. Blocker (if not targeting qcom-next/qcom-next-staging): Add required subject prefix (e.g., FROMLIST:, UPSTREAM:, or QCLINUX:)
  3. Recommended: Add Link: trailer if this patch has an upstream equivalent or was posted to a mailing list

Recommended actions:

  • Immediate: Re-trigger CI after fixing the topic branch history issue (maintainer action)
  • Before merge: Update commit message with appropriate prefix and Link trailer (author action)

Use the correct alpha_pll_config member name test_ctl_hi_val for GPLL8,
GPLL10, and GPLL11. The existing test_ctl_hi1_val assignment is incorrect
and prevents the TEST_CTL_HI register value from being configured as
intended.

Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
@imrashai imrashai changed the title clk: qcom: common: Register reset controller only when resets are present Test CI/CD checks Jul 7, 2026
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qcomlnxci
qcomlnxci requested a review from a team July 7, 2026 09:52
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1479

PR: #1479
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28857370181

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict (not compilation error) Multiple files No Pre-existing integration conflicts between tech/bsp/clk branch and qcom-next baseline

Verdict

No compilation errors exist. The build failed during the automerge phase with 100+ merge conflicts in files completely unrelated to this PR. The PR changes to drivers/clk/qcom/gcc-qcm2290.c are not involved in any conflicts and would compile cleanly if the merge conflicts were resolved.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1479

PR: #1479
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28857370181

# Error File:Line PR-introduced? Root Cause
N/A Merge conflict (not compilation error) Multiple files No Automerge failure between topic branches unrelated to PR changes

Verdict

This is NOT a compilation failure. The build failed during the automerge stage due to merge conflicts between topic branches. The PR modifies only drivers/clk/qcom/gcc-qcm2290.c, which is NOT among the conflicting files. Zero compilation errors are introduced by this PR — the build never reached the compilation stage.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1479 — validate-patch

PR: #1479

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
  4. PR present in qcom-next: Not checked — filesystem permission restrictions prevented qcom-next clone/search
Verdict: ❌ — click to expand

Patch Validation Report

PR: #1479 - clk: qcom: gcc-qcm2290: Replace test_ctl_hi1_val with test_ctl_hi_val
Upstream: (none found)
Verdict: ❌ FAIL

Reason

No lore.kernel.org link was found in the PR description or commit message(s).
This skill only validates patches against a lore.kernel.org source.

The commit has no vendor prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:) and no Link: or Patch-mainline: tag pointing to lore.kernel.org.

Recommendation

Add a Link: https://lore.kernel.org/r/<message-id> line to the commit message and re-run validation, or use an appropriate prefix:

  • UPSTREAM: → link to the merged kernel.org commit (not applicable here)
  • FROMLIST: → link to the lore.kernel.org posting
  • BACKPORT: → link to the original lore.kernel.org or upstream commit
  • QCLINUX: → vendor-only change (no upstream link required)
  • PENDING: → work-in-progress, not yet posted (no upstream link required)
  • WORKAROUND: → temporary fix, not suitable for upstream (no upstream link required)

Commits with QCLINUX:, PENDING:, or WORKAROUND: prefixes have no upstream lore link by design and cannot be validated with this skill.

Analysis

The patch corrects a typo in struct member names (test_ctl_hi1_valtest_ctl_hi_val) in three PLL configurations (GPLL8, GPLL10, GPLL11) in drivers/clk/qcom/gcc-qcm2290.c. This appears to be a bug fix that should either:

  1. Be posted upstream to linux-clk mailing list (and tagged FROMLIST: with lore link), or
  2. Be marked as QCLINUX: if it's a vendor-specific fix not intended for upstream

Without a lore link or vendor prefix, the commit's upstream status and intent cannot be determined.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix
  4. PR present in qcom-next: Not checked — filesystem permission restrictions prevented qcom-next clone/search

@qlijarvis

Copy link
Copy Markdown

PR #1479 — checker-log-analyzer

PR: #1479
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28857370311

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check Missing subject prefix (see below)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1479 - clk: qcom: gcc-qcm2290: Replace test_ctl_hi1_val with test_ctl_hi_val
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28857370311

Checker Result Summary
checkpatch ⚠️ CI infrastructure failure - merge failed
dt-binding-check ⚠️ CI infrastructure failure - merge failed
dtb-check ⚠️ CI infrastructure failure - merge failed
sparse-check ⚠️ CI infrastructure failure - merge failed
check-uapi-headers ⚠️ CI infrastructure failure - merge failed
check-patch-compliance ⚠️ CI infrastructure failure - merge failed
tag-check Missing subject prefix (see below)

⚠️ CI Infrastructure Failure — All Checkers

Root cause: Git merge operation failed with "refusing to merge unrelated histories" during the automerge/integration step that precedes all checker runs.

Failure details:

fatal: refusing to merge unrelated histories
Merge failed, manual merge
...
fatal: refusing to merge unrelated histories
Merge failed or conflicts detected. Aborting merge.
##[error]Process completed with exit code 3.

This error appeared identically in all six checker jobs:

  • checkpatch
  • dt-binding-check
  • dtb-check
  • sparse-check
  • check-uapi-headers
  • check-patch-compliance

Analysis:

The kernel-checkers CI workflow attempts to:

  1. Create an integration branch based on the baseline (tag 19b282f417584cfe14ce6a262122c51553d026ec)
  2. Merge topic branches (starting with topic/tech/bsp/clk)
  3. Merge the PR branch (pr-1479)

Both merge operations failed with "refusing to merge unrelated histories", which indicates that:

  • The topic branch topic/tech/bsp/clk has no common ancestor with the baseline
  • The PR branch pr-1479 has no common ancestor with the integration branch

This is a CI infrastructure/configuration issue, not a defect in the patch itself.

Fix:

This requires CI infrastructure remediation. Possible root causes:

  1. The baseline tag or topic branch references are stale or incorrect
  2. The PR branch was created from an incompatible base
  3. The automerge configuration file is misconfigured

Recommended actions:

  1. Re-trigger the CI run after verifying the PR branch is based on a valid integration point
  2. Verify the PR base branch — ensure it's compatible with the kernel-checkers workflow
  3. Check the automerge configuration — the topic branch topic/tech/bsp/clk may need to be removed or updated in the integration config

Reproduce locally:

# This cannot be reproduced as a patch issue — it's a CI workflow configuration problem
# To debug, inspect the automerge config and topic branch ancestry

❌ tag-check — Missing Subject Prefix

Root cause: The commit subject does not start with a required prefix tag.

Failure details:

Commit 2ddd3dc32bd48ea11ace0b93944beae2e86de8f7:

Subject: clk: qcom: gcc-qcm2290: Replace test_ctl_hi1_val with test_ctl_hi_val

Analysis:

The commit subject lacks a mandatory prefix. All branches except qcom-next and qcom-next-staging require every commit to start with one of:

  • FROMLIST: — Patch posted to mailing list (lore.kernel.org)
  • FROMGIT: — Patch taken from a maintainer git tree
  • UPSTREAM: — Patch merged into Linus's mainline tree
  • BACKPORT: — Upstream patch backported with modifications
  • QCLINUX: — Vendor-only change with no upstream equivalent
  • PENDING: — Work-in-progress, not yet posted upstream
  • WORKAROUND: — Temporary fix not suitable for upstream

Note: I could not definitively determine the target branch from the CI logs due to the merge failure. If the target branch is qcom-next or qcom-next-staging, this check does not apply and can be ignored.

Fix:

git rebase -i HEAD~1   # mark the commit as 'edit'
git commit --amend -m "FROMLIST: clk: qcom: gcc-qcm2290: Replace test_ctl_hi1_val with test_ctl_hi_val"
git rebase --continue
git push --force-with-lease

Choose the appropriate prefix based on the patch origin:

  • If this patch has been posted to a mailing list → FROMLIST:
  • If this patch is in a maintainer tree → FROMGIT:
  • If this patch is merged into Linus's tree → UPSTREAM:
  • If this is a vendor-only fix → QCLINUX:

Verdict

Cannot assess patch quality — all checkers failed due to CI infrastructure issues before any code analysis could run.

Immediate blockers:

  1. CI infrastructure failure — "refusing to merge unrelated histories" prevents all checker execution
  2. Missing subject prefix — commit subject must start with a valid prefix tag (unless targeting qcom-next or qcom-next-staging)

Recommended next steps:

  1. Fix the CI merge issue (likely requires maintainer intervention or PR rebase)
  2. Add the appropriate subject prefix to the commit
  3. Re-trigger the CI run after both fixes are applied

Patch content assessment: The actual code change (replacing test_ctl_hi1_val with test_ctl_hi_val in three locations) appears to be a straightforward bug fix correcting a typo in struct member names. This is likely a valid fix, but cannot be verified by CI until the infrastructure issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants