Skip to content

FROMGIT: power: sequencing: pwrseq-pcie-m2: Add QCC2072 BT PCI device ID#1496

Open
weiden (WeiDeng-weiden) wants to merge 1 commit into
qualcomm-linux:tech/bus/pci/allfrom
WeiDeng-weiden:tech/bus/pci/all
Open

FROMGIT: power: sequencing: pwrseq-pcie-m2: Add QCC2072 BT PCI device ID#1496
weiden (WeiDeng-weiden) wants to merge 1 commit into
qualcomm-linux:tech/bus/pci/allfrom
WeiDeng-weiden:tech/bus/pci/all

Conversation

@WeiDeng-weiden

Copy link
Copy Markdown

Add the Qualcomm QCC2072 Bluetooth device (PCI ID 0x1112) to the pwrseq_m2_pci_ids table so the M.2 power sequencer can create the serdev node for its BT interface on enumeration.

Link: https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com

Add the Qualcomm QCC2072 Bluetooth device (PCI ID 0x1112) to the
pwrseq_m2_pci_ids table so the M.2 power sequencer can create the
serdev node for its BT interface on enumeration.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Link: https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested review from a team, krishnachaitanya-linux and Matthew Leung (meleung) and removed request for a team July 13, 2026 03:03
@qlijarvis

Copy link
Copy Markdown

PR #1496 — validate-patch

PR: #1496

Verdict Issues Detailed Report
⚠️ 2 Full report

Final Summary

  1. Lore link present: Yes — https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — network restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: Likely in maintainer tree — FROMGIT: prefix + maintainer sign-off from Bartosz Golaszewski indicates acceptance; cannot verify merge status due to network restrictions
  4. PR present in qcom-next: No — searched qcom-next branch at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel; the pwrseq_m2_pci_ids table currently only contains 0x1107 (wcn7850-bt), not 0x1112 (qcc2072-bt)
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1496 - FROMGIT: power: sequencing: pwrseq-pcie-m2: Add QCC2072 BT PCI device ID
Upstream commit: https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com
Verdict: ⚠️ PARTIAL (network restricted - could not fetch upstream for full comparison)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Cannot verify - network restricted
Body preserves rationale Clear explanation of adding QCC2072 device ID for M.2 power sequencer
Fixes tag present/correct N/A Not a fix - new device ID addition
Authorship preserved Author: Krishna Chaitanya Chundru; Maintainer sign-off: Bartosz Golaszewski
Backport note (if applicable) N/A FROMGIT prefix indicates patch is in maintainer tree, not a backport

Diff

File Status Notes
drivers/power/sequencing/pwrseq-pcie-m2.c ⏭️ Cannot compare to upstream - network restricted; adds 2 lines for PCI ID 0x1112

Issues

  • Network restriction: Cannot fetch upstream lore patch to perform byte-level diff comparison due to network access restrictions in the environment.
  • Verification limited: Commit structure appears correct with proper authorship chain (author → maintainer sign-off), lore link present, and FROMGIT: prefix appropriate for patches in maintainer trees.

Verdict

Cannot perform full validation due to network restrictions. Based on available evidence (proper commit structure, maintainer sign-off from Bartosz Golaszewski, lore link present, appropriate FROMGIT: prefix), the patch appears correctly formatted. Manual verification recommended: fetch the lore patch externally and compare diff content to confirm faithfulness.

Final Summary

  1. Lore link present: Yes — https://patch.msgid.link/20260703-eliza_evk-v1-3-7624440bd76d@oss.qualcomm.com
  2. Lore link matches PR commits: Cannot verify — network restricted; unable to fetch upstream patch for comparison
  3. Upstream patch status: Likely in maintainer tree — FROMGIT: prefix + maintainer sign-off from Bartosz Golaszewski indicates acceptance; cannot verify merge status due to network restrictions
  4. PR present in qcom-next: No — searched qcom-next branch at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel; the pwrseq_m2_pci_ids table currently only contains 0x1107 (wcn7850-bt), not 0x1112 (qcc2072-bt)

@qlijarvis

Copy link
Copy Markdown

PR #1496 — checker-log-analyzer

PR: #1496
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29220813834

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ CI merge failed - checker did not run
dt-binding-check ⏭️ CI merge failed - checker did not run
dtb-check ⏭️ CI merge failed - checker did not run
sparse-check ⏭️ CI merge failed - checker did not run
check-uapi-headers ⏭️ CI merge failed - checker did not run
check-patch-compliance ⏭️ CI merge failed - checker did not run
tag-check Subject has valid FROMGIT: prefix
qcom-next-check N/A Cannot determine target branch (network restricted)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1496 - FROMGIT: power: sequencing: pwrseq-pcie-m2: Add QCC2072 BT PCI device ID
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29220813834

Checker Result Summary
checkpatch ⏭️ CI merge failed - checker did not run
dt-binding-check ⏭️ CI merge failed - checker did not run
dtb-check ⏭️ CI merge failed - checker did not run
sparse-check ⏭️ CI merge failed - checker did not run
check-uapi-headers ⏭️ CI merge failed - checker did not run
check-patch-compliance ⏭️ CI merge failed - checker did not run
tag-check Subject has valid FROMGIT: prefix
qcom-next-check N/A Cannot determine target branch (network restricted)

⚠️ CI Infrastructure Failure

Root cause: All checker jobs failed during the automerge/integration phase with fatal: refusing to merge unrelated histories before any actual checker validation could run.

Failure details:

2026-07-13T03:20:22.2782571Z  ** Merging topic branch: topic/tech/bus/pci/all
2026-07-13T03:20:40.6058529Z fatal: refusing to merge unrelated histories
2026-07-13T03:20:40.7111000Z Merge failed, manual merge
...
2026-07-13T03:20:41.0005363Z Fetching PR #1496 from https://github.com/qualcomm-linux/kernel-topics.git...
2026-07-13T03:21:01.2570929Z fatal: refusing to merge unrelated histories
2026-07-13T03:21:01.3662793Z Merge failed or conflicts detected. Aborting merge.
2026-07-13T03:21:01.3700449Z ##[error]Process completed with exit code 3.

Analysis:

The CI workflow attempts to:

  1. Create an integration branch from baseline tag 947408df47978cb86ffcd180a6244379e03301bf
  2. Merge topic branch topic/tech/bus/pci/allfails with "unrelated histories"
  3. Merge PR FROMGIT: power: sequencing: pwrseq-pcie-m2: Add QCC2072 BT PCI device ID #1496fails with "unrelated histories"

This error indicates that the PR branch and/or the topic branch do not share a common ancestor with the baseline integration branch. This is a CI configuration or branch setup issue, not a defect in the patch itself.

Fix: This requires investigation of the PR branch history and CI configuration:

  1. Verify PR branch ancestry:

    git log --oneline --graph --all | grep -A 10 -B 10 93502ba9c6fe318a12ffbdbe07c69000f71fff1d
    git merge-base 947408df47978cb86ffcd180a6244379e03301bf 93502ba9c6fe318a12ffbdbe07c69000f71fff1d
  2. Check if PR was created from the correct base:

    • The PR should be based on a branch that shares history with the integration baseline
    • If the PR branch was created from an orphan branch or a different repository, it will have unrelated history
  3. Possible resolutions:

    • Rebase the PR branch onto the correct base branch
    • Use git merge --allow-unrelated-histories in the CI workflow (if intentional)
    • Verify the topic branch topic/tech/bus/pci/all is correctly configured

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git fetch origin pull/1496/head:pr-1496
git checkout 947408df47978cb86ffcd180a6244379e03301bf
git merge pr-1496
# Expected: same "refusing to merge unrelated histories" error

✅ Patch Quality Assessment (Manual Review)

Since the checkers did not run, I performed a manual review of the patch content:

Commit message:

  • ✅ Subject has valid FROMGIT: prefix
  • ✅ Subject line length: 73 characters (within 75-char limit)
  • ✅ Descriptive commit body
  • ✅ Proper Signed-off-by: tags (author + maintainer)
  • Link: tag present with valid lore.kernel.org URL

Code changes:

  • ✅ Adds 2 lines to drivers/power/sequencing/pwrseq-pcie-m2.c
  • ✅ Follows existing code style (indentation, formatting)
  • ✅ Adds new PCI device ID 0x1112 for QCC2072 Bluetooth
  • ✅ Consistent with surrounding entries in the pwrseq_m2_pci_ids table
  • ✅ No trailing whitespace, no style violations visible

Expected checker results (if CI had run):

  • checkpatch: ✅ PASS (clean formatting, proper commit message)
  • dt-binding-check: ⏭️ SKIP (no DT binding changes)
  • dtb-check: ⏭️ SKIP (no DTS changes)
  • sparse-check: ⏭️ SKIP (no C code logic changes, only data table entry)
  • check-uapi-headers: ⏭️ SKIP (no UAPI changes)
  • check-patch-compliance: ✅ PASS (FROMGIT: prefix + Link: tag present)

Verdict

The patch itself is clean and ready to merge. However, the CI run failed due to a branch history issue that prevents the integration merge from succeeding. This is a CI infrastructure blocker that must be resolved before the checkers can validate the patch.

Recommended actions:

  1. Investigate why the PR branch has unrelated history to the integration baseline
  2. Rebase the PR onto the correct base branch if needed
  3. Re-trigger CI after fixing the branch ancestry issue
  4. Once CI runs successfully, the patch should pass all checkers based on manual review

@WeiDeng-weiden

Copy link
Copy Markdown
Author

Hi krishnachaitanya-linux,
Could you please help review and merge this change? It has already been included in linux-next, and our internal FR requires this update.

@WeiDeng-weiden

Copy link
Copy Markdown
Author

Hi Matthew Leung (@meleung),
Could you please help review and merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants