Skip to content

FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies#1514

Open
qianyu-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
qianyu-qcom:tech/all/dt/hamoa
Open

FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies#1514
qianyu-qcom wants to merge 1 commit into
qualcomm-linux:tech/all/dt/hamoafrom
qianyu-qcom:tech/all/dt/hamoa

Conversation

@qianyu-qcom

Copy link
Copy Markdown

Wire up the LDO supplies required by the QREF and refgen blocks on Purwa and Hamoa boards. Purwa's QREF topology is same as Hamoa's, so it reuses the same qcom,x1e80100-tcsr compatible and supply set rather than needing a dedicated one.

@qcomlnxci
qcomlnxci requested review from a team, jingyiwang42, Shiraz Hashim (shashim-quic) and Trilok Soni (trsoni) and removed request for a team July 15, 2026 08:43
Wire up the LDO supplies required by the QREF and refgen blocks on Purwa
and Hamoa boards. Purwa's QREF topology is same as Hamoa's, so it reuses
the same qcom,x1e80100-tcsr compatible and supply set rather than needing
a dedicated one.

Link: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
@qianyu-qcom qianyu-qcom changed the title PENDING: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies Jul 20, 2026
@qcomlnxci
qcomlnxci requested a review from a team July 20, 2026 06:53
@qlijarvis

Copy link
Copy Markdown

PR #1514 — validate-patch

PR: #1514

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
  2. Lore link matches PR commits: No - PR is missing 2 of 19 files from the upstream patch (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files present have identical content.
  3. Upstream patch status: ⏳ In review - Posted July 14, 2026; received Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> but not yet merged to maintainer tree or mainline
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Upstream commit: https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream Subject correctly adapted with FROMLIST: prefix
Body preserves rationale Body text identical to upstream
Fixes tag present/correct N/A No Fixes tag in upstream patch
Authorship preserved Author Qiang Yu <qiang.yu@oss.qualcomm.com> matches lore
Backport note (if applicable) N/A Not a backport - FROMLIST prefix correct

Diff

File Status Notes
hamoa-iot-som.dtsi Content identical (context line numbers differ due to tree state)
hamoa-lenovo-ideacentre-mini-01q8x10.dts Content identical
purwa-iot-som.dtsi Content identical
x1-asus-vivobook-s15.dtsi Content identical
x1-asus-zenbook-a14.dtsi Content identical
x1-crd.dtsi Content identical
x1-dell-thena.dtsi Content identical
x1-hp-omnibook-x14.dtsi Content identical
x1-microsoft-denali.dtsi Content identical
x1e001de-devkit.dts Content identical
x1e78100-lenovo-thinkpad-t14s.dtsi Content identical
x1e80100-dell-xps13-9345.dts Content identical
x1e80100-lenovo-yoga-slim7x.dts Content identical
x1e80100-medion-sprchrgd-14-s1.dts Content identical
x1e80100-microsoft-romulus.dtsi Content identical
x1e80100-qcp.dts Content identical
x1p42100-lenovo-thinkbook-16.dts Content identical
x1e80100-honor-magicbook-art-14.dts Missing from PR - present in lore patch
x1p42100-microsoft-sp12in.dts Missing from PR - present in lore patch

Issues

Critical: Incomplete patch - missing 2 files from upstream

The PR patch is missing 2 device tree files that are present in the upstream lore patch (PATCH 3/3):

  1. arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts - Missing the &tcsr regulator supply block
  2. arch/arm64/boot/dts/qcom/x1p42100-microsoft-sp12in.dts - Missing the &tcsr regulator supply block

The lore patch modifies 19 files (adding QREF regulator supplies to all X1E80100/Hamoa/Purwa boards), but this PR only includes 17 files. The two Honor MagicBook Art 14 and Microsoft Surface Pro 12in boards are missing their regulator supply configurations.

All 17 files that are present have identical content to the lore patch (accounting for normal context line number differences due to tree state).

Verdict

Do not merge - This PR is an incomplete cherry-pick of the upstream patch. The missing files must be added to match the upstream patch exactly. Either:

  1. Add the 2 missing files to this PR, or
  2. If those board files don't exist in the target tree yet, document this as a partial backport in the commit message and explain which boards are intentionally excluded.

Final Summary

  1. Lore link present: Yes - https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
  2. Lore link matches PR commits: No - PR is missing 2 of 19 files from the upstream patch (x1e80100-honor-magicbook-art-14.dts and x1p42100-microsoft-sp12in.dts). The 17 files present have identical content.
  3. Upstream patch status: ⏳ In review - Posted July 14, 2026; received Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> but not yet merged to maintainer tree or mainline
  4. PR present in qcom-next/topics: Fail - Per integration_presence_report.md: 1/1 commit missing from both qcom-next and topics (expected for a FROMLIST patch not yet merged upstream)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1514 — checker-log-analyzer

PR: #1514
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29722917951

Checker Result Summary
Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check All DTB validations passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance b4 fetch failed for lore link
tag-check Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1514 - FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29722917951

Checker Result Summary
checkpatch No style issues
dt-binding-check ⏭️ No binding changes
dtb-check All DTB validations passed
sparse-check ⏭️ No C/H file changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance b4 fetch failed for lore link
tag-check Subject has valid FROMLIST: prefix

❌ check-patch-compliance

Root cause: The Link: trailer points to a cover letter (patch 0) rather than the actual patch, causing b4 am to fail validation.

Failure details:

Checking commit: FROMLIST: arm64: dts: qcom: hamoa/purwa: Add QREF regulator supplies
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/

The link URL contains v1-0- which indicates it's the cover letter (patch 0 of a series). The check-patch-compliance checker expects either:

  • A direct patch link (e.g., v1-1-<hash> for the first patch in the series)
  • The series base URL without the message-ID suffix

Fix: Update the Link: trailer to point to the actual patch message-ID, not the cover letter:

git rebase -i <base_sha>   # mark commit as 'edit'
# Find the correct patch link (v1-1-...) from lore.kernel.org
git commit --amend
# Replace the Link: line with the correct patch URL
git rebase --continue

To find the correct link:

  1. Visit https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/
  2. Click on the actual patch (not the cover letter) in the thread
  3. Copy the message-ID URL from the browser (it should contain v1-1- or similar)
  4. Update the commit message with the correct link

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/linux-arm-msm/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com/

Verdict

One blocker to fix: The Link: trailer must point to the actual patch message-ID, not the cover letter. All other checkers passed or were correctly skipped. Once the link is corrected, the PR should pass all checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants