Skip to content

FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory an…#1523

Merged
Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/all/dt/qcs8300from
qti-sbojja:monaco-audio-ML
Jul 17, 2026
Merged

FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory an…#1523
Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/all/dt/qcs8300from
qti-sbojja:monaco-audio-ML

Conversation

@qti-sbojja

Copy link
Copy Markdown
The audio ML (machine-learning) offload use case requires a contiguous,
physically addressable buffer shared with the audio DSP/SPF, and issues
DMA transactions through additional SMMU stream IDs that are not
covered by the existing ADSP mapping.

Add a dedicated reusable shared-dma-pool CMA region (16 MiB, 4 MiB
aligned) and wire it to the q6apm DAIs node via memory-region. A
dedicated pool guarantees the alignment and contiguity the DSP expects
and isolates these allocations from the default CMA region.

Under the EL2 (Gunyah/hypervisor) configuration the SMMU is fully
enforcing, so the ML transactions are otherwise blocked and faulted:

 arm-smmu 15000000.iommu: Blocked unknown Stream ID 0x2060
 arm-smmu 15000000.iommu: Blocked unknown Stream ID 0x2062

Add the ML-related stream IDs (0x3060 mask 0x9, 0x3062 mask 0x1) to the
remoteproc_adsp iommus property in the EL2 overlay so these buffers are
translated by the SMMU instead of being rejected.

@qcomlnxci
qcomlnxci requested review from a team, Amit Kucheria (idlethread), knaveen-qc and yijiyang and removed request for a team July 16, 2026 15:48
@qlijarvis

Copy link
Copy Markdown

PR #1523 — validate-patch

PR: #1523

Verdict Issues Detailed Report
⚠️ 4 Full report

Final Summary

  1. Lore link present: Yes - Link: tag correctly references the upstream patch (patch 2/2 of the series)
  2. Lore link matches PR commits: Yes - The diff is identical to the upstream monaco patch; only the commit message has a stream ID typo
  3. Upstream patch status: In review - Posted July 16, 2026 (v1); has received review feedback from Sashiko AI and Konrad Dybcio raising technical concerns about DT node naming, driver support for memory-region, and stream ID documentation
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1523 - FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory and SMMU mappings
Upstream commit: https://lore.kernel.org/all/20260716151854.3041914-3-pratyush.meduri@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream Subject is identical to upstream patch 2/2
Body preserves rationale Technical rationale and problem description preserved
Fixes tag present/correct N/A No Fixes tag in upstream; not a bugfix
Authorship preserved Author and Signed-off-by match upstream
Backport note (if applicable) FROMLIST: prefix correctly applied; Link: tag present

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-el2.dtso Identical to upstream patch
arch/arm64/boot/dts/qcom/monaco.dtsi Identical to upstream patch

Issues

Commit Message Error (Medium Severity)

  • The commit message incorrectly states "Add the ML-related stream IDs (0x3060 mask 0x9, 0x3062 mask 0x1)" but the actual code and error logs correctly use 0x2060 and 0x2062
  • This appears to be a copy-paste error from the lemans patch (patch 1/2 in the series), which does use 0x3060/0x3062
  • The error logs in the commit message correctly show 0x2060/0x2062, creating an internal inconsistency
  • Fix required: Update commit message to say "0x2060 mask 0x9, 0x2062 mask 0x1"

Upstream Review Concerns
The upstream patch has received review feedback raising technical concerns:

  1. Sashiko AI review flagged:

    • Node name qcom,audio-ml violates DT naming conventions (commas not allowed)
    • The memory-region property may be silently ignored because the driver doesn't call of_reserved_mem_device_init()
    • Commit message stream ID mismatch (0x3060 vs 0x2060)
  2. Konrad Dybcio review questioned:

    • Whether the node name with comma will trigger dtc warnings
    • Whether alloc-ranges ending at 0xffffffff is intentional
    • Whether Gunyah setup needs updates

These upstream concerns suggest the patch may need revision before acceptance.

Verdict

The diff is faithful to upstream, but the commit message contains a stream ID error (0x3060/0x3062 should be 0x2060/0x2062). Additionally, upstream reviewers have raised technical concerns that may require patch revision. Fix the commit message stream ID mismatch before merging.

Final Summary

  1. Lore link present: Yes - Link: tag correctly references the upstream patch (patch 2/2 of the series)
  2. Lore link matches PR commits: Yes - The diff is identical to the upstream monaco patch; only the commit message has a stream ID typo
  3. Upstream patch status: In review - Posted July 16, 2026 (v1); has received review feedback from Sashiko AI and Konrad Dybcio raising technical concerns about DT node naming, driver support for memory-region, and stream ID documentation
  4. PR present in qcom-next/topics: Fail - integration_presence_report.md shows 1/1 commit missing from both qcom-next and topics (expected for a patch posted today that's still in upstream review)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1523 — checker-log-analyzer

PR: #1523
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29512776956

Checker Result Summary
Checker Result Summary
checkpatch No style problems
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Schema violation: iommus array too long
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FROMLIST prefix valid, Link present
tag-check Subject has required FROMLIST: prefix
qcom-next-check FROMLIST commit appropriate for topic branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1523 - FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory and SMMU mappings
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29512776956

Checker Result Summary
checkpatch No style problems
dt-binding-check ⏭️ Skipped - no binding changes
dtb-check Schema violation: iommus array too long
sparse-check ⏭️ Skipped - no C code changes
check-uapi-headers ⏭️ Skipped - no UAPI changes
check-patch-compliance FROMLIST prefix valid, Link present
tag-check Subject has required FROMLIST: prefix
qcom-next-check FROMLIST commit appropriate for topic branch

❌ dtb-check

Root cause: The PR adds 3 iommus entries to remoteproc_adsp in monaco-el2.dtso, but the qcom,sa8775p-pas.yaml binding schema for qcom,qcs8300-adsp-pas only allows a maximum of 1 iommus entry.

Failure details:

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  iommus: [[56, 8192, 0], [56, 8288, 9], [56, 8290, 1]] is too long
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  Unevaluated properties are not allowed ('glink-edge', 'iommus' were unexpected)
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

The same error appears in:

  • monaco-evk-el2.dtb
  • monaco-camx-el2.dtb
  • qcs8300-ride-el2.dtb

All three DTBs include the monaco-el2.dtso overlay where the PR adds:

 &remoteproc_adsp {
-	iommus = <&apps_smmu 0x2000 0x0>;
+	iommus = <&apps_smmu 0x2000 0x0>,
+		<&apps_smmu 0x2060 0x9>,
+		<&apps_smmu 0x2062 0x1>;
 };

Fix: Update the qcom,sa8775p-pas.yaml binding to allow multiple iommus entries for qcom,qcs8300-adsp-pas. The binding currently constrains iommus to maxItems: 1, but the hardware requires 3 stream IDs for the ML offload use case.

Recommended approach:

  1. Add a separate binding patch (before this DTS patch) that updates Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
  2. Use an if/then clause to allow maxItems: 3 specifically for qcom,qcs8300-adsp-pas:
    allOf:
      - if:
          properties:
            compatible:
              contains:
                const: qcom,qcs8300-adsp-pas
        then:
          properties:
            iommus:
              minItems: 1
              maxItems: 3
  3. Ensure the binding patch is posted to the devicetree mailing list and gets a FROMLIST: prefix
  4. Reorder the series so the binding update comes before the DTS change

Reproduce locally:

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j$(nproc) O=out CHECK_DTBS=y qcom/monaco-evk-el2.dtb

Verdict

1 blocker to fix: The binding schema must be updated before this DTS change can be merged. The DTS change itself is correct (the hardware genuinely needs 3 SMMU stream IDs), but the binding doesn't yet allow it.

…d SMMU mappings

The audio ML (machine-learning) offload use case requires a contiguous,
physically addressable buffer shared with the audio DSP/SPF, and issues
DMA transactions through additional SMMU stream IDs that are not
covered by the existing ADSP mapping.

Add a dedicated reusable shared-dma-pool CMA region (16 MiB, 4 MiB
aligned) and wire it to the q6apm DAIs node via memory-region. A
dedicated pool guarantees the alignment and contiguity the DSP expects
and isolates these allocations from the default CMA region.

Under the EL2 (Gunyah/hypervisor) configuration the SMMU is fully
enforcing, so the ML transactions are otherwise blocked and faulted:

 arm-smmu 15000000.iommu: Blocked unknown Stream ID 0x2060
 arm-smmu 15000000.iommu: Blocked unknown Stream ID 0x2062

Add the ML-related stream IDs (0x3060 mask 0x9, 0x3062 mask 0x1) to the
remoteproc_adsp iommus property in the EL2 overlay so these buffers are
translated by the SMMU instead of being rejected.

Link: https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/
Signed-off-by: Pratyush Meduri <pratyush.meduri@oss.qualcomm.com>
@qcomlnxci
qcomlnxci requested a review from a team July 17, 2026 10:12
@qlijarvis

Copy link
Copy Markdown

PR #1523 — validate-patch

PR: #1523

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/

  2. Lore link matches PR commits: Yes — diff content is identical to the lore patch; context line number differences are due to tree state and do not affect the actual code changes

  3. Upstream patch status: ⏳ Decision Pending — posted 2026-07-17; only automated AI bot reviews present (Sashiko); no human maintainer decision (ACK/NAK) yet; patch is part of a v2 series addressing dt-binding issues from v1

  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1523 - FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory and SMMU mappings
Upstream commit: https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream Subject identical except for FROMLIST: prefix (expected)
Body preserves rationale Full commit message body preserved verbatim from lore
Fixes tag present/correct N/A No Fixes tag in upstream patch
Authorship preserved From: matches lore author (Pratyush Meduri pratyush.meduri@oss.qualcomm.com)
Backport note (if applicable) N/A FROMLIST: prefix used correctly; no backport note needed

Diff

File Status Notes
arch/arm64/boot/dts/qcom/monaco-el2.dtso Identical to lore patch (context line numbers differ due to tree state)
arch/arm64/boot/dts/qcom/monaco.dtsi Identical to lore patch (context line numbers differ due to tree state)

Issues

Commit message typo (inherited from upstream):
The commit message states "Add the ML-related stream IDs (0x3060 mask 0x9, 0x3062 mask 0x1)" but the code adds 0x2060 and 0x2062. This is a documentation error in the upstream lore patch itself, not introduced by the PR submitter. The code is correct for Monaco (uses 0x2xxx stream IDs), while Lemans uses 0x3xxx stream IDs.

AI bot review comments (not blocking):
The lore thread contains automated Sashiko AI review comments raising concerns about IOMMU domain mismatches and DT naming conventions. These are review suggestions, not maintainer decisions. No human maintainer has issued a NAK or acceptance decision yet.

Verdict

PASS — The PR patch is a faithful representation of the upstream lore posting. The diff content matches exactly (modulo context line number shifts due to tree state differences). The commit message is preserved verbatim, authorship is correct, and the FROMLIST: prefix is used appropriately. The commit message typo (0x3060 vs 0x2060) exists in the upstream lore patch and is not introduced by the PR submitter.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/

  2. Lore link matches PR commits: Yes — diff content is identical to the lore patch; context line number differences are due to tree state and do not affect the actual code changes

  3. Upstream patch status: ⏳ Decision Pending — posted 2026-07-17; only automated AI bot reviews present (Sashiko); no human maintainer decision (ACK/NAK) yet; patch is part of a v2 series addressing dt-binding issues from v1

  4. PR present in qcom-next/topics: No — per integration_presence_report.md, commit is missing from both qcom-next (a5cf3debd8c3) and all kernel topic branches; this is expected for a FROMLIST: patch that has not yet been accepted upstream

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a5cf3debd8c3c660711ad586ad4bb84e9ca42635
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1523 — checker-log-analyzer

PR: #1523
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572651820

Checker Result Summary
Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check iommus array too long
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check Subject has valid FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1523 - FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory and SMMU mappings
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572651820

Checker Result Summary
checkpatch Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check iommus array too long
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance Passed
tag-check Subject has valid FROMLIST: prefix

❌ dtb-check

Root cause: The iommus property in remoteproc_adsp (monaco-el2.dtso) now has 3 entries [[56, 8192, 0], [56, 8288, 9], [56, 8290, 1]], but the binding schema qcom,sa8775p-pas.yaml expects a maximum of 2 iommus entries.

Failure details:

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  iommus: [[56, 8192, 0], [56, 8288, 9], [56, 8290, 1]] is too long
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  Unevaluated properties are not allowed ('glink-edge', 'iommus' were unexpected)
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

The same error appears for:

  • monaco-evk-el2.dtb
  • monaco-camx-el2.dtb
  • qcs8300-ride-el2.dtb

Analysis:

The patch adds two additional SMMU stream IDs to remoteproc_adsp in monaco-el2.dtso:

 &remoteproc_adsp {
-	iommus = <&apps_smmu 0x2000 0x0>;
+	iommus = <&apps_smmu 0x2000 0x0>,
+		<&apps_smmu 0x2060 0x9>,
+		<&apps_smmu 0x2062 0x1>;
 };

This changes the iommus property from 1 entry to 3 entries. However, the DT binding schema for qcom,qcs8300-adsp-pas (which inherits from qcom,sa8775p-pas.yaml) defines iommus with maxItems: 2, meaning it only allows up to 2 SMMU entries.

The "Unevaluated properties" error is a secondary issue — the schema is rejecting the iommus property entirely because it doesn't match the expected format, which then causes it to be flagged as "unevaluated."

Fix:

The DT binding schema needs to be updated before this DTS change can be merged. There are two options:

Option 1 (Recommended): Update the binding schema to allow 3 iommus entries for qcom,qcs8300-adsp-pas:

# In Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
# Add a conditional override for qcom,qcs8300-adsp-pas:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,qcs8300-adsp-pas
    then:
      properties:
        iommus:
          minItems: 1
          maxItems: 3

Option 2: Split this PR into two patches:

  1. First patch: Update the binding schema to allow maxItems: 3 for qcom,qcs8300-adsp-pas
  2. Second patch: Add the DTS changes (current patch)

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-evk-el2.dtb

Upstream coordination:

Since this is a FROMLIST: patch (Link: https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/), the binding update should be included in the upstream patch series. Check if the lore series includes a binding patch — if not, it needs to be added to the series before this DTS patch.


Verdict

❌ Blocker: Cannot merge until binding schema is updated.

The DTS change is correct and well-documented, but it violates the current binding schema. The binding must be updated first to allow 3 iommus entries for qcom,qcs8300-adsp-pas, either:

  • As a separate patch in this PR (submitted upstream first), or
  • As part of the upstream patch series (verify the lore link includes a binding update)

All other checkers passed cleanly.

@qti-sbojja

Copy link
Copy Markdown
Author

PR #1523 — checker-log-analyzer

PR: #1523 Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572651820

Checker Result Summary
Checker Result Summary
checkpatch ✅ Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ❌ iommus array too long
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ✅ Passed
tag-check ✅ Subject has valid FROMLIST: prefix
Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1523 - FROMLIST: arm64: dts: qcom: monaco: enable audio ML offload memory and SMMU mappings
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29572651820

Checker
Result
Summary

checkpatch

Passed

dt-binding-check
⏭️
Skipped (no binding changes)

dtb-check

iommus array too long

sparse-check
⏭️
Skipped (no C/H changes)

check-uapi-headers
⏭️
Skipped (no UAPI changes)

check-patch-compliance

Passed

tag-check

Subject has valid FROMLIST: prefix

❌ dtb-check

Root cause: The iommus property in remoteproc_adsp (monaco-el2.dtso) now has 3 entries [[56, 8192, 0], [56, 8288, 9], [56, 8290, 1]], but the binding schema qcom,sa8775p-pas.yaml expects a maximum of 2 iommus entries.
Failure details:

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  iommus: [[56, 8192, 0], [56, 8288, 9], [56, 8290, 1]] is too long
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

monaco-evk-el2.dtb: remoteproc@3000000 (qcom,qcs8300-adsp-pas): 
  Unevaluated properties are not allowed ('glink-edge', 'iommus' were unexpected)
  from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sa8775p-pas.yaml#

The same error appears for:

  • monaco-evk-el2.dtb
  • monaco-camx-el2.dtb
  • qcs8300-ride-el2.dtb

Analysis:
The patch adds two additional SMMU stream IDs to remoteproc_adsp in monaco-el2.dtso:

 &remoteproc_adsp {
-	iommus = <&apps_smmu 0x2000 0x0>;
+	iommus = <&apps_smmu 0x2000 0x0>,
+		<&apps_smmu 0x2060 0x9>,
+		<&apps_smmu 0x2062 0x1>;
 };

This changes the iommus property from 1 entry to 3 entries. However, the DT binding schema for qcom,qcs8300-adsp-pas (which inherits from qcom,sa8775p-pas.yaml) defines iommus with maxItems: 2, meaning it only allows up to 2 SMMU entries.
The "Unevaluated properties" error is a secondary issue — the schema is rejecting the iommus property entirely because it doesn't match the expected format, which then causes it to be flagged as "unevaluated."
Fix:
The DT binding schema needs to be updated before this DTS change can be merged. There are two options:
Option 1 (Recommended): Update the binding schema to allow 3 iommus entries for qcom,qcs8300-adsp-pas:

# In Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
# Add a conditional override for qcom,qcs8300-adsp-pas:

allOf:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,qcs8300-adsp-pas
    then:
      properties:
        iommus:
          minItems: 1
          maxItems: 3

Option 2: Split this PR into two patches:

  1. First patch: Update the binding schema to allow maxItems: 3 for qcom,qcs8300-adsp-pas
  2. Second patch: Add the DTS changes (current patch)

Reproduce locally:

make -j$(nproc) O=out defconfig
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/monaco-evk-el2.dtb

Upstream coordination:
Since this is a FROMLIST: patch (Link: https://lore.kernel.org/all/20260717095825.3962666-4-pratyush.meduri@oss.qualcomm.com/), the binding update should be included in the upstream patch series. Check if the lore series includes a binding patch — if not, it needs to be added to the series before this DTS patch.

Verdict

❌ Blocker: Cannot merge until binding schema is updated.
The DTS change is correct and well-documented, but it violates the current binding schema. The binding must be updated first to allow 3 iommus entries for qcom,qcs8300-adsp-pas, either:

  • As a separate patch in this PR (submitted upstream first), or
  • As part of the upstream patch series (verify the lore link includes a binding update)

All other checkers passed cleanly.

we have fixed change here. 575dc8e

@Komal-Bajaj
Komal Bajaj (Komal-Bajaj) merged commit 251e0b5 into qualcomm-linux:tech/all/dt/qcs8300 Jul 17, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants