Skip to content

Qcom 6.18.y - interconnect: qcom: Convert RPMh interconnect drivers to dynamic IDs and enable QoS support#809

Open
chintava wants to merge 35 commits into
qualcomm-linux:qcom-6.18.yfrom
chintava:qcom-6.18.y
Open

Qcom 6.18.y - interconnect: qcom: Convert RPMh interconnect drivers to dynamic IDs and enable QoS support#809
chintava wants to merge 35 commits into
qualcomm-linux:qcom-6.18.yfrom
chintava:qcom-6.18.y

Conversation

@chintava

@chintava chintava commented Jul 6, 2026

Copy link
Copy Markdown

This PR updates Qualcomm RPMh interconnect code to use dynamic IDs and removes old non-dynamic ID code.
It also adds device tree binding and DTS changes to turn on QoS setup for qcs615, qcs8300, and sa8775p.

CRs-Fixed: 4598092

… array

Declaring link_nodes as a double-pointer results in a syntax sugar in
the interconnect driver to typecast the array. Change the type of
link_nodes field to the array to remove the need for the extra typecast.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-1-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-2-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-3-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-4-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-5-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-6-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-7-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-8-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-9-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-10-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-11-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-12-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-13-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-14-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-15-0575304c9624@oss.qualcomm.com
@qlijarvis

Copy link
Copy Markdown

PR #809 — validate-patch

PR: #809

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Unknown - cannot access commit messages or PR description
  2. Lore link matches PR commits: N/A - no patch content available for comparison
  3. Upstream patch status: Unknown - cannot fetch lore threads without network access
  4. PR present in qcom-next: Not checked - validation cannot proceed without patch content
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #809 - Interconnect dynamic IDs conversion and QoS configuration
Upstream commit: Unable to verify - no network access and pr.patch file is empty
Verdict: ❌ FAIL - Cannot validate without patch content

Analysis Constraints

This validation could not be completed due to the following limitations:

  1. No patch content available: The pr.patch file provided is empty (0 bytes)
  2. No network access: Cannot fetch PR details from GitHub API or lore.kernel.org
  3. Limited information: Only commit subjects are available from checker logs

Commits Identified (from checker logs)

The PR contains 33 commits, all with UPSTREAM: prefix:

  1. dcf59c1 - "UPSTREAM: interconnect: qcom: icc-rpmh: convert link_nodes to dynamic array"
  2. 87defef - "UPSTREAM: interconnect: qcom: sc7280: convert to dynamic IDs"
  3. 7db2209 - "UPSTREAM: interconnect: qcom: sc8180x: convert to dynamic IDs"
  4. 6187508 - "UPSTREAM: interconnect: qcom: sc8280xp: convert to dynamic IDs"
  5. 737ad5e - "UPSTREAM: interconnect: qcom: sdm845: convert to dynamic IDs"
  6. 016e39d - "UPSTREAM: interconnect: qcom: sm8250: convert to dynamic IDs"
  7. 13babdd - "UPSTREAM: interconnect: qcom: x1e80100: convert to dynamic IDs"
  8. b4afddc - "UPSTREAM: interconnect: qcom: qcs615: convert to dynamic IDs"
  9. 04cfa40 - "UPSTREAM: interconnect: qcom: qcs8300: convert to dynamic IDs"
  10. 9dbdb84 - "UPSTREAM: interconnect: qcom: qdu1000: convert to dynamic IDs"
  11. 72374c6 - "UPSTREAM: interconnect: qcom: sar2130p: convert to dynamic IDs"
  12. cda8188 - "UPSTREAM: interconnect: qcom: sc7180: convert to dynamic IDs"
  13. 4395bbd - "UPSTREAM: interconnect: qcom: sdm670: convert to dynamic IDs"
  14. e084ec8 - "UPSTREAM: interconnect: qcom: sdx55: convert to dynamic IDs"
  15. 0f0ed1c - "UPSTREAM: interconnect: qcom: sdx65: convert to dynamic IDs"
  16. 9bab681 - "UPSTREAM: interconnect: qcom: sdx75: convert to dynamic IDs"
  17. d222fb1 - "UPSTREAM: interconnect: qcom: sm6350: convert to dynamic IDs"
  18. ca78d83 - "UPSTREAM: interconnect: qcom: sm7150: convert to dynamic IDs"
  19. 56a4886 - "UPSTREAM: interconnect: qcom: sm8150: convert to dynamic IDs"
  20. 5232255 - "UPSTREAM: interconnect: qcom: sm8350: convert to dynamic IDs"
  21. fee877d - "UPSTREAM: interconnect: qcom: sm8450: convert to dynamic IDs"
  22. f2dd08a - "UPSTREAM: interconnect: qcom: sm8550: convert to dynamic IDs"
  23. 0373871 - "UPSTREAM: interconnect: qcom: sm8650: convert to dynamic IDs"
  24. 8c74de8 - "UPSTREAM: interconnect: qcom: sm8750: convert to dynamic IDs"
  25. d241ac8 - "UPSTREAM: interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS"
  26. 06bf027 - "UPSTREAM: dt-bindings: interconnect: qcom,qcs615-rpmh: add clocks property to enable QoS"
  27. ae136d8 - "UPSTREAM: interconnect: qcom: qcs615: enable QoS configuration"
  28. 5b79dba - "UPSTREAM: arm64: dts: qcom: talos: Add clocks for QoS configuration"
  29. 7bd9039 - "UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts"
  30. 587aa05 - "UPSTREAM: dt-bindings: interconnect: qcom,qcs8300-rpmh: add clocks property to enable QoS"
  31. 9b753f5 - "UPSTREAM: interconnect: qcom: qcs8300: enable QoS configuration"
  32. e2e883c - "UPSTREAM: arm64: dts: qcom: qcs8300: Add clocks for QoS configuration"
  33. cad1cf1 - "UPSTREAM: dt-bindings: interconnect: add reg and clocks properties to enable QoS on sa8775p"

Required Actions

To complete validation, the following is needed:

  1. Provide patch content: Either populate pr.patch with the actual PR diff, or provide network access to fetch from GitHub
  2. Lore links: Each UPSTREAM: commit must have a Link: tag pointing to lore.kernel.org or a kernel.org commit URL
  3. Commit messages: Full commit messages are needed to verify:
    • Authorship preservation (From: field must match upstream)
    • Presence of required tags (Link:, Fixes: if applicable)
    • Body content matches upstream rationale
    • No misuse of Co-developed-by tags

Verdict

Cannot validate - The validate-patch skill requires:

  • Access to the actual patch diff content
  • Ability to fetch lore.kernel.org patches for comparison
  • Full commit messages with Link: tags

Without these, I cannot verify:

  • Whether lore links are present
  • Whether patches match their upstream sources
  • Whether authorship is correctly preserved
  • Whether the patches have been accepted upstream

Final Summary

  1. Lore link present: Unknown - cannot access commit messages or PR description
  2. Lore link matches PR commits: N/A - no patch content available for comparison
  3. Upstream patch status: Unknown - cannot fetch lore threads without network access
  4. PR present in qcom-next: Not checked - validation cannot proceed without patch content

@qlijarvis

Copy link
Copy Markdown

PR #809 — checker-log-analyzer

PR: #809
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28786517294

Checker Result Summary
Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check 3 binding files validated successfully
dtb-check All DTBs validated, no new errors
sparse-check No sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance 2 commits failed
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #809 - Interconnect QoS configuration and dynamic IDs conversion
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28786517294
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check 3 binding files validated successfully
dtb-check All DTBs validated, no new errors
sparse-check No sparse warnings
check-uapi-headers No UAPI changes
check-patch-compliance 2 commits failed
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

❌ check-patch-compliance

Root cause: Two commits have issues with their upstream Link references.

Failure 1: Content mismatch

Commit: 9bab68150f37 ("UPSTREAM: interconnect: qcom: sdx75: convert to dynamic IDs")

Failure details:

Checking commit: UPSTREAM: interconnect: qcom: sdx75: convert to dynamic IDs
Change is different from the one mentioned in Link

Root cause: The patch content in the PR differs from the upstream patch referenced in the Link: trailer. This could be due to:

  • Context-only differences (line number shifts from other patches)
  • Legitimate adaptations for the target kernel version
  • Missing or extra hunks

Fix:

  1. Fetch the upstream patch and compare:

    # Extract the Link: URL from the commit message
    git show 9bab68150f37 | grep "^Link:"
    # Fetch with b4
    b4 am --single-message -C -l -3 <link-url> -o /tmp/sdx75-upstream
    # Compare the actual changes (+ and - lines only)
    diff <(git format-patch -1 9bab68150f37 --stdout | awk '/^diff/,/^--$/' | grep -E '^[+-][^+-]') \
         <(awk '/^diff/,/^--$/' /tmp/sdx75-upstream/*.mbx | grep -E '^[+-][^+-]')
  2. If the difference is context-only (line numbers shifted but code is identical):

    • This is a false positive from the checker's strict diff comparison
    • No action needed; document in PR comments
  3. If there are legitimate adaptations (e.g., function signature changed in this kernel version):

    • Add a note in the commit message explaining the adaptation:
      [ Upstream commit <sha> ]
      
      Adapted for qcom-6.18.y:
      - <describe the change>
      
      Link: <lore-url>
      
  4. If there are missing hunks:

    • Cherry-pick the missing changes
    • Amend the commit

Reproduce locally:

cd /path/to/kernel
git show 9bab68150f37
# Check the Link: trailer and fetch with b4 as shown above

Failure 2: Missing Link trailer

Commit: 7bd9039dfe24 ("UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts")

Failure details:

Checking commit: UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts
No 'Link' found in commit message

Root cause: The commit message is missing the required Link: trailer pointing to the upstream lore.kernel.org patch.

Fix:

git rebase -i <base_sha>   # mark commit 7bd9039dfe24 as 'edit'

# Add the Link: trailer to the commit message
git commit --amend

# In the editor, add before the Signed-off-by: line:
# Link: https://lore.kernel.org/r/<message-id>

git rebase --continue

To find the correct lore link:

  1. Search lore.kernel.org for the commit subject: "interconnect: qcom: kaanapali: Drop redundant link_nodes casts"
  2. Or if you know the upstream commit SHA, use:
    git log --all --grep="kaanapali: Drop redundant link_nodes casts" --format="%H %s"
    # Then search lore for that commit SHA or subject

Reproduce locally:

cd /path/to/kernel
git show 7bd9039dfe24 | grep "^Link:"
# Should return nothing (missing)

Verdict

2 blockers must be fixed before merge:

  1. Commit 9bab68150f37 (sdx75) — Investigate and resolve the content mismatch with upstream. If it's a false positive (context-only diff), document it. If there are real differences, either fix them or document the adaptation.

  2. Commit 7bd9039dfe24 (kaanapali) — Add the missing Link: trailer pointing to the upstream lore patch.

All other checkers passed cleanly. Once these two commits are fixed, the PR will be ready to merge.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4598092 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4598092
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #809 — validate-patch

PR: #809

Verdict Issues Detailed Report
3 Full report

Final Summary

  1. Lore link present: Unknown — cannot check without patch content or PR metadata
  2. Lore link matches PR commits: N/A — no patch content to compare
  3. Upstream patch status: Unknown — cannot determine without lore link
  4. PR present in qcom-next: Not checked — no commit SHA or content to search for
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #809 (qualcomm-linux/kernel)
Upstream commit: N/A
Verdict: ❌ FAIL

Reason

Cannot perform validation: the pr.patch file is empty and network access to GitHub API is restricted. The GitHub Actions workflow indicates "no jobs" were run for this PR, suggesting either:

  1. The PR contains no commits
  2. The PR diff could not be generated
  3. The PR was closed or merged before the checker workflow ran

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped No patch content available
Body preserves rationale ⏭️ Skipped No patch content available
Fixes tag present/correct ⏭️ Skipped No patch content available
Authorship preserved ⏭️ Skipped No patch content available
Backport note (if applicable) ⏭️ Skipped No patch content available

Diff

File Status Notes
(none) Empty pr.patch file — no diff content to validate

Issues

  • Critical: pr.patch file is empty — cannot extract commit message, diff content, or lore links
  • Critical: GitHub API access unavailable — cannot fetch PR metadata directly
  • Critical: Workflow shows "no jobs" status — suggests PR may have no commits or was already closed/merged

Verdict

Cannot validate — no patch content available. Verify that PR #809 exists, contains commits, and is still open.

Final Summary

  1. Lore link present: Unknown — cannot check without patch content or PR metadata
  2. Lore link matches PR commits: N/A — no patch content to compare
  3. Upstream patch status: Unknown — cannot determine without lore link
  4. PR present in qcom-next: Not checked — no commit SHA or content to search for

Recommendation

To perform validation, ensure:

If the PR was already merged or closed, validation against the historical state requires the commit SHA (ef6ca74) to be checked out and analyzed directly.

@qlijarvis

Copy link
Copy Markdown

PR #809 — checker-log-analyzer

PR: #809
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/28846257906

Checker Result Summary
Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check All binding schemas valid
dtb-check No new DTB validation errors
sparse-check No sparse warnings
check-uapi-headers No UAPI ABI breakage
check-patch-compliance 2 commits with link issues
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #809 - Interconnect QoS and dynamic IDs updates
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/28846257906

Checker Result Summary
checkpatch All commits pass style checks
dt-binding-check All binding schemas valid
dtb-check No new DTB validation errors
sparse-check No sparse warnings
check-uapi-headers No UAPI ABI breakage
check-patch-compliance 2 commits with link issues
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

❌ check-patch-compliance

Root cause: Two commits have issues with their upstream Link: references — one has content mismatch, one has an invalid link format.

Failure details:

Issue 1: Content mismatch

Checking commit: BACKPORT: UPSTREAM: interconnect: qcom: sdx75: convert to dynamic IDs
Change is different from the one mentioned in Link

Issue 2: Invalid link format

Checking commit: UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://github.com/qualcomm-linux/kernel-topics/commit/5ffe1910ed3e44ea2e442eda3afc06681f587aad#diff-feb283e46e30f4a2e9503ef222d325d3a57aa57a30ab7ccd452e174e97d666a1

Analysis:

  1. sdx75 commit (BACKPORT): The commit is correctly tagged as BACKPORT: UPSTREAM: indicating modifications were made, but the checker detected that the actual code changes differ from the upstream link. This is expected for backports but the Link: should point to a valid lore.kernel.org URL, not a GitHub commit.

  2. kaanapali commit (UPSTREAM): The Link: tag contains a GitHub URL with a diff fragment (#diff-...), which is not a valid format for b4 am. The checker expects a lore.kernel.org message-ID URL or a plain commit reference without fragment identifiers.

Fix:

For both commits, update the Link: trailer to use proper lore.kernel.org URLs:

# Find the commits
git log --oneline --grep="sdx75: convert to dynamic IDs"
git log --oneline --grep="kaanapali: Drop redundant"

# For each commit, rebase and fix the Link: tag
git rebase -i <base_sha>   # mark commits as 'edit'

# Replace the Link: line with a valid lore.kernel.org URL, e.g.:
# Link: https://lore.kernel.org/r/<message-id>
# or
# Link: https://git.kernel.org/pub/scm/linux/kernel/git/<tree>/<repo>.git/commit/?id=<sha>

git commit --amend --no-edit
git rebase --continue

For the sdx75 BACKPORT commit specifically:

  • Verify the changes are intentional adaptations for the target kernel version
  • Ensure the Link: points to the original upstream commit (lore or git.kernel.org)
  • The BACKPORT: prefix correctly signals that modifications were made

For the kaanapali commit:

  • Remove the #diff-... fragment from the GitHub URL
  • Replace with a proper lore.kernel.org or git.kernel.org URL
  • If this is truly an UPSTREAM commit, it should reference the mainline merge, not a topic branch

Reproduce locally:

# Test the sdx75 commit
b4 am --single-message -C -l -3 <correct-lore-url-for-sdx75>

# Test the kaanapali commit  
b4 am --single-message -C -l -3 <correct-lore-url-for-kaanapali>

Verdict

2 blockers to fix before merge:

  1. Fix the Link: tag in the sdx75 BACKPORT commit to point to a valid lore.kernel.org or git.kernel.org URL
  2. Fix the Link: tag in the kaanapali commit to remove the GitHub diff fragment and use a proper upstream reference

All other checkers passed cleanly. Once the Link: tags are corrected, the PR will be ready to merge.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4598092 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4598092
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #809 — validate-patch

PR: #809

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Unknown — cannot access PR description or commit messages
  2. Lore link matches PR commits: N/A — no patch content available to compare
  3. Upstream patch status: Unknown — cannot fetch or verify upstream status
  4. PR present in qcom-next: Not checked — validation cannot proceed without patch content
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #809 (qualcomm-linux/kernel)
Upstream commit: Unable to determine — patch content not available
Verdict: ❌ FAIL

Reason

Cannot perform patch validation — the pr.patch file is empty and network access is restricted, preventing fetch of PR content from GitHub API or lore.kernel.org.

Required to Complete Validation

To validate this PR, the following information is needed:

  1. PR patch content — the actual diff/commit message from PR Qcom 6.18.y - interconnect: qcom: Convert RPMh interconnect drivers to dynamic IDs and enable QoS support #809
  2. PR description — to extract any lore.kernel.org links
  3. Network access — to fetch upstream patches from lore.kernel.org for comparison

What Was Attempted

Recommendation

Re-run this validation with one of the following:

  1. Populate pr.patch — ensure the pr.patch file contains the actual patch content from PR Qcom 6.18.y - interconnect: qcom: Convert RPMh interconnect drivers to dynamic IDs and enable QoS support #809
  2. Enable network access — allow fetching from api.github.com and lore.kernel.org
  3. Provide PR metadata — include PR title, description, and commit messages in a local file

Final Summary

  1. Lore link present: Unknown — cannot access PR description or commit messages
  2. Lore link matches PR commits: N/A — no patch content available to compare
  3. Upstream patch status: Unknown — cannot fetch or verify upstream status
  4. PR present in qcom-next: Not checked — validation cannot proceed without patch content

@qlijarvis

Copy link
Copy Markdown

PR #809 — checker-log-analyzer

PR: #809
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29008199455

Checker Result Summary
Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check All binding changes validated
dtb-check No new DTB validation errors
sparse-check No new sparse warnings
check-uapi-headers No UAPI ABI changes
check-patch-compliance 2 failures: content mismatch + invalid link
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #809 - Interconnect QoS and dynamic IDs conversion
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29008199455
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check All binding changes validated
dtb-check No new DTB validation errors
sparse-check No new sparse warnings
check-uapi-headers No UAPI ABI changes
check-patch-compliance 2 failures: content mismatch + invalid link
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

❌ check-patch-compliance

Root cause: Two commits failed upstream link validation — one has content differences from the linked upstream patch, and one has an invalid GitHub commit link that b4 cannot fetch.

Failure details:

Failure 1 — Content mismatch:

Checking commit: BACKPORT: UPSTREAM: interconnect: qcom: sdx75: convert to dynamic IDs
Change is different from the one mentioned in Link

Failure 2 — Invalid link (GitHub commit URL instead of lore.kernel.org):

Checking commit: UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://github.com/torvalds/linux/commit/5ffe1910ed3e44ea2e442eda3afc06681f587aad

Analysis:

  1. sdx75 content mismatch: The commit is correctly tagged as BACKPORT: UPSTREAM: (indicating modifications from upstream), but the checker detected differences between the PR patch and the upstream lore link. This is expected for backports — the BACKPORT: prefix signals intentional adaptations. However, the checker still flags it because it cannot distinguish legitimate backport changes from unintended drift.

  2. kaanapali invalid link: The commit provides a GitHub commit URL (https://github.com/torvalds/linux/commit/5ffe1910ed3e44ea2e442eda3afc06681f587aad) in the Link: trailer, but check-patch-compliance uses b4 am to fetch and compare patches, which requires a lore.kernel.org message-ID URL. GitHub commit URLs are not valid for b4 fetch operations.

Fix:

For sdx75 (content mismatch):

  • If the backport changes are intentional (e.g., context differences, missing dependencies, or adaptations for the target kernel version), document the rationale in the commit message body above the Link: line. Example:
    [ Upstream commit <sha> ]
    
    Backport notes: Adapted for qcom-6.18.y — removed dependency on
    <feature> which is not present in this kernel version.
    
    Link: https://lore.kernel.org/...
    
  • If the changes are unintended, fetch the upstream patch and reapply cleanly:
    b4 am --single-message -C -l -3 <lore-link> -o /tmp/out
    git rebase -i <base_sha>  # mark commit as 'edit'
    git reset HEAD~1
    git am /tmp/out/*.mbx
    git rebase --continue

For kaanapali (invalid link):

  • Replace the GitHub commit URL with the corresponding lore.kernel.org message-ID URL. To find it:
    1. Visit the GitHub commit page: torvalds/linux@5ffe191
    2. Look for the Link: trailer in the commit message — it will contain the lore URL.
    3. Alternatively, search lore.kernel.org for the commit subject: "interconnect: qcom: kaanapali: Drop redundant link_nodes casts"
  • Update the commit message:
    git rebase -i <base_sha>  # mark commit as 'edit'
    git commit --amend  # replace GitHub URL with lore URL
    git rebase --continue

Reproduce locally:

# For sdx75 content mismatch:
b4 am --single-message -C -l -3 <lore-link-from-commit-message> -o /tmp/sdx75
git format-patch -1 <sdx75-commit-sha> --stdout > /tmp/sdx75-pr.patch
diff <(grep -E '^[+-][^+-]' /tmp/sdx75-pr.patch) <(grep -E '^[+-][^+-]' /tmp/sdx75/*.mbx)

# For kaanapali invalid link:
b4 am --single-message -C -l -3 https://github.com/torvalds/linux/commit/5ffe1910ed3e44ea2e442eda3afc06681f587aad
# (This will fail — confirming the issue)

Verdict

2 blockers to fix before merge:

  1. sdx75 backport: Either document the backport rationale in the commit message, or verify that the content differences are intentional and expected for a BACKPORT: commit. If unintended, reapply the upstream patch cleanly.

  2. kaanapali link: Replace the GitHub commit URL with the lore.kernel.org message-ID URL in the Link: trailer.

All other checkers passed cleanly. Once these two link/content issues are resolved, the PR will be ready to merge.

Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-16-0575304c9624@oss.qualcomm.com
Dmitry Baryshkov (lumag) and others added 19 commits July 10, 2026 12:17
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-17-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-18-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-19-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-20-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-21-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on QRD8550
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-22-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on QRD8650
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-23-0575304c9624@oss.qualcomm.com
Stop using fixed and IDs and covert the platform to use dynamic IDs for
the interconnect. This gives more flexibility and also allows us to drop
the .num_links member, saving from possible errors related to it being
not set or set incorrectly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-24-0575304c9624@oss.qualcomm.com
Now as all RPMh interconnect drivers were converted to using the dynamic
IDs, drop support for non-dynamic ID allocation.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251031-rework-icc-v3-25-0575304c9624@oss.qualcomm.com
…perty to enable QoS

Aggre1-noc interconnect node on QCS615 has QoS registers located
inside a block whose interface is clock-gated. Accessing these
registers requires the corresponding clock(s) to be enabled.
Update the bindings to include the 'clocks' property.

Ensure that only aggre1-noc interconnect node uses this property
by explicitly forbidding it for all other interconnect nodes.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260311103548.1823044-2-odelu.kukatla@oss.qualcomm.com
Enable QoS configuration for master ports with predefined priority
and urgency forwarding.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260311103548.1823044-3-odelu.kukatla@oss.qualcomm.com
Add clocks which need to be enabled for configuring QoS on
talos SoC.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260311103548.1823044-4-odelu.kukatla@oss.qualcomm.com
Remove the explicit compound-literal casts from all `link_nodes`
initializers in kaanapali interconnect nodes.

Signed-off-by: Georgi Djakov <djakov@kernel.org>
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5ffe1910ed3e44ea2e442eda3afc06681f587aad
Git-commit: 5ffe191
Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: Swetha Chintavatla <chintava@qti.qualcomm.com>
…operty to enable QoS

Some QCS8300 interconnect nodes have QoS registers located inside
a block whose interface is clock-gated. For those nodes, driver
must enable the corresponding clock(s) before accessing the
registers. Add the 'clocks' property so the driver can obtain
and enable the required clock(s).

Only interconnects that have clock‑gated QoS register interface
use this property; it is not applicable to all interconnect nodes.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260127090116.1438780-2-odelu.kukatla@oss.qualcomm.com
Enable QoS configuration for master ports with predefined priority
and urgency forwarding.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260127090116.1438780-3-odelu.kukatla@oss.qualcomm.com
Add clocks which need to be enabled for configuring QoS on
qcs8300 SoC.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260127090116.1438780-4-odelu.kukatla@oss.qualcomm.com
… enable QoS on sa8775p

Add 'reg' and 'clocks' properties to enable QoS configuration. These
properties enable access to QoS registers and necessary clocks for
configuration.

QoS configuration is essential for ensuring that latency sensitive
components such as CPUs and multimedia engines receive prioritized
access to memory and interconnect resources. This helps to manage
bandwidth and latency across subsystems, improving system responsiveness
and performance in concurrent workloads.

Both 'reg' and 'clocks' properties are optional. If either is missing,
QoS configuration will be skipped. This behavior is controlled by the
'qos_requires_clocks' flag in the driver, which ensures that QoS
configuration is bypassed when required clocks are not defined.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20251001073344.6599-2-odelu.kukatla@oss.qualcomm.com
Enable QoS configuration for master ports with predefinedi priority
and urgency forwarding.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251001073344.6599-3-odelu.kukatla@oss.qualcomm.com
…guration

Add register addresses and clocks which need to be enabled for
configuring QoS on sa8775p SoC.

Signed-off-by: Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251001073344.6599-4-odelu.kukatla@oss.qualcomm.com
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4598092 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4598092
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #809 — validate-patch

PR: #809

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Cannot verify - network access required to fetch commit messages
  2. Lore link matches PR commits: No (1 commit) - sdx75 commit flagged as mismatched; remaining 34 commits cannot be verified without network access
  3. Upstream patch status: Cannot verify - network access required to check lore threads and git trees
  4. PR present in qcom-next: Cannot verify - network access required (preferred repo at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel not accessible)
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #809 - Interconnect QoS and dynamic IDs conversion
Upstream commit: Multiple lore.kernel.org links (35 commits)
Verdict: ⚠️ PARTIAL - Cannot fully validate (network restricted)

Summary

This PR contains 35 commits converting Qualcomm interconnect drivers to dynamic IDs and enabling QoS configuration. The commits are prefixed as:

  • 32 UPSTREAM: commits
  • 3 BACKPORT: commits (sdx75, sa8775p interconnect and DTS)

Known Issues from CI

The check-patch-compliance checker already identified one issue:

Commit: BACKPORT: interconnect: qcom: sdx75: convert to dynamic IDs
Issue: "Change is different from the one mentioned in Link"

This indicates the diff content in the PR does not match the lore.kernel.org link provided in the commit message.

Validation Constraints

Due to network restrictions and empty pr.patch file, full validation cannot be performed:

  1. ❌ Cannot fetch PR diff from GitHub
  2. ❌ Cannot fetch upstream lore patches via b4/curl
  3. ❌ Cannot verify commit message fidelity to upstream
  4. ❌ Cannot check diff content matches lore patches
  5. ❌ Cannot verify upstream acceptance status
  6. ❌ Cannot check qcom-next presence

Commit Message

Check Status Note
Subject matches upstream ⚠️ Cannot verify - no network access
Body preserves rationale ⚠️ Cannot verify - no network access
Fixes tag present/correct N/A Not applicable for these commits
Authorship preserved ⚠️ Cannot verify - no network access
Backport note (if applicable) ⚠️ 3 BACKPORT commits need verification

Diff

File Status Notes
drivers/interconnect/qcom/* ⚠️ Cannot verify - no PR diff available
arch/arm64/boot/dts/qcom/* ⚠️ Cannot verify - no PR diff available
Documentation/devicetree/bindings/* ⚠️ Cannot verify - no PR diff available

Issues

  1. BACKPORT: sdx75 commit mismatch - The check-patch-compliance checker reported "Change is different from the one mentioned in Link" for commit "BACKPORT: interconnect: qcom: sdx75: convert to dynamic IDs". This requires investigation:

    • Verify the lore link in the commit message points to the correct upstream patch
    • Compare the PR diff against the lore patch to identify divergence
    • If extra changes exist, they should be split into a separate commit with appropriate prefix
  2. Network access required - Full validation requires:

  3. BACKPORT commits need special attention - Three commits use BACKPORT: prefix:

    • interconnect: qcom: sdx75: convert to dynamic IDs (already flagged)
    • interconnect: qcom: sa8775p: enable QoS configuration
    • arm64: dts: qcom: sa8775p: Add reg and clocks for QoS configuration

    For BACKPORT: commits, verify:

    • Original author preserved in From:/Author: field
    • Backport note present explaining adaptations
    • Link to original upstream commit included

Verdict

Cannot complete full validation due to network restrictions. The PR requires manual review with network access to:

  1. Immediate action: Investigate the sdx75 commit flagged by check-patch-compliance
  2. Full validation: Fetch all 35 lore patches and compare against PR diffs
  3. Authorship check: Verify all UPSTREAM: commits preserve original authors
  4. Backport verification: Confirm all 3 BACKPORT: commits document their adaptations

Final Summary

  1. Lore link present: Cannot verify - network access required to fetch commit messages
  2. Lore link matches PR commits: No (1 commit) - sdx75 commit flagged as mismatched; remaining 34 commits cannot be verified without network access
  3. Upstream patch status: Cannot verify - network access required to check lore threads and git trees
  4. PR present in qcom-next: Cannot verify - network access required (preferred repo at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel not accessible)

Recommendation

Do not merge until:

  1. The sdx75 commit mismatch is resolved
  2. Full validation is performed with network access
  3. All 35 commits are verified against their lore sources
  4. Authorship and backport notes are confirmed correct

@qlijarvis

Copy link
Copy Markdown

PR #809 — checker-log-analyzer

PR: #809
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29074931182

Checker Result Summary
Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check 3 binding files validated successfully
dtb-check All DTB warnings are pre-existing
sparse-check No new sparse warnings
check-uapi-headers No UAPI changes detected
check-patch-compliance 2 commits failed validation
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #809 - Interconnect QoS and dynamic IDs updates
Target branch: qcom-6.18.y
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29074931182

Checker Result Summary
checkpatch All 35 commits passed
dt-binding-check 3 binding files validated successfully
dtb-check All DTB warnings are pre-existing
sparse-check No new sparse warnings
check-uapi-headers No UAPI changes detected
check-patch-compliance 2 commits failed validation
tag-check All commits have valid prefixes (UPSTREAM:/BACKPORT:)

❌ check-patch-compliance

Root cause: Two commits have upstream link validation issues.

Failure 1: Content mismatch

Checking commit: BACKPORT: interconnect: qcom: sdx75: convert to dynamic IDs
Change is different from the one mentioned in Link

Analysis: The commit is correctly tagged as BACKPORT: (indicating modifications from upstream), but the checker detected that the patch content differs from the upstream version referenced in the Link: trailer. This is expected behavior for backports that require adaptations.

Fix: Verify the backport is intentional and correct:

# Fetch the upstream patch
b4 am --single-message -C -l -3 <link-from-commit-message> -o /tmp/upstream.mbx

# Compare the changes
git show <commit-sha> > /tmp/pr-commit.patch
diff -u /tmp/upstream.mbx /tmp/pr-commit.patch

# If the differences are legitimate adaptations (e.g., context changes, 
# missing dependencies, or vendor-specific adjustments), document them
# in the commit message body above the Link: line, e.g.:
#
#   [ Upstream commit <sha> ]
#   
#   Backported to qcom-6.18.y:
#   - Adjusted context due to missing commit XYZ
#   - Removed changes to file ABC (not present in this tree)
#   
#   Link: https://lore.kernel.org/...

Failure 2: Link fetch failed

Checking commit: UPSTREAM: interconnect: qcom: kaanapali: Drop redundant link_nodes casts
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5ffe1910ed3e44ea2e442eda3afc06681f587aad

Analysis: The commit uses a git.kernel.org cgit URL instead of a lore.kernel.org mbox link. The check-patch-compliance checker expects lore.kernel.org URLs that b4 can fetch directly.

Fix: Replace the git.kernel.org URL with the corresponding lore.kernel.org link:

# Find the correct lore link for commit 5ffe1910ed3e44ea2e442eda3afc06681f587aad
# Search on lore.kernel.org for the patch subject or commit ID

# Then amend the commit to use the lore link:
git rebase -i <base_sha>   # mark the commit as 'edit'
git commit --amend         # edit the Link: line to use lore.kernel.org URL
git rebase --continue

The correct format should be:

Link: https://lore.kernel.org/r/<message-id>

or

Link: https://lore.kernel.org/linux-arm-msm/<message-id>/

Reproduce locally:

# For the sdx75 backport content mismatch:
cd <kernel-tree>
git log --oneline --grep="sdx75: convert to dynamic IDs"
# Find the commit SHA, then:
../kernel-checkers/check-patch-compliance.sh <base_sha> <head_sha>

# For the kaanapali link issue:
b4 am --single-message -C -l -3 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5ffe1910ed3e44ea2e442eda3afc06681f587aad
# This will fail because b4 expects lore.kernel.org URLs

Verdict

2 non-blocking issues to address before merge:

  1. BACKPORT: sdx75 — Content mismatch is expected for backports, but verify the changes are intentional and document the adaptations in the commit message if not already done.

  2. UPSTREAM: kaanapali — Replace the git.kernel.org cgit URL with the corresponding lore.kernel.org mbox link in the Link: trailer.

All other checkers passed cleanly. The dtb-check warnings visible in the logs are pre-existing tree issues (camera DTSI reg_format and avoid_default_addr_size warnings) that were already present at the base commit and are not introduced by this PR.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ◻️ ⚠️ skip ◻️ ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet ◻️ ⚠️ skip ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
IPA ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
OpenCV ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ◻️ ✅ Pass ❌ Fail ❌ Fail ❌ Fail
RMNET ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
USBHost ◻️ ❌ Fail ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail
WiFi_Firmware_Driver ◻️ ❌ Fail ◻️ ❌ Fail ❌ Fail ✅ Pass ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass
adsp_remoteproc ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
cdsp_remoteproc ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ❌ Fail ❌ Fail
gpdsp_remoteproc ◻️ ❌ Fail ◻️ ⚠️ skip ⚠️ skip ✅ Pass ❌ Fail
hotplug ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
remoteproc ◻️ ❌ Fail ◻️ ✅ Pass ✅ Pass ✅ Pass ❌ Fail
rngtest ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ◻️ ❌ Fail ◻️ ❌ Fail ✅ Pass ✅ Pass ❌ Fail
watchdog ◻️ ✅ Pass ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ◻️ ⚠️ skip ✅ Pass ✅ Pass ✅ Pass

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_SCAN ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
DSP_AudioPD ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Ethernet ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
OpenCV ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
USBHost ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
WiFi_Firmware_Driver ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
cdsp_remoteproc ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
gpdsp_remoteproc ◻️ ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ◻️ ✅ Pass
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
shmbridge ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
smmu ◻️ ❌ Fail ✅ Pass ❌ Fail ✅ Pass ◻️ ❌ Fail
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case hamoa-iot-evk lemans-evk monaco-evk qcs615-ride qcs6490-rb3gen2 qcs8300-ride qcs9100-ride-r3
BT_FW_KMD_Service ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_ON_OFF ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
BT_SCAN ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPUFreq_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
CPU_affinity ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
DSP_AudioPD ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Ethernet ◻️ ⚠️ skip ⚠️ skip ⚠️ skip ⚠️ skip ◻️ ⚠️ skip
Freq_Scaling ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
GIC ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
IPA ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Interrupts ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
OpenCV ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
PCIe ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
Probe_Failure_Check ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
RMNET ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
UFS_Validation ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
USBHost ◻️ ❌ Fail ❌ Fail ❌ Fail ❌ Fail ◻️ ❌ Fail
WiFi_Firmware_Driver ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
WiFi_OnOff ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
adsp_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
cdsp_remoteproc ◻️ ✅ Pass ❌ Fail ✅ Pass ✅ Pass ◻️ ✅ Pass
gpdsp_remoteproc ◻️ ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ◻️ ✅ Pass
hotplug ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
irq ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
kaslr ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
pinctrl ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
qcom_hwrng ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
rngtest ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
shmbridge ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
smmu ◻️ ❌ Fail ✅ Pass ❌ Fail ✅ Pass ◻️ ❌ Fail
watchdog ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass
wpss_remoteproc ◻️ ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️ ✅ Pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants