Skip to content

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1#815

Open
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1_imx_kodiak_qli2.0
Open

QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1#815
mvadlama-lab wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
mvadlama-lab:cam1_imx_kodiak_qli2.0

Conversation

@mvadlama-lab

Copy link
Copy Markdown

CAM1 port is currently enabled for OV9282.This change adds DTSI configuration for IMX577 so that CAM1 can also support IMX577 sensor on the hardware platform of QCM6490 Dev.

CRs-Fixed: 4243195

CAM1 port is currently enabled for OV9282.This change adds
DTSI configuration for IMX577 so that CAM1 can also support
IMX577 sensor on the hardware platform of QCM6490 Dev.

Signed-off-by: Vadlamani Manjusha <mvadlama@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4243195 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4243195
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #815 — validate-patch

PR: #815

Verdict Issues Detailed Report
1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #815 — QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS (vendor-only)

Commit Message

Check Status Note
Subject matches upstream N/A Vendor-only commit; no upstream source
Body preserves rationale Clear description of CAM1 IMX577 sensor support
Fixes tag present/correct N/A New feature addition; no Fixes tag required
Authorship preserved Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi Adds eeprom_cam1 and qcom,cam-sensor12 nodes for IMX577 (78 lines)

Issues

  • Minor: Missing space after period in commit body: "OV9282.This" should be "OV9282. This"

Verdict

Merge as-is. This is a vendor-specific device tree addition for IMX577 camera sensor support on QCM6490 RB3 Gen2. The commit message clearly describes the change, authorship is correct, and the diff adds the expected EEPROM and sensor configuration nodes. The minor spacing issue in the commit message does not affect functionality.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next: Not checked — QCLINUX: vendor-only commit

@qlijarvis

Copy link
Copy Markdown

PR #815 — checker-log-analyzer

PR: #815
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29011270950

Checker Result Summary
Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New schema validation failures for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (branch is qcom-6.18.y, not qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #815 - QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29011270950

Checker Result Summary
checkpatch 2 warnings: undocumented DT compatible strings
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check New schema validation failures for qcom,eeprom and qcom,cam-sensor
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no C/H changes)
check-patch-compliance QCLINUX: prefix not in allowed list
tag-check Subject has valid prefix (branch is qcom-6.18.y, not qcom-next)

❌ checkpatch

Root cause: Two undocumented DT compatible strings used in the new DTSI file.

Failure details:

WARNING: DT compatible string "qcom,eeprom" appears un-documented
#26: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:180:
+		compatible = "qcom,eeprom";

WARNING: DT compatible string "qcom,cam-sensor" appears un-documented
#64: FILE: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-camera-sensor.dtsi:218:
+		compatible = "qcom,cam-sensor";

318e29e1bb29 total: 0 errors, 2 warnings, 0 checks, 84 lines checked

Fix: Add DT binding YAML files for these compatible strings:

  1. Create Documentation/devicetree/bindings/media/qcom,eeprom.yaml
  2. Create Documentation/devicetree/bindings/media/qcom,cam-sensor.yaml

Or, if these are vendor-specific camera subsystem nodes not intended for upstream, document them in a vendor-specific binding file.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git cf2725e2d166..318e29e1bb29

❌ dtb-check

Root cause: The new DTS nodes use qcom,eeprom and qcom,cam-sensor compatible strings that have no schema bindings, causing validation failures.

Failure details:

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb:
  /soc@0/qcom,cci0/qcom,eeprom1: failed to match any schema with compatible: ['qcom,eeprom']

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb:
  /soc@0/qcom,cci0/qcom,cam-sensor12: failed to match any schema with compatible: ['qcom,cam-sensor']

qcom,eeprom1 (qcom,eeprom): gpio-req-tbl-label: b'CAMIF_MCLK1 CAM_RESET1 CAM_CUSTOM1 '
  is not of type 'object', 'integer', 'array', 'boolean', 'null'

qcom,cam-sensor12 (qcom,cam-sensor): gpio-req-tbl-label: b'CAMIF_MCLK1 CAM_RESET1 CAM_CUSTOM1 '
  is not of type 'object', 'integer', 'array', 'boolean', 'null'

qcom,cci0 (qcom,cci): qcom,eeprom1: 'ranges' is a required property
qcom,cci0 (qcom,cci): qcom,cam-sensor12: 'ranges' is a required property

Fix:

  1. Add DT binding schema files for qcom,eeprom and qcom,cam-sensor compatible strings
  2. Define the gpio-req-tbl-label property type correctly in the binding (should be an array of strings, not a space-separated string)
  3. Add ranges property to the parent qcom,cci0 node if required by the CCI binding

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine-camx.dtb

❌ check-patch-compliance

Root cause: The commit uses QCLINUX: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: Add IMX577 DTSI changes to Support CAM1
Commit summary does not start with a required prefix

Fix: This is a known limitation of the check-patch-compliance checker. The QCLINUX: prefix is a valid vendor-internal prefix used in the Qualcomm Linux tree for vendor-only changes that have no upstream equivalent. However, the checker only accepts upstream-linkable prefixes.

Options:

  1. If this change is vendor-only (not intended for upstream): Accept that this checker will always fail. This is expected behavior for QCLINUX: commits.
  2. If this change could be posted upstream: Change the prefix to FROMLIST: and add a Link: tag pointing to the lore.kernel.org mailing list thread.

For vendor-only DTS changes like camera sensor configurations specific to Qualcomm development boards, option 1 is appropriate — the checker failure is expected and can be ignored.


Verdict

3 blockers to fix before merge:

  1. checkpatch warnings — Add DT binding YAML files for qcom,eeprom and qcom,cam-sensor, or document why these vendor-specific compatibles don't need upstream bindings.

  2. dtb-check failures — The new nodes fail schema validation because:

    • No binding exists for qcom,eeprom and qcom,cam-sensor
    • Property types are incorrect (gpio-req-tbl-label should be an array, not a string)
    • Missing ranges property in parent CCI node
  3. check-patch-compliance failure — This is a known limitation for QCLINUX: prefixed commits. If this is genuinely a vendor-only change, this failure can be accepted as-is. If the change should be upstreamed, change the prefix to FROMLIST: and add a Link: tag.

Recommendation: Fix items 1 and 2 (add bindings and fix property types). Item 3 can be accepted if this is vendor-only work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants