Add Shikra memory dump table and DCC register list

[Jie Gan (jiegan0107)]

Add Shikra memory dump table and DCC register list

CRs-Fixed: 4603749

[qlijarvis]

PR #820 — validate-patch

PR: #820

Verdict	Issues	Detailed Report
✅	0	Full report

Final Summary

Commit 1:

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Yes — d2b684d4e5b3

Commit 2:

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Yes — cbdd4bbfa24a

Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #820 - QCLINUX: Add Shikra platform support (DCC and memory dump)
Upstream commit: N/A (vendor-only commits)
Verdict: ✅ PASS

Commit 1: QCLINUX: qcom-dcc: add shikra register list and move config to header

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear description of DCC register list for Shikra (SoC IDs 756, 758, 759)
Fixes tag present/correct	N/A	New feature, not a fix
Authorship preserved	✅	Jie Gan jie.gan@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/misc/qcom-dcc-dev.c	✅	Adds Shikra SoC ID cases (756, 758, 759) and includes new header
drivers/misc/qcom-dcc-shikra-config.h	✅	New file with 677 lines of DCC register configuration

Commit 2: QCLINUX: memory-dump: add memory dump table for Shikra

Commit Message

Check	Status	Note
Subject matches upstream	N/A	QCLINUX: vendor-only commit
Body preserves rationale	✅	Clear description of memory dump table for Shikra
Fixes tag present/correct	N/A	New feature, not a fix
Authorship preserved	✅	Jie Gan jie.gan@oss.qualcomm.com
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/firmware/qcom/memory_dump_dev.c	✅	Adds 46 lines of memory dump table configuration for Shikra

Verdict

Both commits are well-formed vendor-only changes with the correct QCLINUX: prefix. Commit messages are clear and descriptive. Both commits are already present in qcom-next. Safe to merge.

Final Summary

Commit 1:

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Yes — d2b684d4e5b3

Commit 2:

1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
2. Lore link matches PR commits: N/A — no lore link to compare against
3. Upstream patch status: N/A — vendor-only change, not posted upstream
4. PR present in qcom-next: Yes — cbdd4bbfa24a

[qlijarvis]

PR #820 — checker-log-analyzer

PR: #820
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29229170791

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	1 CHECK warning (alignment)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	2 commits with QCLINUX: prefix
tag-check	✅	Both commits have valid prefix (QCLINUX:)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #820 - Add Shikra DCC and memory dump support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29229170791
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	❌	1 CHECK warning (alignment)
dt-binding-check	⏭️	No DT binding changes
dtb-check	⏭️	No DTS changes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	2 commits with QCLINUX: prefix
tag-check	✅	Both commits have valid prefix (QCLINUX:)

---

❌ checkpatch

Root cause: Alignment mismatch in function call arguments (commit 58afcc8).

Failure details:

Commit 58afcc84d2e6 ("QCLINUX: memory-dump: add memory dump table for Shikra")
CHECK: Alignment should match open parenthesis
#78: FILE: drivers/firmware/qcom/memory_dump_dev.c:524:
+		ret = platform_device_add_data(mem_dump_pdev,
+				&shikra_dump_table, sizeof(shikra_dump_table));

58afcc84d2e6 total: 0 errors, 0 warnings, 1 checks, 64 lines checked

Fix: Align the second line of arguments with the opening parenthesis:

// Current (incorrect):
ret = platform_device_add_data(mem_dump_pdev,
		&shikra_dump_table, sizeof(shikra_dump_table));

// Fixed:
ret = platform_device_add_data(mem_dump_pdev,
			       &shikra_dump_table, sizeof(shikra_dump_table));

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git e8d06c707464..ea058483

Fix command:

git rebase -i e8d06c707464   # mark commit 58afcc84d2e6 as 'edit'
# Fix alignment in drivers/firmware/qcom/memory_dump_dev.c:524
git add drivers/firmware/qcom/memory_dump_dev.c
git commit --amend --no-edit
git rebase --continue

---

❌ check-patch-compliance

Root cause: Both commits use the QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: qcom-dcc: add shikra register list and move config to header
Commit summary does not start with a required prefix

Checking commit: QCLINUX: memory-dump: add memory dump table for Shikra
Commit summary does not start with a required prefix

Analysis:
The check-patch-compliance checker only accepts these prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:. The QCLINUX: prefix is a vendor-internal tag used for Qualcomm-specific changes that have no upstream equivalent.

This is a known limitation of the checker — it enforces upstream-linkable prefixes only. Since these commits are vendor-only additions (Shikra-specific DCC register lists and memory dump tables), they cannot have upstream links and will always fail this check.

Fix: None required. This is expected behavior for vendor-only commits. The QCLINUX: prefix is correct for this use case. The checker limitation is documented in the skill references.

---

Verdict

1 blocker to fix before merge:

• Fix the alignment issue in drivers/firmware/qcom/memory_dump_dev.c:524 (commit 58afcc8)

Known limitation (no action needed):

• The check-patch-compliance failure is expected for QCLINUX:-prefixed commits and does not block merge

[qcomlnxci]

Test jobs on ea05848

• Job 161893 on hamoa-iot-evk
• Job 161894 on lemans-evk
• Job 161896 on monaco-evk
• Job 161890 on qcs615-ride
• Job 161891 on qcs6490-rb3gen2
• Job 161895 on qcs8300-ride
• Job 161892 on qcs9100-ride-r3

[qcomlnxci]

Test Matrix

Test Case	hamoa-iot-evk	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3
BT_FW_KMD_Service	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
BT_ON_OFF	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
BT_SCAN	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
CPUFreq_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
CPU_affinity	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
DSP_AudioPD	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Ethernet	◻️	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️	⚠️ skip
Freq_Scaling	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
GIC	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
IPA	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Interrupts	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
OpenCV	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
PCIe	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Probe_Failure_Check	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	❌ Fail
RMNET	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
UFS_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
USBHost	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	❌ Fail
WiFi_Firmware_Driver	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	✅ Pass
WiFi_OnOff	◻️	✅ Pass	❌ Fail	✅ Pass	✅ Pass	◻️	✅ Pass
adsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
cdsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
gpdsp_remoteproc	◻️	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	◻️	✅ Pass
hotplug	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
irq	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
kaslr	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
pinctrl	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
qcom_hwrng	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
rngtest	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
shmbridge	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
smmu	◻️	❌ Fail	✅ Pass	❌ Fail	✅ Pass	◻️	❌ Fail
watchdog	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
wpss_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass

[qcomlnxci]

Test jobs on ea05848

• Job 164663 on hamoa-iot-evk
• Job 164665 on lemans-evk
• Job 164661 on monaco-evk
• Job 164660 on qcs615-ride
• Job 164659 on qcs6490-rb3gen2
• Job 164662 on qcs8300-ride
• Job 164664 on qcs9100-ride-r3

[qcomlnxci]

Test Matrix

Test Case	hamoa-iot-evk	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	⚠️ skip	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Ethernet	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
USBHost	✅ Pass	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
WiFi_Firmware_Driver	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass
WiFi_OnOff	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
gpdsp_remoteproc	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	✅ Pass
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
rngtest	✅ Pass	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
smmu	❌ Fail	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass

[Salendarsingh Gaud (sgaud-quic)]

Jie Gan (@jiegan0107) No mainline PR in CR.

[Jie Gan (jiegan0107)]

Jie Gan (Jie Gan (@jiegan0107)) No mainline PR in CR.

added manually