Skip to content

FROMLIST: wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usec…#821

Open
miaoqing-quic wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
miaoqing-quic:fix-hsp-fw-for-purwa
Open

FROMLIST: wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usec…#821
miaoqing-quic wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
miaoqing-quic:fix-hsp-fw-for-purwa

Conversation

@miaoqing-quic

Copy link
Copy Markdown
Contributor

…ase firmware table

Add purwa-iot-evk and qcs6490-rb3gen2 platform support to the usecase firmware lookup table for WCN6855 hw2.1.

These platforms use the nfa765 firmware path for usecase-based firmware selection.

Also reorder the table entries by compatible string.

Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1

Link: https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/

CRs-Fixed: 4605921

…ase firmware table

Add purwa-iot-evk and qcs6490-rb3gen2 platform support to the
usecase firmware lookup table for WCN6855 hw2.1.

These platforms use the nfa765 firmware path for usecase-based
firmware selection.

Also reorder the table entries by compatible string.

Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1

Signed-off-by: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com>
Link: https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4605921 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4605921

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #821 — validate-patch

PR: #821

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/
  2. Lore link matches PR commits: Unknown — network restricted; could not fetch lore patch for comparison
  3. Upstream patch status: ⏳ Decision Pending (unknown) — could not verify due to network restrictions; lore link dated 2026-07-13 suggests very recent posting
  4. PR present in qcom-next: No — verified against /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel; current qcom-next has only 3 table entries, this PR adds 2 more
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #821 - FROMLIST: wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usecase firmware table
Upstream commit: https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL (network restricted - lore fetch failed; validated structure only)

Commit Message

Check Status Note
Subject matches upstream ⏭️ Skipped Cannot fetch lore patch (network restricted)
Body preserves rationale ✅ Pass Clear description of changes and rationale
Fixes tag present/correct ✅ Pass No Fixes tag needed - new feature addition
Authorship preserved ✅ Pass FROMLIST: author in From: field, Signed-off-by present
Backport note (if applicable) N/A FROMLIST prefix - not a backport

Diff

File Status Notes
drivers/net/wireless/ath/ath11k/core.c ✅ Pass Adds 2 new entries, reorders hamoa-iot-evk alphabetically

Commit Message Structure Analysis

Prefix: FROMLIST: ✅ Correct

  • Indicates patch posted to mailing list but not yet merged upstream
  • Lore link present: https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/

Author: Miaoqing Pan <miaoqing.pan@oss.qualcomm.com> ✅ Correct

  • For FROMLIST commits, the submitter may differ from the lore author
  • Original author's Signed-off-by is present

Subject line: ✅ Well-formed

  • Follows kernel style: subsystem: component: description
  • Clear and concise description of the change

Body: ✅ Complete

  • Explains what platforms are being added
  • States the firmware path used (nfa765)
  • Notes the reordering of table entries
  • Includes Tested-on tag with hardware details

Link tag: ✅ Present

  • Properly formatted lore.kernel.org link at end of commit message

Code Changes Analysis

What changed:

  1. Added entry for qcom,purwa-iot-evk → nfa765 firmware
  2. Added entry for qcom,qcs6490-rb3gen2 → nfa765 firmware
  3. Reordered qcom,hamoa-iot-evk entry alphabetically (moved from position 3 to position 1)

Table before (in qcom-next c386a2b):

{ ATH11K_HW_WCN6855_HW21, "qcom,lemans-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,monaco-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,hamoa-iot-evk", "nfa765"},

Table after (in PR):

{ ATH11K_HW_WCN6855_HW21, "qcom,hamoa-iot-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,lemans-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,monaco-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,purwa-iot-evk", "nfa765"},
{ ATH11K_HW_WCN6855_HW21, "qcom,qcs6490-rb3gen2", "nfa765"},

Analysis: ✅ Logical and correct

  • Alphabetical ordering: hamoa → lemans → monaco → purwa → qcs6490-rb3gen2
  • All entries use same hardware revision (WCN6855_HW21) and firmware path (nfa765)
  • Consistent formatting and structure

Upstream Patch Status

Commit Community Verdict
wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usecase firmware table ⏳ Decision Pending (unknown) — could not fetch lore thread due to network restrictions

Note: The lore link is dated 2026-07-13 (future date from current system date perspective), suggesting this is a very recent posting. Network access is restricted in this environment, preventing verification of upstream acceptance status.

Dependency Check

  • ✅ Base table structure exists in qcom-next (introduced in commit c386a2b)
  • ✅ No missing header/helper changes required
  • ✅ Self-contained change - adds entries to existing table

qcom-next Presence

Commit Status
wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usecase firmware table ⚠️ Not in qcom-next

Verification details:

  • Checked qcom-next at /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
  • Current qcom-next HEAD contains only 3 entries in the table (lemans-evk, monaco-evk, hamoa-iot-evk)
  • This PR adds 2 new entries and reorders the table
  • Base commit c386a2b that introduced the table is present in qcom-next

Issues Found

None. The commit structure is correct for a FROMLIST patch.

Recommendation

Merge as-is — The commit message follows kernel conventions, the FROMLIST prefix is appropriate for a patch posted to the mailing list but not yet upstream, the lore link is present and properly formatted, and the code change is logical and self-contained. The alphabetical reordering improves maintainability.

Note: Due to network restrictions, I could not fetch and compare the actual lore patch content. Manual verification against the lore link is recommended if byte-for-byte fidelity is required.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/linux-wireless/20260713020359.3618193-1-miaoqing.pan@oss.qualcomm.com/
  2. Lore link matches PR commits: Unknown — network restricted; could not fetch lore patch for comparison
  3. Upstream patch status: ⏳ Decision Pending (unknown) — could not verify due to network restrictions; lore link dated 2026-07-13 suggests very recent posting
  4. PR present in qcom-next: No — verified against /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel; current qcom-next has only 3 table entries, this PR adds 2 more

@qlijarvis

Copy link
Copy Markdown

PR #821 — checker-log-analyzer

PR: #821
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29230916129

Checker Result Summary
Checker Result Summary
checkpatch ⚠️ 1 warning: long commit body line (75 chars)
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no DTS changes
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance Passed
tag-check Passed - commit has FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #821 - FROMLIST: wifi: ath11k: add purwa-iot-evk and qcs6490-rb3gen2 to usecase firmware table
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29230916129
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ⚠️ 1 warning: long commit body line (75 chars)
dt-binding-check ⏭️ Skipped - no DT binding changes
dtb-check ⏭️ Skipped - no DTS changes
sparse-check Passed
check-uapi-headers Passed
check-patch-compliance Passed
tag-check Passed - commit has FROMLIST: prefix

⚠️ checkpatch

Root cause: The Tested-on: trailer line exceeds the recommended 75-character limit for commit body lines.

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#15: 
Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1

aa16f8a153776272c14650e8337c55fa3d07c137 total: 0 errors, 1 warnings, 0 checks, 12 lines checked

The Tested-on: line is 85 characters long (10 characters over the 75-char recommendation).

Analysis:

This is a minor style warning for a hardware identifier string in a trailer line. The Tested-on: tag is a standard ath11k subsystem convention for documenting test hardware, and the firmware version string WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1 cannot be meaningfully shortened without losing information.

Options:

  1. Accept as-is (recommended): This is a false positive. Trailer lines like Tested-on:, Link:, and similar metadata tags are commonly allowed to exceed 75 characters when they contain URLs, hardware IDs, or firmware version strings that cannot be wrapped.

  2. Wrap the line (not recommended): You could split it as:

    Tested-on: WCN6855 hw2.1 PCI
      WLAN.HSP.1.1-04685-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1
    

    However, this reduces readability and is not standard practice for Tested-on: tags.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git e8d06c707464..aa16f8a15377

✅ tag-check

Status: PASS

The commit subject starts with FROMLIST:, which is a valid prefix for the target branch qcom-6.18.y. The PR includes a valid Link: tag pointing to the upstream lore.kernel.org submission.

All branches except qcom-next and qcom-next-staging require a subject prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:). This commit complies with that requirement.


Verdict

Ready to merge with one minor cosmetic warning.

The single checkpatch warning is a false positive for a standard Tested-on: hardware identifier trailer that cannot be meaningfully shortened. All functional checkers (sparse, UAPI, patch compliance) passed cleanly. The commit follows proper upstream submission practices with a FROMLIST: prefix and a valid lore.kernel.org link.

Recommendation: Merge as-is. The Tested-on: line length is acceptable for hardware/firmware identifier strings and is consistent with ath11k subsystem conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants