FROMLIST: Add Coresight nodes for Shikra by jiegan0107 · Pull Request #824 · qualcomm-linux/kernel

Jie Gan (jiegan0107) · 2026-07-14T08:47:47Z

Add DT nodes for the CoreSight debug and trace subsystem on Qualcomm Shikra SoC.

CRs-Fixed: 4607858

qlijarvis · 2026-07-14T09:35:05Z

PR #824 — validate-patch

PR: #824

Verdict	Issues	Detailed Report
⚠️	2	Full report

Final Summary

Lore link present: Yes — both commits have correctly formatted Link: tags pointing to lore.kernel.org
Lore link matches PR commits: ⏭️ Cannot verify — network restrictions prevent fetching lore patches for comparison
Upstream patch status: ⏭️ Cannot verify — network restrictions prevent fetching lore threads to check acceptance/rejection signals
PR present in qcom-next:
- Commit 1/2: No — qcom,shikra-ctcu not found in qcom-next
- Commit 2/2: Partial — Different version found as 5f9f6b52570d with significantly different stats (+111 insertions, +98 deletions difference)

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #824 — Add CTCU device and coresight nodes for shikra
Commits: 2 commits (both FROMLIST)

Commit 1/2: FROMLIST: dt-bindings: arm: add CTCU device for shikra

Upstream commit: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-1-b1cf85962455@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL — Cannot verify diff faithfulness (network restricted); commit message structure correct

Commit Message

Check Status Note

Subject matches upstream ⏭️ Skipped Cannot fetch lore patch (network restricted)

Body preserves rationale ✅ Pass Clear description of CTCU fallback to SA8775p

Fixes tag present/correct N/A Not a fix commit

Authorship preserved ⏭️ Skipped FROMLIST: lore author in Signed-off-by (cannot verify From: without lore fetch)

Backport note (if applicable) N/A Not a backport

Link tag present ✅ Pass Link: tag present and correctly formatted

Diff

File Status Notes

Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml ⏭️ Skipped Cannot compare to lore patch (network restricted)

Upstream Patch Status

⏭️ Skipped — Cannot fetch lore thread to determine acceptance status (network restricted)

qcom-next Presence

⚠️ Not in qcom-next — Searched by file path and subject; qcom,shikra-ctcu not present in origin/qcom-next:Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml

Issues

Network restriction: Cannot fetch lore patch to verify diff faithfulness or upstream acceptance status

qcom-next absence: Commit not found in qcom-next; may not have landed yet

Verdict

Cannot fully validate due to network restrictions. Commit message structure is correct (FROMLIST prefix, Link tag, Signed-off-by present). Manual verification required: fetch lore patch and compare diff when network access is available.

Commit 2/2: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes

Upstream commit: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/
Verdict: ⚠️ PARTIAL — qcom-next version differs; cannot verify lore faithfulness (network restricted)

Commit Message

Check Status Note

Subject matches upstream ⏭️ Skipped Cannot fetch lore patch (network restricted)

Body preserves rationale ✅ Pass Clear description of CoreSight subsystem addition

Fixes tag present/correct N/A Not a fix commit

Authorship preserved ⏭️ Skipped FROMLIST: lore author in Signed-off-by (cannot verify From: without lore fetch)

Backport note (if applicable) N/A Not a backport

Link tag present ✅ Pass Link: tag present and correctly formatted

Diff

File Status Notes

arch/arm64/boot/dts/qcom/shikra.dtsi ⚠️ Warning PR: +1499/-200 lines; qcom-next 5f9f6b52570d: +1388/-102 lines — stats differ significantly

Upstream Patch Status

⏭️ Skipped — Cannot fetch lore thread to determine acceptance status (network restricted)

qcom-next Presence

⚠️ Different version in qcom-next — Found as 5f9f6b52570d but:

qcom-next commit lacks FROMLIST: prefix and Link: tag

qcom-next commit date: Fri May 8 21:56:00 2026 vs PR: Tue, 14 Jul 2026 16:22:37

qcom-next stats: +1388/-102 vs PR: +1499/-200 — 209 more insertions, 98 more deletions in PR

This suggests the PR contains a newer or different revision than what landed in qcom-next.

Issues

Network restriction: Cannot fetch lore patch to verify diff faithfulness or upstream acceptance status

qcom-next divergence: PR commit differs significantly from qcom-next version:

Different line counts (+111 insertions, +98 deletions)

Different commit metadata (date, prefix, Link tag)

Possible causes:

PR is a newer lore revision (v2, v3, etc.) not yet in qcom-next

PR includes additional changes beyond the qcom-next commit

qcom-next commit was an earlier version before FROMLIST prefix was added

Verdict

Review required. The PR commit has significantly more changes than the qcom-next version. Without lore access, cannot determine if:

The extra changes are legitimate updates from a newer lore revision, or

The PR incorrectly bundles unrelated changes

Recommendation: Manually verify the lore link when network access is available to confirm the PR matches the posted patch series.

Final Summary

Lore link present: Yes — both commits have correctly formatted Link: tags pointing to lore.kernel.org

Lore link matches PR commits: ⏭️ Cannot verify — network restrictions prevent fetching lore patches for comparison

Upstream patch status: ⏭️ Cannot verify — network restrictions prevent fetching lore threads to check acceptance/rejection signals

PR present in qcom-next:

Commit 1/2: No — qcom,shikra-ctcu not found in qcom-next

Commit 2/2: Partial — Different version found as 5f9f6b52570d with significantly different stats (+111 insertions, +98 deletions difference)

Overall Assessment

⚠️ PARTIAL VALIDATION — Commit message structure is correct for both commits (FROMLIST prefix, Link tags, Signed-off-by present), but:

Network restrictions prevent full validation of diff faithfulness and upstream acceptance status

Commit 2/2 divergence from qcom-next version requires investigation:

PR has 209 more insertions and 98 more deletions than qcom-next 5f9f6b52570d

This could indicate a newer lore revision or unintended bundled changes

Action required: When network access is available:

Fetch both lore patches using b4 am <message-id>

Compare PR diffs against lore diffs using interdiff or filterdiff

Verify upstream acceptance status by scanning lore threads for merge/NAK signals

Investigate why commit 2/2 differs from qcom-next version — check if lore has multiple revisions (v1, v2, etc.)

qlijarvis · 2026-07-14T09:35:06Z

PR #824 — checker-log-analyzer

PR: #824
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/29320312734

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	No style issues
dt-binding-check	✅	Schema validation passed
dtb-check	❌	Pre-existing iommus validation error exposed
sparse-check	⏭️	Skipped (no C/H changes)
check-uapi-headers	⏭️	Skipped (no UAPI changes)
check-patch-compliance	❌	Content mismatch with upstream link
tag-check	✅	Both commits have FROMLIST: prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #824 - Add coresight nodes for shikra
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/29320312734

Checker Result Summary

checkpatch ✅ No style issues

dt-binding-check ✅ Schema validation passed

dtb-check ❌ Pre-existing iommus validation error exposed

sparse-check ⏭️ Skipped (no C/H changes)

check-uapi-headers ⏭️ Skipped (no UAPI changes)

check-patch-compliance ❌ Content mismatch with upstream link

tag-check ✅ Both commits have FROMLIST: prefix

❌ dtb-check

Root cause: Pre-existing video-codec@5a00000 node in shikra.dtsi has an iommus property with insufficient cells for the qcom,shikra-iris binding.

Failure details:
shikra-cqm-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqm-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-cqs-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[43, 1920, 32]] is too short
shikra-iqs-evk.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[42, 1920, 32]] is too short
shikra-iqs-evk-imx577-camera.dtb: video-codec@5a00000 (qcom,shikra-iris): iommus: [[42, 1920, 32]] is too short
Analysis: This PR adds coresight nodes to shikra.dtsi but does not modify the video-codec@5a00000 node. The error is flagged as "new" by the checker because:

The checker subtracts base_dtbs_errors.log from head_dtbs_errors.log

This error was not present in the base build, likely because these specific shikra DTB variants were not built or validated at the base commit

The video-codec@5a00000 node is pre-existing in shikra.dtsi and has an iommus property that doesn't meet the cell count requirements of the qcom,shikra-iris binding

Fix: The iommus property in the video-codec@5a00000 node needs additional cells. Check the qcom,shikra-iris binding schema to determine the required cell count and update the iommus property accordingly in shikra.dtsi.

Reproduce locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb
❌ check-patch-compliance

Root cause: The second commit's content differs from the upstream patch referenced in the Link: tag.

Failure details:
Checking commit: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes
Change is different from the one mentioned in Link
Analysis: The commit references:
Link: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/
The checker fetched the upstream patch using b4 am and found that the diff content doesn't match. This could be due to:

Context line differences (false positive)

Additional changes not in the upstream version

Missing hunks from the upstream version

The upstream patch was updated after the Link was added

Fix:
# Fetch the upstream patch
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-2-b1cf85962455@oss.qualcomm.com/ -o /tmp/upstream

# Compare the actual changes (+ and - lines only)
git format-patch -1 bbb3559721cf --stdout > /tmp/pr-patch.txt
diff <(awk '/^diff/,/^--$/' /tmp/pr-patch.txt | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/upstream/*.mbx | grep -E '^[+-][^+-]')
If the differences are:

Context-only shifts: Document this as an acceptable adaptation

Legitimate adaptations: Add a note in the commit message explaining the changes

Missing hunks: Cherry-pick the missing changes

Extra hunks: Consider splitting into a separate commit or removing if not needed

Reproduce locally:
cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 48143db58c4c --head bbb3559721cf
Verdict

2 blockers to fix before merge:

dtb-check (pre-existing): The video-codec@5a00000 iommus validation error is a pre-existing issue in shikra.dtsi that's now being exposed by this PR's DTB builds. While not introduced by this PR, it blocks CI. Options:

Fix the video-codec@5a00000 iommus property in this PR

Request maintainer approval to merge despite pre-existing tree issue

File a separate issue/PR to fix the video-codec node

check-patch-compliance (content mismatch): The second commit's diff doesn't match the upstream lore link. Investigate and either:

Update the commit to match upstream exactly

Document the intentional differences in the commit message

Update the Link: tag if the upstream patch was revised

Jie Gan (jiegan0107) · 2026-07-14T09:37:05Z

check-patch-compliance | ❌ | Content mismatch with upstream link -- | -- | --

The content of the lore link has issue. It shows the patch diff twice, but the content is correct in received message.

qcomlnxci · 2026-07-14T12:54:13Z

Test jobs on bbb3559

qcomlnxci · 2026-07-14T12:54:13Z

Test Matrix

Test Case	hamoa-iot-evk	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3
BT_FW_KMD_Service	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
BT_ON_OFF	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
BT_SCAN	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
CPUFreq_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
CPU_affinity	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
DSP_AudioPD	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Ethernet	◻️	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️	⚠️ skip
Freq_Scaling	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
GIC	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
IPA	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Interrupts	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
OpenCV	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
PCIe	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
Probe_Failure_Check	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	❌ Fail
RMNET	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
UFS_Validation	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
USBHost	◻️	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️	❌ Fail
WiFi_Firmware_Driver	◻️	✅ Pass	❌ Fail	✅ Pass	✅ Pass	◻️	✅ Pass
WiFi_OnOff	◻️	✅ Pass	❌ Fail	✅ Pass	✅ Pass	◻️	✅ Pass
adsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
cdsp_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
gpdsp_remoteproc	◻️	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	◻️	✅ Pass
hotplug	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
irq	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
kaslr	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
pinctrl	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
qcom_hwrng	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
rngtest	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
shmbridge	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
smmu	◻️	❌ Fail	✅ Pass	❌ Fail	✅ Pass	◻️	❌ Fail
watchdog	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass
wpss_remoteproc	◻️	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass

qcomlnxci · 2026-07-14T19:36:19Z

Test jobs on bbb3559

qcomlnxci · 2026-07-14T19:36:20Z

Test Matrix

Test Case	hamoa-iot-evk	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	⚠️ skip	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Ethernet	⚠️ skip	⚠️ skip	⚠️ skip	◻️	⚠️ skip	⚠️ skip	⚠️ skip
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	◻️	❌ Fail	✅ Pass	✅ Pass
GIC	✅ Pass	✅ Pass	✅ Pass	◻️	❌ Fail	✅ Pass	✅ Pass
IPA	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Interrupts	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
OpenCV	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
PCIe	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail
RMNET	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
USBHost	✅ Pass	❌ Fail	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail
WiFi_Firmware_Driver	❌ Fail	✅ Pass	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass
WiFi_OnOff	❌ Fail	✅ Pass	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
gpdsp_remoteproc	⚠️ skip	✅ Pass	✅ Pass	◻️	⚠️ skip	✅ Pass	✅ Pass
hotplug	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
irq	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
kaslr	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
pinctrl	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
remoteproc	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
rngtest	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
shmbridge	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
smmu	❌ Fail	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
watchdog	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass

The CTCU device for shikra shares the same configurations as SA8775p. Add a fallback to enable the CTCU for shikra to utilize the compatible of the SA8775p. Link: https://lore.kernel.org/all/20260714-add-coresight-nodes-for-shikra-v1-1-b1cf85962455@oss.qualcomm.com/ Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

Add DT nodes for the CoreSight debug and trace subsystem on Qualcomm Shikra SoC. Link: https://lore.kernel.org/all/20260715-add-coresight-nodes-for-shikra-v2-2-ebd485e39a51@oss.qualcomm.com/ Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>

Jie Gan (jiegan0107) requested review from a team, knaveen-qc, Nicolas Dechesne (ndechesne) and Tingwei Zhang (quic-tingweiz) July 14, 2026 08:47

Jie Gan (jiegan0107) force-pushed the shikra-coresight branch from 3b33437 to bbb3559 Compare July 14, 2026 08:59

Tingwei Zhang (quic-tingweiz) previously approved these changes Jul 14, 2026

View reviewed changes

Jie Gan (jiegan0107) dismissed Tingwei Zhang (quic-tingweiz)’s stale review via a47d268 July 15, 2026 07:48

Jie Gan (jiegan0107) force-pushed the shikra-coresight branch from bbb3559 to a47d268 Compare July 15, 2026 07:48

qcomlnxci requested review from a team and Rajendra (rrnayak) July 15, 2026 07:49

Jie Gan (jiegan0107) and others added 2 commits July 16, 2026 09:53

Jie Gan (jiegan0107) force-pushed the shikra-coresight branch from a47d268 to 44dda89 Compare July 16, 2026 01:54

Uh oh!

Conversation

Jie Gan (jiegan0107) commented Jul 14, 2026

Uh oh!

qlijarvis commented Jul 14, 2026

PR #824 — validate-patch

Final Summary

🔍 Patch Validation

Commit 1/2: FROMLIST: dt-bindings: arm: add CTCU device for shikra

Commit Message

Diff

Upstream Patch Status

qcom-next Presence

Issues

Verdict

Commit 2/2: FROMLIST: arm64: dts: qcom: shikra: Add coresight nodes

Commit Message

Diff

Upstream Patch Status

qcom-next Presence

Issues

Verdict

Final Summary

Overall Assessment

Uh oh!

qlijarvis commented Jul 14, 2026

PR #824 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ dtb-check

❌ check-patch-compliance

Verdict

Uh oh!

Jie Gan (jiegan0107) commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qcomlnxci commented Jul 14, 2026

Test jobs on bbb3559

Uh oh!

qcomlnxci commented Jul 14, 2026

Test Matrix

Uh oh!

qcomlnxci commented Jul 14, 2026

Test jobs on bbb3559

Uh oh!

qcomlnxci commented Jul 14, 2026

Test Matrix

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jie Gan (jiegan0107) commented Jul 14, 2026 •

edited

Loading