Skip to content

FROMLIST scsi: ufs: ufs-qcom: Enable only lane clocks in lane clock APIs #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggiriprasad wants to merge 1 commit into
base: qcom-6.18.y
Choose a base branch
from
+39 −5
Open

FROMLIST scsi: ufs: ufs-qcom: Enable only lane clocks in lane clock APIs #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 36 additions & 5 deletions drivers/ufs/host/ufs-qcom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,9 @@ static void ufs_qcom_disable_lane_clks(struct ufs_qcom_host *host)
if (!host->is_lane_clks_enabled)
return;

clk_bulk_disable_unprepare(host->num_clks, host->clks);
clk_disable_unprepare(host->rx_lane1_sync_clk);
clk_disable_unprepare(host->rx_lane0_sync_clk);
clk_disable_unprepare(host->tx_lane0_sync_clk);

host->is_lane_clks_enabled = false;
}
Expand All @@ -370,18 +372,35 @@ static int ufs_qcom_enable_lane_clks(struct ufs_qcom_host *host)
{
int err;

err = clk_bulk_prepare_enable(host->num_clks, host->clks);
if (host->is_lane_clks_enabled)
return 0;

err = clk_prepare_enable(host->tx_lane0_sync_clk);
if (err)
return err;
goto out;

host->is_lane_clks_enabled = true;
err = clk_prepare_enable(host->rx_lane0_sync_clk);
if (err)
goto out_disable_tx_lane0;

err = clk_prepare_enable(host->rx_lane1_sync_clk);
if (err)
goto out_disable_rx_lane0;

host->is_lane_clks_enabled = true;
return 0;

out_disable_rx_lane0:
clk_disable_unprepare(host->rx_lane0_sync_clk);
out_disable_tx_lane0:
clk_disable_unprepare(host->tx_lane0_sync_clk);
out:
return err;
}

static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host)
{
int err;
int err, i;
struct device *dev = host->hba->dev;

if (has_acpi_companion(dev))
Expand All @@ -393,6 +412,18 @@ static int ufs_qcom_init_lane_clks(struct ufs_qcom_host *host)

host->num_clks = err;

for (i = 0; i < host->num_clks; i++) {
if (!host->clks[i].id)
continue;
if (!strcmp(host->clks[i].id, "tx_lane0_sync_clk"))
host->tx_lane0_sync_clk = host->clks[i].clk;
else if (!strcmp(host->clks[i].id, "rx_lane0_sync_clk"))
host->rx_lane0_sync_clk = host->clks[i].clk;
else if (!strcmp(host->clks[i].id, "rx_lane1_sync_clk"))
if (host->hba->lanes_per_direction > 1)
host->rx_lane1_sync_clk = host->clks[i].clk;
}

return 0;
}

Expand Down
3 changes: 3 additions & 0 deletions drivers/ufs/host/ufs-qcom.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,9 @@ struct ufs_qcom_host {
struct ufs_hba *hba;
struct ufs_pa_layer_attr dev_req_params;
struct clk_bulk_data *clks;
struct clk *tx_lane0_sync_clk;
struct clk *rx_lane0_sync_clk;
struct clk *rx_lane1_sync_clk;
u32 num_clks;
bool is_lane_clks_enabled;

Expand Down