fix: resolve failing tests and type errors across api and shared packages#44
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#44stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages
- Implement paginate() utility in shared package (was a throwing stub)
- Fix auth middleware case-sensitivity bug ("post" -> "POST") so POST /users is public
- Add missing badRequest import in users route handler
- Rename User.userName -> username in shared types for cross-package consistency
- Add bun-types to tsconfig types (already an installed devDependency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (now 22/22 pass) and eliminates all
tsc --noEmittype errors across theapiandsharedpackages. Changes are minimal and confined to source/config — no test files modified, no dependencies added.Changes
packages/shared/src/utils/pagination.ts— Implemented thepaginate()utility (was a throwing stub). Handles empty input, out-of-range pages, partial last pages, and computestotal/totalPages/page/pageSizecorrectly.packages/api/src/middleware/auth.ts— Fixed a case-sensitivity bug in the HTTP method comparison soPOST /usersis correctly treated as a public route. Also resolved theprocesstype error.packages/api/src/routes/users.ts— Added the missingbadRequestimport that caused a runtime failure on the missing-fields path.packages/shared/src/types.ts— RenamedUser.userName→usernameto resolve a field-name inconsistency between the shared type and its consumers/tests.tsconfig.json— Addedbun-typesto thetypesarray (already an installed devDependency — not a new dependency).Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ exit 0, no errorsAssumptions
usernamefield name; the shared type (userName) was the inconsistent side and was aligned to the tests rather than editing tests.bun-typeswas treated as a config fix (existing devDependency) rather than a new dependency.