fix: resolve failing tests and type errors across api and shared packages#48
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#48stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ages
- auth middleware: correct HTTP method case ('post' -> 'POST') so POST /users is public
- shared types: align User field to 'username' for cross-package consistency
- users route: import missing 'badRequest' error helper
- shared pagination: implement paginate() stub with edge-case handling
- tsconfig: add explicit bun-types for global resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors in the multi-package API repo.
bun testnow reports 22 pass / 0 fail andbunx tsc --noEmitis clean.Bugs fixed
packages/api/src/middleware/auth.ts"post", soc.req.method(always uppercasePOST) never matched — everyPOST /userswas wrongly 401'd. Changed to"POST".packages/shared/src/types.tsUsertype useduserNamewhile route handlers and tests useusername. Aligned the canonical type tousername.packages/api/src/routes/users.tsbadRequestwas called but not imported — runtimeReferenceErroron missing-field POSTs. Added it to the existing import.packages/shared/src/utils/pagination.tsthrow "not implemented"stub with a realpaginate()(page slice, total, totalPages, empty-array and out-of-range handling).tsconfig.json"types": ["bun-types"]so Bun globals/bun:testresolve. No strictness loosened.Verification
bun test→ 22 pass, 0 failbunx tsc --noEmit→ no errorsConstraints honoured
bun-typeswas already present).