fix: repair failing tests and type errors across api and shared packages#49
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#49stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…te imports - auth middleware: use uppercase HTTP method allow-list so POST /users is correctly treated as public - shared types: canonicalise User field to 'username' across both packages - pagination: implement paginate<T>() with correct slice/totalPages edge-case handling - routes/users: add missing badRequest import and align field name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (22 pass, 0 fail) and eliminates all
tsc --noEmittype errors across theapiandsharedpackages.Changes
packages/api/src/middleware/auth.ts): replaced a case-sensitive lowercase string comparison with an uppercase HTTP-method allow-list checked againstc.req.method(which Hono normalises to uppercase).POST /usersis now correctly treated as a public route.packages/shared/src/types.ts): canonicalised theUserfield name tousername, matching what the tests and API routes expect, resolving the cross-package inconsistency.packages/shared/src/utils/pagination.ts): implemented the previously-stubbedpaginate<T>(items, page, size)with correct page-slice, partial-last-page, out-of-range, empty-input, andtotalPageshandling per the test contract.packages/api/src/routes/users.ts): added the missingbadRequestimport and aligned the field name.Verification
bun test-> 22 pass, 0 failnpx tsc --noEmit-> clean (exit 0)Assumptions
Userfield name isusername(the form the tests assert against).Notes